Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@stephanieelliott Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a beta disclaimer to the Uber for Business integration documentation. The change is minimal but important for setting user expectations. The document itself is well-structured and follows HelpDot standards effectively. Scores Summary
Key FindingsStrengths:
Minor Observations:
Recommendations
Files Reviewed
Overall Quality Score: 8.7/10 - This is a well-executed documentation update for a beta feature. |
Documentation Review SummaryI reviewed the Uber for Business documentation and found some violations that should be addressed: Issues with Changed Lines (Addressed inline):✅ Line 9: Beta note formatting - commented inline Pre-existing Issues in the File:While these issues exist in lines not changed by this PR, they should be addressed for full HelpDot compliance: AI Readiness Violations:
Readability Violations:
Style Compliance:
These issues don't block the beta note addition, but should be addressed in a follow-up to ensure the documentation meets HelpDot standards. |
|
A preview of your ExpensifyHelp changes have been deployed to https://cc7c220e.helpdot.pages.dev ⚡️ Updated articles: |
Added instructions for Expensify Classic users
Co-authored-by: Tom Rhys Jones <tom@expensify.com>
|
@sakluger looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
We're sending out comms today that links to this help doc. The check was the PR reviewer checklist, which was just completed less than an hour ago for the previous commit. |
|
🚀 Deployed to staging by https://github.com/sakluger in version: 9.2.43-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.43-2 🚀
|
Explanation of Change
The Uber 4 Business integration is still in beta. Adding a disclaimer at the top directing people to reach out to Concierge to get set up.
Fixed Issues
https://github.com/Expensify/Expensify/issues/528799
Tests
No Tests
Offline tests
N/A
QA Steps
Manual QA - review the help doc and verify the text shows up correctly.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop