Prevent redundant API call when re-selecting the same role on member details page by twilight2294 · Pull Request #74215 · Expensify/App

twilight2294 · 2025-11-04T16:53:52Z

Explanation of Change

Fixed Issues

$ #73923
PROPOSAL: #73923 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition: Workspace with members

Navigate to workspace settings
Open the member details page for any user
Locate the role selector (e.g., Member, Admin)
Select the same role the user currently has

Expect that No API call (UpdateWorkspaceMembersRole) should be made if the selected role is the same as the existing one.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-11-07.at.5.40.07.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-11-07.at.5.43.41.PM.mov

iOS: Native

Screen.Recording.2025-11-07.at.4.59.40.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-11-07.at.5.01.58.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-04.at.10.28.21.PM.mov

MacOS: Desktop

Screen.Recording.2025-11-07.at.4.37.30.PM.mov

melvin-bot · 2025-11-04T16:59:29Z

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

twilight2294 · 2025-11-04T17:00:16Z

@abzokhattab i am having some setup issue for mobile recordings, i will update them tomorrow after fixing it, in the meantime i recorded web videos, in the mean time i think you can also work on reviewers checklist if the code looks fine to you

github-actions · 2025-11-04T17:02:16Z

LGTM . Thank you for your hard work!

codecov · 2025-11-04T17:03:56Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...s/workspace/members/WorkspaceMemberDetailsPage.tsx	`0.00% <0.00%> (ø)`
... and 4 files with indirect coverage changes

trjExpensify · 2025-11-05T00:21:58Z

PR doesn’t need product input as a code clean-up PR. Unassigning and unsubscribing myself.

abzokhattab · 2025-11-06T18:21:56Z

src/pages/workspace/WorkspaceMembersPage.tsx

-        });
-
-        const accountIDsToUpdate = loginsToUpdate.map((login) => policyMemberEmailsToAccountIDs[login]).filter((id) => id !== undefined);
+        const loginsToUpdate: string[] = [];


Isn't this doing the same thing as the old code?

@twilight2294 i have a pending question here, can you please check

The old code used to loop over 2 times for the logsin to update the same values, i updated it to create a single for loop and we update both of these values in one for loop rather than iterating the array 2 times

Left a comment in the code too to make it clear:

https://github.com/Expensify/App/pull/74215/files#diff-e1b326f5a2dc9985458c8372d0b5dac4ed8ce5609cf65b3a30756b74dea8badfR492-R493

The old code looks cleaner to me. If the 2 loops are the only concern, then we should revert it. Especially that its not change the logic.

What do u think

any updates on this? .. i still see it is still pending

sorry, it was weekend , started the day just now, i will update this today

Yes sorry, I thought u overlooked it as I saw this comment #74215 (comment)

It's fine, i should had kept you updated 😄

abzokhattab · 2025-11-06T18:49:04Z

Can you please complete the video list @twilight2294 ?

In desktop you can press on cmd + i to enable the developer tools

In case of mobile, just ensure that the selection is working as before, to be safe that everything is working the same

twilight2294 · 2025-11-06T19:11:00Z

@abzokhattab i am having some setup issue for mobile recordings, i will update them tomorrow after fixing it, in the meantime i recorded web videos, in the mean time i think you can also work on reviewers checklist if the code looks fine to you

still facing this issue , i have a fix ready it’s very late for me, i will update those and answer your questions above tomorrow

twilight2294 · 2025-11-07T12:11:09Z

I updated the PR @abzokhattab , you can continue with your checklist

twilight2294 · 2025-11-11T07:54:11Z

@abzokhattab typecheck failure seems to be unrelated here, you can continue with your review

abzokhattab · 2025-11-11T14:59:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-06.at.19.54.03.mov

Android: mWeb Chrome

Screen.Recording.2025-11-06.at.19.49.49.mov

iOS: HybridApp

Screen.Recording.2025-11-06.at.19.54.03.mov

iOS: mWeb Safari

Screen.Recording.2025-11-06.at.19.49.49.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-06.at.19.29.31.mov

MacOS: Desktop

Screen.Recording.2025-11-06.at.19.46.28.mov

abzokhattab · 2025-11-11T16:03:52Z

lets merge from main again it should be fixed now @twilight2294

twilight2294 · 2025-11-11T18:20:01Z

Done!

OSBotify · 2025-11-11T20:34:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-12T16:08:37Z

🚀 Deployed to staging by https://github.com/cead22 in version: 9.2.55-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-13T01:21:09Z

🚀 Deployed to staging by https://github.com/cead22 in version: 9.2.57-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-13T17:13:55Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.57-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

fix redundant api calls when no roles are updated

f8c99f9

melvin-bot bot assigned twilight2294 Nov 4, 2025

twilight2294 changed the title ~~fix redundant api calls when no roles are updated~~ Prevent redundant API call when re-selecting the same role on member details page Nov 4, 2025

twilight2294 marked this pull request as ready for review November 4, 2025 16:59

twilight2294 requested review from a team as code owners November 4, 2025 16:59

melvin-bot bot requested a review from abzokhattab November 4, 2025 16:59

melvin-bot bot requested review from trjExpensify and removed request for a team November 4, 2025 16:59

trjExpensify removed their request for review November 5, 2025 00:21

blimpich mentioned this pull request Nov 5, 2025

[Due for payment 2025-11-19] Improve CodeCov comment formatting #74374

Closed

abzokhattab reviewed Nov 6, 2025

View reviewed changes

Merge branch 'Expensify:main' into issue73923

e15b8b4

twilight2294 requested a review from abzokhattab November 7, 2025 12:15

twilight2294 added 2 commits November 11, 2025 09:09

Merge branch 'Expensify:main' into issue73923

985979f

Update WorkspaceMembersPage.tsx

7425c05

abzokhattab approved these changes Nov 11, 2025

View reviewed changes

melvin-bot bot requested a review from cead22 November 11, 2025 14:59

cead22 approved these changes Nov 11, 2025

View reviewed changes

Merge branch 'Expensify:main' into issue73923

02e0bd6

cead22 merged commit df9975a into Expensify:main Nov 11, 2025
25 checks passed

OSBotify mentioned this pull request Nov 12, 2025

Deploy Checklist: New Expensify 2025-11-12 #74958

Closed

67 tasks

melvin-bot bot mentioned this pull request Nov 13, 2025

[Due for payment 2025-11-20] [$250] Prevent redundant API call when re-selecting the same role on member details page #73923

Closed

16 tasks

Conversation

twilight2294 commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 4, 2025

Uh oh!

twilight2294 commented Nov 4, 2025

Uh oh!

github-actions bot commented Nov 4, 2025

Uh oh!

codecov bot commented Nov 4, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify commented Nov 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abzokhattab Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abzokhattab Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abzokhattab commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twilight2294 commented Nov 6, 2025

Uh oh!

twilight2294 commented Nov 7, 2025

Uh oh!

twilight2294 commented Nov 11, 2025

Uh oh!

abzokhattab commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abzokhattab commented Nov 11, 2025

Uh oh!

twilight2294 commented Nov 11, 2025

Uh oh!

Uh oh!

OSBotify commented Nov 11, 2025

Uh oh!

OSBotify commented Nov 12, 2025

Uh oh!

OSBotify commented Nov 13, 2025

Uh oh!

OSBotify commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

twilight2294 commented Nov 4, 2025 •

edited

Loading

codecov bot commented Nov 4, 2025 •

edited by github-actions bot

Loading

abzokhattab Nov 7, 2025 •

edited

Loading

abzokhattab Nov 9, 2025 •

edited

Loading

abzokhattab commented Nov 6, 2025 •

edited

Loading

abzokhattab commented Nov 11, 2025 •

edited

Loading