Skip to content

[CP Staging] Revert "fix: Delete WS modal briefly appears after clicking keep only one card feed"#74220

Merged
lakchote merged 1 commit intomainfrom
revert-73822-fix/71943
Nov 4, 2025
Merged

[CP Staging] Revert "fix: Delete WS modal briefly appears after clicking keep only one card feed"#74220
lakchote merged 1 commit intomainfrom
revert-73822-fix/71943

Conversation

@lakchote
Copy link
Contributor

@lakchote lakchote commented Nov 4, 2025

Reverts #73822

@lakchote lakchote requested review from a team as code owners November 4, 2025 17:39
@melvin-bot melvin-bot bot requested review from Valforte and trjExpensify and removed request for a team November 4, 2025 17:39
@melvin-bot
Copy link

melvin-bot bot commented Nov 4, 2025

@Valforte Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NikkiWines
NikkiWines approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

LGTM 👍 Thank you for your hard work!

@lakchote lakchote merged commit 0e20d13 into main Nov 4, 2025
26 of 29 checks passed
@lakchote lakchote deleted the revert-73822-fix/71943 branch November 4, 2025 17:48
@melvin-bot melvin-bot bot added the Emergency label Nov 4, 2025
@melvin-bot
Copy link

melvin-bot bot commented Nov 4, 2025

@lakchote looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@lakchote
Copy link
Contributor Author

lakchote commented Nov 4, 2025

Not an emergency, straight revert to fix a blocker.

@lakchote lakchote removed the Emergency label Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/pages/workspace/WorkspacesListPage.tsx 74.84% <ø> (ø)

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OSBotify
Copy link
Contributor

OSBotify commented Nov 4, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Nov 4, 2025
@lakchote @OSBotify
Merge pull request #74220 from Expensify/revert-73822-fix/71943
1b5414c 
[CP Staging] Revert "fix: Delete WS modal briefly appears after clicking keep only one card feed"

(cherry picked from commit 0e20d13)

(cherry-picked to staging by luacmartins)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 4, 2025
@OSBotify OSBotify mentioned this pull request Nov 4, 2025
Closed
54 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Nov 4, 2025

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.2.43-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 4, 2025

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.43-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 4, 2025

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.2.44-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 5, 2025

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.44-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

@JS00001 JS00001 JS00001 approved these changes

@trjExpensify trjExpensify Awaiting requested review from trjExpensify

@Valforte Valforte Awaiting requested review from Valforte

Assignees

@lakchote lakchote

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lakchote @OSBotify @NikkiWines @JS00001