[NO QA] Add GitHub action to format CodeCov comments#74508
[NO QA] Add GitHub action to format CodeCov comments#74508blimpich merged 17 commits intoExpensify:mainfrom
Conversation
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
I temporarily changed the condition that runs the pipeline so it checks for comments posted by my account instead of the Codecov bot. This lets me test the changes with real comments and see if everything works correctly. If it works as expected, I’ll add these conditions back 2be1e7b |
blimpich
left a comment
There was a problem hiding this comment.
Looks mostly good. Left a few comments with some questions/suggestions.
Also, one concern, we might want to update proposalPolice.yml to make sure it doesn't run on CodeCov comments. My worry is that editing CodeCov comments will trigger ProposalPolice to run unnecessarily, wasting resources.
.github/actions/javascript/formatCodeCovComment/formatCodeCovComment.ts
Outdated
Show resolved
Hide resolved
|
Ignore the ping @hoangzinh, no C+ review for this one |
|
@blimpich The PR is now ready for merge! let me know if you have any other comments to tackle if not lets merge it and monitor the behavior |
blimpich
left a comment
There was a problem hiding this comment.
Can we update proposalPolice.yml to not check if the comment is from CodeCov?
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
eslint check is taking a very long time for some reason |
|
merged in main to see if that fixes the weird eslint runner getting stuck issue |
|
Hmmm eslint issue seems to be happening on other PRs. Will investigate |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.2.49-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.2.49-0 🚀
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.2.52-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.54-1 🚀
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.2.52-0 🚀
|
Explanation of Change
Fixed Issues
$ #74374
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop