New Feature : Allow inviting new users from the card assignment dialog"

[twilight2294]

Explanation of Change

Fixed Issues

$ #60905
$ #74256
$ #74257
$ #74258
$ #74266
$ #74276
PROPOSAL: #60905 (comment)

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

• Workspace is set up with Expensify card and company card feature .

Test 1:

1. Open workspace with expensify cards added
2. Click on issue card
3. search for a non existent member of the workspace (new user), verify that the email of that new user appears
4. click on it > verify that a screen to invite that new user opens up
5. Invite that new member > Complete the remaining steps

Verify that you are able to complete the card assignment

Test 2:

1. Open workspace with company cards added
2. Click on issue card
3. search for a non existent member of the workspace (new user), verify that the email of that new user appears
4. click on it > verify that a screen to invite that new user opens up
5. Invite that new member > Complete the remaining steps

Verify that you are able to complete the card assignment

Test 3:

1. Go to workspace settings > Expensify Card > Click Issue card.
2. Go through the steps and reach the final confirmation page.
3. On confirmation page, click Cardholder field.

Verify that the selected cardholder will be highlighted.

Screen.Recording.2025-11-05.at.10.24.53.AM.mov

Test 4:

1. Go to workspace settings > Expensify Card > Click Issue card.
2. Go through the steps and reach the final confirmation page.
3. On confirmation page, click Cardholder field.
4. Enter email that is not workspace member > Select the user.
5. Click RHP back button.

Verify that the previously selected user on the confirmation screen is still selected.

Screen.Recording.2025-11-05.at.10.25.50.AM.mov

Test 5:

1. Go to workspace settings > Expensify Card > Click Issue card.
2. Enter email that is not a workspace member > Select the user.
3. Close the RHP by clicking outside the RHP.
4. Go to workspace settings > Members > Click Invite member.
5. Invite the same member in Step 4.
6. Go to workspace settings > Expensify Card > Click Issue card.

Verify that Issue card RHP opens up.

Screen.Recording.2025-11-05.at.10.38.43.AM.mov

Test 6:

Precondition: Workspace has company card added

1. Go to workspace settings > Company Card > Click Issue card.
2. Go through the steps and reach the final confirmation page.
3. On confirmation page, click Cardholder field.
4. Enter email that is not workspace member > Select the user.
5. Click RHP back button.
6. Search the same member again

Verify that you are directed to the invite screen

Screen.Recording.2025-11-05.at.2.00.39.PM.mov

Test 7:

1. Go to workspace settings > Expensify card > Click Issue card
2. Refresh the page.

Verify that In Step 1 and 2, member list on "Who needs a card" will show up instantly.

Screen.Recording.2025-11-05.at.1.59.39.PM.mov

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[melvin-bot]

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	85.71% <ø> (ø)
src/components/InteractiveStepWrapper.tsx	100.00% <ø> (ø)
...kspace/expensifyCard/issueNew/IssueNewCardPage.tsx	0.00% <ø> (ø)
src/pages/workspace/WorkspaceInviteMessagePage.tsx	0.00% <0.00%> (ø)
...ace/companyCards/assignCard/AssignCardFeedPage.tsx	55.55% <0.00%> (-3.27%)	⬇️
src/libs/actions/Card.ts	0.00% <0.00%> (ø)
...ace/expensifyCard/issueNew/InviteNewMemberStep.tsx	0.00% <0.00%> (ø)
...ce/companyCards/assignCard/InviteNewMemberStep.tsx	5.88% <5.88%> (ø)
...workspace/companyCards/assignCard/AssigneeStep.tsx	45.55% <44.00%> (-6.62%)	⬇️
.../workspace/expensifyCard/issueNew/AssigneeStep.tsx	0.00% <0.00%> (ø)
... and 1 more
... and 25 files with indirect coverage changes

[trjExpensify]

Product change conceived by the internal team in Slack 👍

[twilight2294]

@ZhenjaHorbach would you be able to review this one today?, hope you had a great weekend 😄

[ZhenjaHorbach]

Sorry for delay
I will check today

[ZhenjaHorbach]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2025-10-27.15.34.56.mov

Android: mWeb Chrome

2025-10-27.15.34.56.mov

iOS: HybridApp

2025-10-27.15.26.28.mov

iOS: mWeb Safari

2025-10-27.15.22.25.mov

MacOS: Chrome / Safari

2025-10-27.15.18.32.mov

2025-11-05.11.24.17.mov

2025-11-05.11.27.05.mov

2025-11-05.11.30.00.mov

2025-11-05.11.32.19.mov

MacOS: Desktop

2025-10-27.15.18.32.mov

[ZhenjaHorbach]

After these steps

Go to workspace settings > Expensify Card > Click Issue card.
Enter email that is not a workspace member > Select the user.
Close the RHP by clicking outside the RHP.
Go to workspace settings > Members > Click Invite member.
Invite the same member in Step 4.
Go to workspace settings > Expensify Card > Click Issue card.

Expensify Card screen is not opened after the first click

2025-11-11.10.41.10.mov

[twilight2294]

ahhh, good catch looking

[tylerkaraszewski]

Ugh, that's not what I wanted. I was aiming for one more internal reviewer. @ZhenjaHorbach , just mark it approved again please, no need to fill out the list again.

[twilight2294]

I think @puneetlath can review this since he is the CME on the original issue

[puneetlath]

Can you help me understand where there are so many changes where the policyID can now be undefined? What is the scenario where that happens?

[ZhenjaHorbach]

@twilight2294
And can you fix conflicts?

[twilight2294]

@puneetlath answering this question of yours:

There is an changed files eslint rule which states that we shouldn't pass empty strings for any collectionID, until now these functions were not updated and the functions had fallbacks like:

clearWorkspaceInviteRoleDraft(policyID ?? '')

With the new rule, this is discouraged now and we should pass undefined values down to the action function. I hope that answers your question

[twilight2294]

What is the scenario where that happens?

It doesn't happen , but it's a practice in the app to pass down undefined values to the functions:

App/src/libs/actions/Policy/PerDiem.ts

Line 395 in a7c2526

function fetchPerDiemRates(policyID: string | undefined) {

Please check similar usages in this app search:

• https://github.com/search?q=repo%3AExpensify%2FApp%20policyID%3A%20string%20%7C%20undefined&type=code

Alternatively, we can define the policyID type as string and return early if policyID is undefined , let me know if you prefer this approach

[puneetlath]

Alternatively, we can define the policyID type as string and return early if policyID is undefined , let me know if you prefer this approach

I think I prefer this approach. As it feels confusing to have the policyID allowed to be undefined in all these functions. What do you think @ZhenjaHorbach?

[twilight2294]

Cool, i'll push this change right away to not delay this PR further

[twilight2294]

@puneetlath this one is ready for your review :)

[ZhenjaHorbach]

It makes sense!

[puneetlath]

Looks like we have a typecheck failure @twilight2294

[twilight2294]

Fixed the failing tests @puneetlath , hopefully reassure also passes

[twilight2294]

All workflows pass 🥳

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.2.62-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.62-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅