Focus and highlight source transaction in Split Edit Table by ZhenjaHorbach · Pull Request #74691 · Expensify/App

ZhenjaHorbach · 2025-11-10T11:09:09Z

Explanation of Change

Fixed Issues

$ #70480
PROPOSAL:

Tests

Navigate to an eligible expense in your Reports or Expenses list.
Open the More menu.
Click the Split button.
Save the splits.
Open the created split transaction.
Click Edit Splits from the More menu, or click the amount.
Verify that the selected item (the expense from which the split edit screen was opened) is focused and highlighted.

Verify that no errors appear in the JS console

Offline tests

Navigate to an eligible expense in your Reports or Expenses list.
Open the More menu.
Click the Split button.
Save the splits.
Open the created split transaction.
Click Edit Splits from the More menu, or click the amount.
Verify that the selected item (the expense from which the split edit screen was opened) is focused and highlighted.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Navigate to an eligible expense in your Reports or Expenses list.
Open the More menu.
Click the Split button.
Save the splits.
Open the created split transaction.
Click Edit Splits from the More menu, or click the amount.
Verify that the selected item (the expense from which the split edit screen was opened) is focused and highlighted.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

2025-11-10.11.38.17.mov

Android: mWeb Chrome

2025-11-10.11.44.08.mov

iOS: Native

2025-11-10.11.38.17.mov

iOS: mWeb Safari

2025-11-10.12.03.15.mov

MacOS: Chrome / Safari

2025-11-10.11.42.36.mov

MacOS: Desktop

2025-11-10.11.42.36.mov

codecov · 2025-11-10T11:20:34Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useAnimatedHighlightStyle/index.ts	`94.11% <100.00%> (+0.36%)`	⬆️
...onents/SelectionListWithSections/SplitListItem.tsx	`0.00% <0.00%> (ø)`
... and 12 files with indirect coverage changes

ZhenjaHorbach · 2025-11-10T12:04:18Z

We have eslint issue related to runOnJS
But we ignore it following this comment

melvin-bot · 2025-11-11T13:09:58Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

heyjennahay

No concern with product change

eh2077 · 2025-11-12T16:59:46Z

src/components/SelectionListWithSections/SplitListItem.tsx

+    const inputCallbackRef = useCallback((ref: BaseTextInputRef | null) => {
+        inputRef.current = ref;
+    }, []);


I think it doesn't need to wrap with useCallback

Suggested change

const inputCallbackRef = useCallback((ref: BaseTextInputRef | null) => {

inputRef.current = ref;

}, []);

const inputCallbackRef = (ref: BaseTextInputRef | null) => {

inputRef.current = ref;

};

Makes sense!

…lit-edit-table

eh2077 · 2025-11-14T13:04:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-19.at.10.18.50.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-11-19.at.10.19.45.PM.mov

iOS: HybridApp

Screen.Recording.2025-11-19.at.10.20.08.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-11-19.at.10.20.43.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-19.at.10.17.17.PM.mov

MacOS: Desktop

Screen.Recording.2025-11-19.at.10.23.07.PM.mov

…lit-edit-table

eh2077 · 2025-11-17T13:58:45Z

@ZhenjaHorbach I think the eslint errors have to be fixed in this PR.

ZhenjaHorbach · 2025-11-17T14:11:36Z

@eh2077

We have eslint issue related to runOnJS But we ignore it following this comment

eh2077 · 2025-11-17T15:05:21Z

Hmm, I think this is related to https://expensify.slack.com/archives/C05LX9D6E07/p1763382246431219?thread_ts=1762501869.975859&cid=C05LX9D6E07 and seems it'll be handled in project #74599

ZhenjaHorbach · 2025-11-17T17:42:16Z

Hmm, I think this is related to https://expensify.slack.com/archives/C05LX9D6E07/p1763382246431219?thread_ts=1762501869.975859&cid=C05LX9D6E07 and seems it'll be handled in project #74599

Oh
Yes
We had an ESLint issue to runOnJS before
But when we talk about LAZY_ICONS_AND_ILLUSTRATIONS
Let's wait a bit
What we will decide here

But you can continue a review!

eh2077 · 2025-11-18T13:22:18Z

Code looks good but I can't work on recordings due to the outage of cloudfare. Will continue work on it once CF is back to normal.

…lit-edit-table

eh2077

LGTM

eh2077 · 2025-11-19T14:32:33Z

@lakchote Failing checks look unrelated but it'll be better if you could trigger run to double check.

lakchote · 2025-11-19T16:05:53Z

@lakchote Failing checks look unrelated but it'll be better if you could trigger run to double check.

I've re-ran them.

OSBotify · 2025-11-21T12:26:42Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.62-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-24T20:01:44Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.62-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Implement focus and highlight for selected items

c3912f1

melvin-bot bot assigned ZhenjaHorbach Nov 10, 2025

ZhenjaHorbach mentioned this pull request Nov 10, 2025

[Awaiting checklist] [Follow up] Focus and highlight source transaction in Split Edit Table #70480

Closed

ZhenjaHorbach marked this pull request as ready for review November 11, 2025 13:09

ZhenjaHorbach requested review from a team as code owners November 11, 2025 13:09

melvin-bot bot requested review from eh2077 and removed request for a team November 11, 2025 13:09

melvin-bot bot requested review from heyjennahay and removed request for a team November 11, 2025 13:09

heyjennahay previously approved these changes Nov 12, 2025

View reviewed changes

eh2077 reviewed Nov 12, 2025

View reviewed changes

Fix comments

bf114e7

ZhenjaHorbach dismissed heyjennahay’s stale review via bf114e7 November 13, 2025 09:21

Merge branch 'main' into focus-and-highlight-source-transaction-in-sp…

3200a20

…lit-edit-table

ZhenjaHorbach added 2 commits November 17, 2025 13:11

Merge branch 'main' into focus-and-highlight-source-transaction-in-sp…

fc63029

…lit-edit-table

Fix prettier issue

e05ee5f

Merge branch 'main' into focus-and-highlight-source-transaction-in-sp…

36149be

…lit-edit-table

eh2077 approved these changes Nov 19, 2025

View reviewed changes

melvin-bot bot requested a review from lakchote November 19, 2025 14:28

lakchote approved these changes Nov 19, 2025

View reviewed changes

lakchote merged commit dc09aa3 into Expensify:main Nov 19, 2025
31 of 33 checks passed

OSBotify mentioned this pull request Nov 21, 2025

Deploy Checklist: New Expensify 2025-11-21 #75728

Closed

Conversation

ZhenjaHorbach commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Nov 10, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ZhenjaHorbach commented Nov 10, 2025

Uh oh!

melvin-bot bot commented Nov 11, 2025

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

eh2077 Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

eh2077 commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 commented Nov 17, 2025

Uh oh!

ZhenjaHorbach commented Nov 17, 2025

Uh oh!

eh2077 commented Nov 17, 2025

Uh oh!

ZhenjaHorbach commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eh2077 commented Nov 18, 2025

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

eh2077 commented Nov 19, 2025

Uh oh!

lakchote commented Nov 19, 2025

Uh oh!

Uh oh!

OSBotify commented Nov 21, 2025

Uh oh!

OSBotify commented Nov 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ZhenjaHorbach commented Nov 10, 2025 •

edited

Loading

codecov bot commented Nov 10, 2025 •

edited by github-actions bot

Loading

eh2077 commented Nov 14, 2025 •

edited

Loading

ZhenjaHorbach commented Nov 17, 2025 •

edited

Loading