Avatar doesn't load when login from public room as existing user by lorretheboy · Pull Request #74819 · Expensify/App

lorretheboy · 2025-11-11T15:59:11Z

Explanation of Change

Fixed Issues

$ #74176
PROPOSAL: #74176 (comment)

Tests

Sign out if you are signed in
Open a public room: https://staging.new.expensify.com/r/2091104345528462
Sign in with existing user
Click on account setting icon
Verify that Avatar and user name should load on account page

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

ANDROID.mov

Android: mWeb Chrome

WEBSITE.ANDROID.mov

iOS: Native

IOS.mov

iOS: mWeb Safari

WEBSITE.IOS.mov

MacOS: Chrome / Safari

WEBSITE.mov

MacOS: Desktop

WEBSITE.IOS.mov

codecov · 2025-11-11T17:22:00Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../components/CurrentUserPersonalDetailsProvider.tsx	`100.00% <100.00%> (ø)`
... and 10 files with indirect coverage changes

lorretheboy · 2025-11-12T15:37:55Z

tests/ui/SessionTest.tsx

        await waitForBatchedUpdates();

-        expect(lastVisitedPath).toBe(`/${ROUTES.REPORT}/${report.reportID}`);
+        expect(lastVisitedPath).toBe(`/${ROUTES.HOME}`);


Need to update to HOME since currentUserPersonalDetails is updated when userAccountSelector changes (which happens when session?.email or userAccountID changes during sign-in). Besides, I tested the transition flow, it works fine. Please correct me if I'm wrong

False, this led to failing tests on main, see https://expensify.slack.com/archives/C01GTK53T8Q/p1765191955953569

It introduced flakiness, decided to revert see https://expensify.slack.com/archives/C01GTK53T8Q/p1765217642441119?thread_ts=1765217169.365099&cid=C01GTK53T8Q

melvin-bot · 2025-11-12T15:38:36Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-11-12T15:40:38Z

src/components/CurrentUserPersonalDetailsProvider.tsx

    );
-    const [currentUserPersonalDetails = defaultCurrentUserPersonalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {selector: userAccountSelector, canBeMissing: true});
+    const [currentUserPersonalDetails = defaultCurrentUserPersonalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {selector: userAccountSelector, canBeMissing: true}, [
+        userAccountSelector,


❌ PERF-6 (docs)

Passing entire objects or functions as dependencies causes hooks to re-execute whenever any property changes, even unrelated ones. Specifying individual properties creates more granular dependency tracking, reducing unnecessary hook executions and improving performance predictability.

Since userAccountSelector depends on session?.email and userAccountID (line 27), the dependency array should specify these individual properties instead:

const [currentUserPersonalDetails = defaultCurrentUserPersonalDetails] = useOnyx( ONYXKEYS.PERSONAL_DETAILS_LIST, {selector: userAccountSelector, canBeMissing: true}, [session?.email, userAccountID] );

@lorretheboy Can you fix this?

@shubham1206agra I think we can keep it as we add selector as dependency as a common pattern in our codebase. Do u think so?

App/src/hooks/useTripTransactions.ts

Line 49 in a7fab59

[tripTransactionsSelector],

JmillsExpensify

This looks fine from a product perspective, though I really don't think we should spend a lot of time on PRs involving public rooms.

shubham1206agra · 2025-12-06T15:54:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2025-12-06.at.9.23.15.PM.mov

lakchote

LGTM

lakchote · 2025-12-08T18:57:37Z

Reverting as it produces flakey tests, and failing tests when merging code to main.

cc @lorretheboy @shubham1206agra

OSBotify · 2025-12-09T15:28:45Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.74-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

IuliiaHerets · 2025-12-09T19:34:26Z

@lorretheboy QA team failed this PR on Android with an original issue

1765297832316.74819_Android-Fail_avatar.mp4

OSBotify · 2025-12-10T21:37:54Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-12-10T21:54:08Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-12-10T22:58:33Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Avatar doesn't load when login from public room as existing user

8c0f993

melvin-bot bot assigned lorretheboy Nov 11, 2025

lorretheboy added 2 commits November 12, 2025 00:16

chore: merge main

8d87abd

fix: test

745c879

lorretheboy commented Nov 12, 2025

View reviewed changes

lorretheboy marked this pull request as ready for review November 12, 2025 15:38

lorretheboy requested review from a team as code owners November 12, 2025 15:38

melvin-bot bot requested review from JmillsExpensify and shubham1206agra November 12, 2025 15:38

melvin-bot bot removed request for a team November 12, 2025 15:38

github-actions bot reviewed Nov 12, 2025

View reviewed changes

JmillsExpensify reviewed Nov 13, 2025

View reviewed changes

shubham1206agra approved these changes Dec 6, 2025

View reviewed changes

melvin-bot bot requested a review from lakchote December 6, 2025 15:54

shubham1206agra mentioned this pull request Dec 6, 2025

Revert "Remove useLiveRef" Expensify/react-native-onyx#710

Closed

lakchote reviewed Dec 8, 2025

View reviewed changes

lakchote approved these changes Dec 8, 2025

View reviewed changes

lakchote merged commit 731d0b4 into Expensify:main Dec 8, 2025
30 of 35 checks passed

github-actions bot mentioned this pull request Dec 8, 2025

Investigate workflow job failing on main: test / test (job 8) #76973

Closed

lakchote mentioned this pull request Dec 8, 2025

fix path for test #76974

Merged

58 tasks

lakchote mentioned this pull request Dec 8, 2025

Revert "Avatar doesn't load when login from public room as existing user" #77031

Merged

OSBotify mentioned this pull request Dec 9, 2025

Deploy Checklist: New Expensify 2025-12-09 #77123

Closed

melvin-bot bot mentioned this pull request Dec 10, 2025

[Due for payment 2025-12-17] [$250] Account - Avatar doesn't load when login from public room as existing user #74176

Closed

8 tasks

Conversation

lorretheboy commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Nov 11, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lorretheboy Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lakchote Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

lakchote Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Nov 12, 2025

Uh oh!

github-actions bot Nov 12, 2025

Choose a reason for hiding this comment

❌ PERF-6 (docs)

Uh oh!

shubham1206agra Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

lorretheboy Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lakchote commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Dec 9, 2025

Uh oh!

IuliiaHerets commented Dec 9, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lorretheboy commented Nov 11, 2025 •

edited

Loading

codecov bot commented Nov 11, 2025 •

edited by github-actions bot

Loading

lorretheboy Nov 12, 2025 •

edited

Loading

shubham1206agra commented Dec 6, 2025 •

edited

Loading

lakchote commented Dec 8, 2025 •

edited

Loading