Fix cursor not moving to the end of mention when using mention suggestions. by LorenzoBloedow · Pull Request #74886 · Expensify/App

LorenzoBloedow · 2025-11-11T22:41:50Z

Explanation of Change

We're imperatively setting the cursor position to the end of the suggestion (when the user selects one) because we previously didn't have any logic for handling this so the cursor would just stay in the same position.

Fixed Issues

$ #61944

Tests

Test 1:

Send a message in the composer.
Start typing another message right after.
Verify the message didn't get cleared.

Test 2:

Start typing a message in the composer.
Mention someone but don't send the message.
Continue typing.
Verify the text didn't disappear.

Test 3:

Select an emoji from the composer suggestion box.
Type anything else right after.
Verify the text didn't get cleared.

Test 4:

Mention someone in the composer.
Put the cursor in the middle of the mention.
Select another user.
Verify the cursor moved to the end of the suggestion.

Offline tests

Same as tests.

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android.-.Native.mov

Android: mWeb Chrome

Android.-.Chrome.mov

iOS: Native

iOS.-.Native.mov

iOS: mWeb Safari

iOS.-.Safari.mov

MacOS: Chrome / Safari

macOS.-.Safari.mov

MacOS: Desktop

macOS.-.Desktop.mov

melvin-bot · 2025-11-11T22:41:56Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-11-11T22:54:33Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...omposerWithSuggestions/ComposerWithSuggestions.tsx	`58.08% <14.28%> (-1.04%)`	⬇️
... and 13 files with indirect coverage changes

situchan · 2025-11-11T23:10:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

situchan

Looks good other than failing checks

situchan

Please add some context in Explanation of Change.

Why debounce saveComment on onClear
Why debounce updateComment on onChangeText

LorenzoBloedow · 2025-11-12T00:19:26Z

@situchan I don't know the specific reason, we're just reverting to how it was months ago while maintaining some of the changes of my original PR. We should probably ask the person who used the debounces before all the regressions.

I can try to investigate tomorrow if needed though.

joekaufmanexpensify

Good from a product perspective 👍

situchan

Please add explanation of new code changes. Looks like much different from initial proposal.

src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

situchan · 2025-11-13T11:40:45Z

src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

+        }
+
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
+        InteractionManager.runAfterInteractions(() => {


Please move comment from old code.

We need that comment so the ESLint doesn't trigger an error, it's used throughout the codebase as well, as far as I'm aware, we're currently not moving away from runAfterInteractions even though it's deprecated.

I meant to keep

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Line 535 in c64401f

// ensure that selection is set imperatively after all state changes are effective

And also keep this comment:

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 538 to 539 in c64401f

// note: this implementation is only available on non-web RN, thus the wrapping

// 'if' block contains a redundant (since the ref is only used on iOS) platform check

I just added the old comments but changed some parts since the part about only being used on iOS is outdated (we're also imperatively setting the selection on Android).

LorenzoBloedow · 2025-11-13T17:46:58Z

@situchan The explanation is in the main issue comment:

We're imperatively setting the cursor position to the end of the suggestion (when the user selects one) because we previously didn't have any logic for handling this so the cursor would just stay in the same position.

We're also removing the old behavior of imperatively setting the text selection after all interactions on iOS because it doesn't seem to have any effect anymore.

But basically we're just imperatively setting the cursor position to the end of the current mention (e.g.: @LorenzoBloedow) when the user selects it from the composer suggestion box. We need to do this because the suggestions box is inserting the text into the composer all at once (as it's supposed to, because it's a shortcut), so we need to "sync" the cursor position.

situchan · 2025-11-16T06:20:24Z

src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

-        (commentValue: string) => {
-            updateComment(commentValue, true);
-
-            if (isIOSNative && syncSelectionWithOnChangeTextRef.current) {


Did you test original bug - #29405 by removing iOS specific code?
It's still reproducible.

Screen.Recording.2025-11-16.at.12.18.52.PM.mov

I completely missed that, sorry.

Updated the code to basically just implement the core fix of overwriting the cursor position when a suggestion is selected and keep the rest. Also updated the screen recordings for the tests showing that it works and that the bug you reported above^ is not reproducible anymore.

Just one question: Is it expected for the cursor to behave like your video in native Android? I found it currently moves to the end in all platforms except the Android app. And this happens even in main as shown below:

Screen.Recording.2025-11-16.at.8.11.28.AM.mov

That can be out of scope as it's not caused by this PR

LorenzoBloedow · 2025-11-16T11:50:35Z

Had some problems with my GPG key, thus the failing check. I can rebase and force push with all the commits signed if this is a blocker.

situchan · 2025-11-16T14:14:20Z

Had some problems with my GPG key, thus the failing check. I can rebase and force push with all the commits signed if this is a blocker.

yes it's blocker. All commits should have verified signature.

situchan · 2025-11-16T17:34:03Z

src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

+        }
+
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
+        InteractionManager.runAfterInteractions(() => {


We're deprecating InteractionManager.runAfterInteractions. Please try to find another solution.

I ended up using queueMicrotask because it seems to be the most appropriate since we're dealing with the cursor position which is lightweight and should probably happen before the next render.

This reverts commit 0d94f72.

This reverts commit 622a99f.

chiragsalian · 2025-11-26T23:53:04Z

Whats the latest here @LorenzoBloedow, is it ready for review?

situchan · 2025-11-27T02:59:26Z

Please merge main and fix failing perf-tests

LorenzoBloedow · 2025-11-27T15:50:24Z

@situchan Merged main and I think the reason the perf tests were failing is unrelated to this PR (or transient). I ran the tests locally multiple times and they passed, and now they're passing here too. Might be worth it to run them again though just to be sure.

situchan · 2025-11-28T16:06:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

chiragsalian

LGTM. Thank you for staying on top of this and pushing it through.

OSBotify · 2025-12-01T23:42:41Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.2.67-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-03T13:55:20Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-03T14:50:47Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

LorenzoBloedow requested review from a team as code owners November 11, 2025 22:41

melvin-bot bot requested review from thesahindia and removed request for a team November 11, 2025 22:41

melvin-bot bot assigned LorenzoBloedow Nov 11, 2025

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team November 11, 2025 22:41

chiragsalian requested review from chiragsalian and situchan and removed request for thesahindia November 11, 2025 22:48

chiragsalian mentioned this pull request Nov 11, 2025

Compose Box - Character removed from compose box after selecting emoji #74844

Closed

16 tasks

situchan approved these changes Nov 11, 2025

View reviewed changes

situchan reviewed Nov 11, 2025

View reviewed changes

joekaufmanexpensify previously approved these changes Nov 12, 2025

View reviewed changes

LorenzoBloedow dismissed joekaufmanexpensify’s stale review via 0d94f72 November 12, 2025 19:57

situchan suggested changes Nov 13, 2025

View reviewed changes

LorenzoBloedow requested a review from situchan November 13, 2025 20:02

situchan suggested changes Nov 16, 2025

View reviewed changes

situchan reviewed Nov 16, 2025

View reviewed changes

LorenzoBloedow added 2 commits November 16, 2025 15:19

Revert to old updateComment timing behavior

be2dff6

Fix cursor not moving to the end of selected suggestion

e43aa5f

LorenzoBloedow added 6 commits November 16, 2025 15:19

Add old comments back and drop typeof when checking for undefined

ff4bbb2

Revert "Fix cursor not moving to the end of selected suggestion"

107eff5

This reverts commit 0d94f72.

Revert "Revert to old updateComment timing behavior"

014a95e

This reverts commit 622a99f.

Fix cursor not moving to the end of selected suggestion/mention

7386914

Change comment

d97973b

use queueMicrotask instead of deprecated runAfterInteractions

47eaca6

LorenzoBloedow force-pushed the chat-regression-fix-2 branch from eddded5 to 47eaca6 Compare November 16, 2025 18:23

LorenzoBloedow requested a review from situchan November 16, 2025 19:06

LorenzoBloedow mentioned this pull request Nov 19, 2025

[Payment due] [$250] Chat - Suggestion list reopens and cursor does not move to end after selecting another user #61944

Closed

8 tasks

LorenzoBloedow changed the title ~~Fix chat race-condition regression~~ Fix cursor not moving to the end of mention when using mention suggestions. Nov 21, 2025

Drop 'typeof' operator when checking for undefined

a9674fc

Merge remote-tracking branch 'upstream/main' into chat-regression-fix-2

3d39595

situchan approved these changes Nov 28, 2025

View reviewed changes

huult mentioned this pull request Nov 29, 2025

[$250] Сhat - Mention suggestion box does not close when selecting mention in previously empty line #76044

Closed

16 tasks

chiragsalian approved these changes Dec 1, 2025

View reviewed changes

chiragsalian merged commit 24ea8b2 into Expensify:main Dec 1, 2025
31 checks passed

OSBotify mentioned this pull request Dec 1, 2025

Deploy Checklist: New Expensify 2025-12-01 #76460

Closed

	// note: this implementation is only available on non-web RN, thus the wrapping
	// 'if' block contains a redundant (since the ref is only used on iOS) platform check

Conversation

LorenzoBloedow commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 11, 2025

Uh oh!

codecov bot commented Nov 11, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

situchan commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

LorenzoBloedow commented Nov 12, 2025

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

situchan Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LorenzoBloedow commented Nov 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LorenzoBloedow commented Nov 16, 2025

Uh oh!

situchan commented Nov 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chiragsalian commented Nov 26, 2025

Uh oh!

situchan commented Nov 27, 2025

Uh oh!

LorenzoBloedow commented Nov 27, 2025

Uh oh!

situchan commented Nov 28, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

chiragsalian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 1, 2025

LorenzoBloedow commented Nov 11, 2025 •

edited

Loading

codecov bot commented Nov 11, 2025 •

edited by github-actions bot

Loading

situchan commented Nov 11, 2025 •

edited

Loading

situchan Nov 13, 2025 •

edited

Loading