Prevent making redundant API call when report is not loaded by MonilBhavsar · Pull Request #74925 · Expensify/App

MonilBhavsar · 2025-11-12T11:05:47Z

Explanation of Change

Let's not mark report as read when the report has not been loaded/shared with user.
The API call fails since the report(transaction thread) is not shared with the user, spamming the logs.

Okay finally able to reproduce. It appears like there is a race condition between ReadNewestAction and OpenReport API calls. The frontend first fires, ReadNewestAction call and since the report is not shared, it errors out.
And is latter shared with user and marked as read during OpenReport and ReadNewestAction command calls

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/557858
PROPOSAL:

Tests

Part 1

As an admin1, create a workspace and invite admin2 and user to the workspace
As an admin1, enable advanced approvals and set admin1 as default approver
As a user create a report in the workspace chat with at least two expense and add some comments in transaction thread on one of the expense
Do not submit it, so report is not shared with anyone
As an admin2, open the network tab and open the expense report and transaction thread with comments
Ensure API calls for that specific report are not in order - ReadNewestAction and then OpenReport, instead its vice versa

Part 2

Test this suite for Unread messages https://test-management.browserstack.com/projects/2219752/folder/13176723/test-cases/41237056

1:1 conversation

Navigate to a 1:1 conversation that has a large history of messages.

Scroll the conversation a little and tap hold/hover over a message from the other user and mark the message as "Unread"

Verify the "New Message" line is displayed above the message that was marked as unread

Desktop/Web - Verify that the new message line doesn't overlap with the action menu

Scroll further up the conversation and verify a "New Messages" button appears

Click/ tap on New Messages button

Verify you are scrolled to the message you marked as unread

Press "Mark as unread" on more recent message in conversation

Open the LHN again on that conversation, press "Mark as read"

Open the conversation

Verify that the green horizontal line indicating an unread message is not present

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-11-12.at.5.32.56.PM.mov

Screen.Recording.2025-11-12.at.5.35.44.PM.mov

MacOS: Desktop

melvin-bot · 2025-11-12T11:05:53Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-11-12T11:23:58Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/home/report/ReportActionsList.tsx	`79.70% <100.00%> (+1.36%)`	⬆️
... and 8 files with indirect coverage changes

MonilBhavsar · 2025-11-14T06:26:38Z

@shubham1206agra would be able to review it today?

shubham1206agra · 2025-11-18T13:37:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2025-11-18.at.7.05.14.PM.mov

melvin-bot · 2025-11-18T13:38:10Z

@justinpersaud Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-11-18T13:38:14Z

🎯 @shubham1206agra, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #75401.

justinpersaud · 2025-11-18T13:51:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2025-11-19T16:36:24Z

🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.2.61-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2025-11-20T09:31:49Z

@MonilBhavsar Is it enough to check Web only? QA team can't check api calls in mWeb and Native apps

MonilBhavsar · 2025-11-20T09:34:54Z

For Part 1, we can only check web. I think we test Part 2 on all platforms

OSBotify · 2025-11-21T12:05:13Z

🚀 Deployed to production by https://github.com/grgia in version: 9.2.61-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…l sites The previous fix (PR #74925) only added the hasOnceLoadedReportActions check to one location in ReportActionsList.tsx. This left 7+ other code paths that could call readNewestAction before the report was shared, causing 401 Unauthorized errors from UpdateRNVPLastReadTime. This commit adds the same guard pattern to all remaining call sites: - ReportActionsList.tsx: handleAppVisibilityMarkAsRead, scrollToBottomAndMarkReportAsRead - MoneyRequestReportActionsList.tsx: all 3 effects/callbacks that call readNewestAction - useReportUnreadMessageScrollTracking.ts: onViewableItemsChanged callback - ReportScreen.tsx: task report useEffect The fix ensures the hooks re-run when hasOnceLoadedReportActions changes from false to true, so reports are correctly marked as read once loaded. Co-authored-by: Monil Bhavsar <MonilBhavsar@users.noreply.github.com>

Prevent marking as read if report is not loaded

d035a84

MonilBhavsar self-assigned this Nov 12, 2025

MonilBhavsar requested review from a team as code owners November 12, 2025 11:05

melvin-bot bot requested a review from shubham1206agra November 12, 2025 11:05

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team November 12, 2025 11:05

Fix lint

56e1b5a

MonilBhavsar changed the title ~~Prevent making redundant API call when report is being loaded~~ Prevent making redundant API call when report is not loaded Nov 12, 2025

Correct the comment

4ead32c

joekaufmanexpensify approved these changes Nov 12, 2025

View reviewed changes

shubham1206agra approved these changes Nov 18, 2025

View reviewed changes

melvin-bot bot requested a review from justinpersaud November 18, 2025 13:38

melvin-bot bot mentioned this pull request Nov 18, 2025

[Due to payment 2025-11-28] Payment issue for E/App PR#74925 #75401

Closed

justinpersaud approved these changes Nov 18, 2025

View reviewed changes

justinpersaud merged commit b06830c into main Nov 18, 2025
31 of 32 checks passed

justinpersaud deleted the monilf-fixRedundantAPICall branch November 18, 2025 13:51

This was referenced Nov 18, 2025

Investigate workflow job failing on main: test / test (job 1) #75413

Closed

Investigate workflow job failing on main: test / test (job 1) #75417

Closed

OSBotify mentioned this pull request Nov 19, 2025

Deploy Checklist: New Expensify 2025-11-19 #75561

Closed

57 tasks

jponikarchuk mentioned this pull request Nov 19, 2025

[Due for payment 2025-11-28] [RCA #74646] Expense - Expense report does not load when opening report after creating expense #75565

Closed

8 tasks

iwiznia mentioned this pull request Nov 19, 2025

Revert "Prevent making redundant API call when report is not loaded" #75585

Closed

nlemma mentioned this pull request Nov 20, 2025

New message line overlap with the action menu #75651

Closed

8 tasks

MelvinBot mentioned this pull request Feb 5, 2026

Fix: Add hasOnceLoadedReportActions guard to all readNewestAction call sites #81462

Merged

53 tasks

FitseTLT mentioned this pull request Mar 6, 2026

[$250] Chat - Chat from new user does not become un-bold in offline mode #83745

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent making redundant API call when report is not loaded#74925

Prevent making redundant API call when report is not loaded#74925
justinpersaud merged 3 commits intomainfrom
monilf-fixRedundantAPICall

MonilBhavsar commented Nov 12, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Nov 12, 2025

Uh oh!

codecov bot commented Nov 12, 2025 •

edited by github-actions bot

Loading

Uh oh!

MonilBhavsar commented Nov 14, 2025

Uh oh!

shubham1206agra commented Nov 18, 2025

Uh oh!

melvin-bot bot commented Nov 18, 2025

Uh oh!

melvin-bot bot commented Nov 18, 2025

Uh oh!

justinpersaud commented Nov 18, 2025

Uh oh!

Uh oh!

OSBotify commented Nov 19, 2025

Uh oh!

IuliiaHerets commented Nov 20, 2025

Uh oh!

MonilBhavsar commented Nov 20, 2025

Uh oh!

OSBotify commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

MonilBhavsar commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Part 1

Part 2

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 12, 2025

Uh oh!

codecov bot commented Nov 12, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MonilBhavsar commented Nov 14, 2025

Uh oh!

shubham1206agra commented Nov 18, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 18, 2025

Uh oh!

melvin-bot bot commented Nov 18, 2025

Uh oh!

justinpersaud commented Nov 18, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Nov 19, 2025

Uh oh!

IuliiaHerets commented Nov 20, 2025

Uh oh!

MonilBhavsar commented Nov 20, 2025

Uh oh!

OSBotify commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MonilBhavsar commented Nov 12, 2025 •

edited

Loading

codecov bot commented Nov 12, 2025 •

edited by github-actions bot

Loading