Make NewChatConfirmPage use new SelectionList#74982
Merged
grgia merged 8 commits intoExpensify:mainfrom Nov 20, 2025
Merged
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
war-in
reviewed
Nov 18, 2025
war-in
reviewed
Nov 18, 2025
| const isItemDisabled = isDisabled || (!!item?.isDisabled && !isItemSelected(item)); | ||
|
|
||
| if (isItemSelected(item)) { | ||
| if (isItemSelected(item) && (canSelectMultiple || acc.selectedOptions.length === 0)) { |
Contributor
There was a problem hiding this comment.
Ok, so if we pass data with multiple selected items (and no canSelectMultiple), we'll end up with the first of them selected, right?
If so it might be worth mentioning somewhere 🤔
Contributor
Author
There was a problem hiding this comment.
Tbh this situation is really unlikely to happen, because the ListItem blocks from choosing more, it's just an extra safety check, so I could even delete it
war-in
approved these changes
Nov 18, 2025
melvin-bot
bot
requested review from
dukenv0307
and removed request for
a team
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
bot
requested review from
heyjennahay
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| onConfirm={createGroup} | ||
| shouldHideListOnInitialRender={false} | ||
| canSelectMultiple | ||
| confirmButtonOptions={{ |
Contributor
There was a problem hiding this comment.
❌ PERF-4 (docs)
Objects passed as props should be memoized to prevent unnecessary re-renders. Creating a new object literal on every render causes React to treat the prop as changed even when the actual data hasn't changed.
Suggested fix:
const confirmButtonOptions = useMemo(() => ({
showButton: !!selectedOptions.length,
text: translate('newChatPage.startGroup'),
onConfirm: createGroup,
}), [selectedOptions.length, translate, createGroup]);
// Then pass it to SelectionList:
<SelectionList
confirmButtonOptions={confirmButtonOptions}
// ... other props
/>
| text: translate('newChatPage.startGroup'), | ||
| onConfirm: createGroup, | ||
| }} | ||
| customListHeader={ |
Contributor
There was a problem hiding this comment.
❌ PERF-4 (docs)
JSX elements passed as props should be memoized to prevent unnecessary re-renders. Creating new JSX elements and style arrays on every render causes React to treat the prop as changed.
Suggested fix:
const customListHeader = useMemo(
() => (
<View style={[styles.mt8, styles.mb4, styles.justifyContentCenter]}>
<Text style={[styles.ph5, styles.textLabelSupporting]}>{translate('common.members')}</Text>
</View>
),
[styles, translate],
);
// Then pass it to SelectionList:
<SelectionList
customListHeader={customListHeader}
// ... other props
/>
Contributor
|
No product change, removing myself and unsubscribing |
dukenv0307
reviewed
Nov 19, 2025
| onSelectAll: () => void; | ||
|
|
||
| /** Whether to show 'Select all' button */ | ||
| shouldShowSelectAllButton: boolean; |
Contributor
There was a problem hiding this comment.
Why don't we use onSelectAll to decide to show the select all button?
Contributor
Author
There was a problem hiding this comment.
Take a look below what is passed in the BaseSelectionList. Because of that we can't base the button on onSelectAll cause it is always present. This is related also to your second question :)
const handleSelectAll = useCallback(() => {
onSelectAll?.();
if (shouldShowTextInput && shouldPreventDefaultFocusOnSelectRow && innerTextInputRef.current) {
innerTextInputRef.current.focus();
}
}, [onSelectAll, shouldShowTextInput, shouldPreventDefaultFocusOnSelectRow]);
...
<ListHeader
dataDetails={dataDetails}
aboveListHeaderMessage={textInputOptions?.headerMessage}
customListHeader={customListHeader}
canSelectMultiple={canSelectMultiple}
onSelectAll={handleSelectAll}
dukenv0307
reviewed
Nov 19, 2025
|
|
||
| /** Function called when the select all button is pressed */ | ||
| onSelectAll?: () => void; | ||
| onSelectAll: () => void; |
Contributor
There was a problem hiding this comment.
I think it should be optional. Pls correct me if I'm wrong
grgia
approved these changes
Nov 19, 2025
Contributor
|
@zfurtak Can you please merge main? I think the failed tests are not related to our PR |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-19.at.23.34.03.movAndroid: mWeb ChromeScreen.Recording.2025-11-19.at.23.31.51.moviOS: HybridAppScreen.Recording.2025-11-19.at.23.34.38.moviOS: mWeb SafariScreen.Recording.2025-11-19.at.23.31.22.movMacOS: Chrome / SafariScreen.Recording.2025-11-19.at.23.30.07.movMacOS: DesktopScreen.Recording.2025-11-19.at.23.35.04.mov |
dukenv0307
approved these changes
Nov 19, 2025
grgia
approved these changes
Nov 20, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.2.62-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.62-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #72970
PROPOSAL:
Tests
Start chatNextOffline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
iOS: Native
ios.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov
MacOS: Desktop