Skip to content

Add validate code extended access for issuing cards#75096

Merged
NikkiWines merged 24 commits intomainfrom
nikki-validate-code-extended-access-app
Jan 19, 2026
Merged

Add validate code extended access for issuing cards#75096
NikkiWines merged 24 commits intomainfrom
nikki-validate-code-extended-access-app

Conversation

@NikkiWines
Copy link
Contributor

@NikkiWines NikkiWines commented Nov 13, 2025

Explanation of Change

Updates the virtual card and physical card so that we conditionally require a validateCode - we want one the first time they assign a card and then not again until the timeout has expired.

Held on PR: https://github.com/Expensify/Auth/pull/18885

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/543813
PROPOSAL: N/A internal

Tests

  1. Log into an account that is an admin of a domain with Expensify Cards enabled
  2. Navigate to Workspaces > Your Workspace > Expensify Cards
  3. Click "+ Issue Card"
  4. Fill out the form to issue a virtual or physical card
  5. Enter the magic code sent to your login and click Verify
  6. Confirm the card is issued successfully
  7. Click "+ Issue Card" again
  8. Fill out the form to issue a card of the other type and click submit
  9. Confirm you don't see the form for entering for a magic code
  10. Confirm the card is issued successfully
  11. Click "+ Isssue Card again
  12. Fill out the form to issue a card of the first type that you issued and click submit
  13. Confirm you don't see the form for entering for a magic code
  14. Confirm the card is issued successfully
  15. Wait 11 minutes
  16. Click + Issue Card again
  17. Fill out the form for either type of card and click submit
  18. Confirm a form for the magic code is surfaced you see a message that a code has been sent to you
  19. Enter the code and click submit
  20. Confirm the card is issued successfully
  • Verify that no errors appear in the JS console

Offline tests

N/A cards cannot be issued offline

QA Steps

Same as test steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-12-19.at.16.29.51.mov
MacOS: Chrome / Safari

https://github.com/user-attachments/assets/62486d57-2273-4629-9f04-21770b022c69)

MacOS: Desktop
Screen.Recording.2025-12-15.at.16.31.32.mov
Screen.Recording.2025-12-15.at.16.06.45.mov

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 83.76% <ø> (ø)
src/libs/AccountUtils.ts 69.23% <100.00%> (+35.89%) ⬆️
src/libs/actions/Card.ts 0.00% <ø> (ø)
...kspace/expensifyCard/issueNew/IssueNewCardPage.tsx 0.00% <0.00%> (ø)
...kspace/expensifyCard/issueNew/ConfirmationStep.tsx 0.00% <0.00%> (ø)
... and 8 files with indirect coverage changes

@NikkiWines NikkiWines changed the title Add validate code extended access for issuing cards [HOLD Auth 18395 & Web 49843] Add validate code extended access for issuing cards Dec 15, 2025
@NikkiWines NikkiWines changed the title [HOLD Auth 18395 & Web 49843] Add validate code extended access for issuing cards [HOLD Web 49843] Add validate code extended access for issuing cards Dec 18, 2025
@NikkiWines NikkiWines changed the title [HOLD Web 49843] Add validate code extended access for issuing cards [HOLD Auth 18885] Add validate code extended access for issuing cards Dec 19, 2025
@danielrvidal
Copy link
Contributor

Nice, I think the Auth PR just got merged so we can unhold this!

@NikkiWines
Copy link
Contributor Author

Yep, though we'll need the auth PR to be deployed for this to be mergable - that should happen tomorrow as we've already had an auth deploy today 🙇

@NikkiWines NikkiWines changed the title [HOLD Auth 18885] Add validate code extended access for issuing cards Add validate code extended access for issuing cards Dec 22, 2025
@NikkiWines NikkiWines marked this pull request as ready for review December 22, 2025 18:07
@NikkiWines NikkiWines requested review from a team as code owners December 22, 2025 18:07
@melvin-bot melvin-bot bot requested a review from brunovjk December 22, 2025 18:07
@melvin-bot
Copy link

melvin-bot bot commented Dec 22, 2025

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from heyjennahay and removed request for a team December 22, 2025 18:07
@NikkiWines
Copy link
Contributor Author

Backend PR has been merged, and should be live on Monday 🍀

@brunovjk
Copy link
Contributor

@NikkiWines, we're getting an error when confirming card creation after the second attempt:

Screen.Recording.2026-01-12.at.16.08.08.mov

The server's response to the command CreateAdminIssuedVirtualCard is message : "500 Marqeta error (httpResponseCode: 400, errorCode: 400071, errorMessage: Uses parent account cannot be set to true without setting a parent card holder)". Can you reproduce it? Thank you.

@NikkiWines
Copy link
Contributor Author

Yes, I can repro this locally. I'm almost positive this is because we're using the staging server for Marqeta for dev requests and so the cards won't be provisioned correctly, but cc: @MariaHCD since you have knowledge of that logic 🙇

@MariaHCD
Copy link
Contributor

@NikkiWines yes, I got the bugbot issue too: https://github.com/Expensify/Expensify/issues/584462#issuecomment-3742204419

@brunovjk We recently made some internal changes to route test domains/workspaces to the Marqeta sandbox.

I believe the workspace you are testing with was originally provisioned on Marqeta production, so now that test workspaces use the sandbox, card-related requests for it won’t work (since the workspace and associated records don’t exist in sandbox).

I would recommend creating a fresh test workspace:

  • Provision it for Expensify Cards using the test Plaid bank account
  • Then try issuing cards from there

Let me know if you run into any issues with the new setup!

@NikkiWines
Copy link
Contributor Author

thanks @MariaHCD 🙇

@brunovjk would be able to review again today following the steps @MariaHCD provided by any chance? Thank you!

@brunovjk
Copy link
Contributor

@NikkiWines Yes, yesterday I had some problems creating a new account and adding the test bank account. I'll get back here in a moment, sorry for the delay.

@NikkiWines
Copy link
Contributor Author

No worries, thank you!! 🙌

@brunovjk
Copy link
Contributor

brunovjk commented Jan 14, 2026

@NikkiWines I got stuck on other issues today, I'll come back here first thing tomorrow. If it's urgent let me know and I'll find another one to review. Thank you

Im on it now

@brunovjk
Copy link
Contributor

@NikkiWines and @MariaHCD, I'm trying to connect a bank account to a new account. I'm doing what I always do, but I'm stuck on the "Onfido" verification. Am I doing something wrong?

Screen.Recording.2026-01-15.at.10.56.28.mov

Thank you very much.

@NikkiWines
Copy link
Contributor Author

Hmm, @brunovjk I get the same thing from the Workspaces flow so I'm not sure. However, if you go to Expensify Classic for the same account and go to Settings > Workspaces > Your Workspace > Workflows > Make or track payments > and then select "Direct" and try to add a bank account from there using the same credentials and dummy data for the extra values it asks for (they aren't relevant) it might work? It worked for me at least 😅

@MariaHCD
Copy link
Contributor

@brunovjk the date of birth should be set as 2000-08-08 to correctly skip the Onfido check. The rest of your test data looks correct 👍🏼

Screen.Recording.2026-01-16.at.12.29.24.PM.mov

(internal link to relevant code: here)

@brunovjk
Copy link
Contributor

brunovjk commented Jan 16, 2026

It worked well, thank you very much, I will continue testing the PR.
Screenshot 2026-01-16 at 08 09 07

Copy link
Contributor

@brunovjk brunovjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works well.

NAB: @NikkiWines do you think it's worth removing the hardcoded numbers (convert timestamp from microseconds to milliseconds and 1 hour in microseconds) and using some CONST? Thank you.

@melvin-bot melvin-bot bot requested a review from carlosmiceli January 16, 2026 14:09
@melvin-bot
Copy link

melvin-bot bot commented Jan 16, 2026

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
Copy link

melvin-bot bot commented Jan 16, 2026

🎯 @brunovjk, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #79763.

@NikkiWines
Copy link
Contributor Author

Thanks for your perserverence with reviewing + testing @brunovjk 🙇

do you think it's worth removing the hardcoded numbers (convert timestamp from microseconds to milliseconds and 1 hour in microseconds) and using some CONST? Thank you.

I thought about this, but since the microseconds -> milliseconds only used in the one location I thought it was fine to keep inline.

For the 1 hour bit, it's only used in the test so I don't feel strongly about it

Copy link
Contributor

@carlosmiceli carlosmiceli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you wanna review it too @NikkiWines ?

Update: so dumb, this is your PR.

@carlosmiceli
Copy link
Contributor

All yours @heyjennahay

Copy link
Contributor

@heyjennahay heyjennahay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product change LGTM

@NikkiWines
Copy link
Contributor Author

yay, thanks everyone 🙌

@NikkiWines NikkiWines merged commit 33ede95 into main Jan 19, 2026
36 checks passed
@NikkiWines NikkiWines deleted the nikki-validate-code-extended-access-app branch January 19, 2026 11:04
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.3.5-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants