Conversation
Add descriptions for GPS tracking as per #74993
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @sakluger |
HelpDot Documentation ReviewOverall AssessmentThis PR updates the GPS mileage tracking documentation to reflect that the feature is now available on mobile. The changes are focused and accurate, updating both the step-by-step instructions and the feature availability table. The documentation maintains consistency with the existing content style and structure. Scores Summary
Key FindingsStrengths:
Areas for Improvement:
Recommendations
Files Reviewed
Overall Score: 8/10This is a solid documentation update that accurately reflects a new feature. The changes are clear, consistent, and ready for merge. The suggestions above are minor enhancements that could improve user experience but are not blockers. Review completed by HelpDot Documentation Quality Specialist |
| 2. Under **Distance**, select: | ||
| - **Manually create** – enter miles and rate. Tap **More options** for category, description, report. | ||
| - **Odometer** – enter pre/post trip readings and rate. Tap **More options** to complete. | ||
| - **Start GPS** – Click **Start** at the start of your trip, and click **Stop** when you reach your destination. For best results, keep the Expensify app open. |
There was a problem hiding this comment.
Button label inconsistency: The text uses both "Click Start" and "click Stop" with inconsistent capitalization. Per Expensify style guidelines, button actions should be consistently capitalized. Recommend: "Tap Start" and "tap Stop" to match the mobile context (this section is under "On Mobile").
There was a problem hiding this comment.
@kadiealexander I agree with this recommendation.
| - **Manually create** – enter miles and rate. | ||
| - **Odometer** – log before/after readings. | ||
| - **Start GPS** – currently unavailable. | ||
| - **Start GPS** – automatically calculates your mileage amount using GPS while you travel. |
There was a problem hiding this comment.
Readability improvement: The phrase "automatically calculates your mileage amount using GPS while you travel" is somewhat verbose. Consider simplifying to: "automatically tracks your mileage using GPS" for better scannability and clarity.
There was a problem hiding this comment.
@kadiealexander I agree with this recommendation.
|
A preview of your ExpensifyHelp changes have been deployed to https://f8e66302.helpdot.pages.dev ⚡️ Updated articles: |
|
Hey @kadiealexander, could you please address the github-actions recommendations? Othrewise, this looks great 👍 |
|
Updated! |
|
@sakluger looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
This is just a text update on a help doc, we didn't need all the checks to pass. |
|
🚀 Deployed to staging by https://github.com/sakluger in version: 9.2.62-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.62-5 🚀
|
Add descriptions for GPS tracking as per #74993
Explanation of Change
Add explanation of GPS mileage tracking.
Fixed Issues
$ #74993
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop