Skip to content

fix: BillingBanner subtitle to only render when available #75229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewGable merged 2 commits into from
Nov 19, 2025
Merged

fix: BillingBanner subtitle to only render when available #75229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8458a08
fix: BillingBanner subtitle to only show when available
samranahm Nov 15, 2025
83de27b
fix: lint expensifyIcons import
samranahm Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/pages/settings/Subscription/CardSection/BillingBanner/BillingBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
import {View} from 'react-native';
import type {ValueOf} from 'type-fest';
import Icon from '@components/Icon';
import * as Expensicons from '@components/Icon/Expensicons';
import {PressableWithoutFeedback} from '@components/Pressable';
import Text from '@components/Text';
import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
Expand Down Expand Up @@ -64,6 +64,7 @@
const styles = useThemeStyles();
const theme = useTheme();
const {shouldUseNarrowLayout} = useResponsiveLayout();
const expensifyIcons = useMemoizedLazyExpensifyIcons(['DotIndicator'] as const);

const rightIconComponent = useMemo(() => {
if (rightIcon) {
Expand All @@ -90,12 +91,12 @@
return (
!!brickRoadIndicator && (
<Icon
src={Expensicons.DotIndicator}
src={expensifyIcons.DotIndicator}
fill={brickRoadIndicator === CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR ? theme.danger : theme.success}
/>
)
);
}, [brickRoadIndicator, onRightIconPress, rightIcon, rightIconAccessibilityLabel, styles.touchableButtonImage, theme.danger, theme.icon, theme.success]);

Check warning on line 99 in src/pages/settings/Subscription/CardSection/BillingBanner/BillingBanner.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

React Hook useMemo has a missing dependency: 'expensifyIcons.DotIndicator'. Either include it or remove the dependency array

return (
<View style={[styles.pv4, styles.ph5, styles.flexRow, styles.flexWrap, styles.gap3, styles.w100, styles.alignItemsCenter, styles.trialBannerBackgroundColor, style]}>
Expand All @@ -107,7 +108,7 @@

<View style={[styles.flex1, styles.justifyContentCenter]}>
{typeof title === 'string' ? <Text style={[styles.textStrong, titleStyle]}>{title}</Text> : title}
{typeof subtitle === 'string' ? <Text style={subtitleStyle}>{subtitle}</Text> : subtitle}
{!!subtitle && (typeof subtitle === 'string' ? <Text style={subtitleStyle}>{subtitle}</Text> : subtitle)}
</View>
{shouldUseNarrowLayout ? (
<>
Expand Down
Loading