Use lazy loading for company cards by ShridharGoel · Pull Request #75279 · Expensify/App

ShridharGoel · 2025-11-17T08:31:50Z

Explanation of Change

Use lazy loading for company cards

List of migrated assets:

AmexCardCompanyCardDetail
BankOfAmericaCompanyCardDetail
BrexCompanyCardDetail
CapitalOneCompanyCardDetail
ChaseCompanyCardDetail
CitibankCompanyCardDetail
MasterCardCompanyCardDetail
PlaidCompanyCardDetail
StripeCompanyCardDetail
VisaCompanyCardDetail
WellsFargoCompanyCardDetail
Large versions of all the above cards
PendingBank
CompanyCardsPendingState

Fixed Issues

$ #75247
PROPOSAL: #75247 (comment)

Tests

Open Workspace > Cards > Company cards; confirm each card feed in the list shows the correct bank logo.
On the “Add new” flow (Select bank step), verify every bank option renders its logo properly.
In “Assign card” (selecting cards from a feed), ensure the feed icon renders for each card row and the search results still show the right logos.
In Workspace member details, check the assigned card tiles show the correct bank icon and badge.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-11-17T08:31:57Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-11-17T08:43:39Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Icon/chunks/illustrations.chunk.ts	`0.00% <ø> (ø)`
...ponents/ReportActionAvatars/ReportActionAvatar.tsx	`85.57% <ø> (ø)`
src/libs/CardFeedUtils.ts	`89.32% <100.00%> (ø)`
src/libs/CardUtils.ts	`68.75% <100.00%> (+0.17%)`	⬆️
...e/companyCards/WorkspaceCompanyCardDetailsPage.tsx	`0.00% <ø> (ø)`
...panyCards/WorkspaceCompanyCardFeedSelectorPage.tsx	`0.00% <ø> (ø)`
...s/workspace/companyCards/addNew/SelectBankStep.tsx	`0.00% <ø> (ø)`
...pace/companyCards/assignCard/CardSelectionStep.tsx	`3.33% <ø> (ø)`
...s/workspace/members/WorkspaceMemberNewCardPage.tsx	`0.00% <ø> (ø)`
src/components/PlaidCardFeedIcon.tsx	`0.00% <0.00%> (ø)`
... and 6 more
... and 11 files with indirect coverage changes

brunovjk · 2025-11-17T12:21:33Z

@ShridharGoel Could you take a look at the errors here? Thank you.

ShridharGoel · 2025-11-17T17:37:14Z

@brunovjk Updated.

brunovjk · 2025-11-17T22:21:17Z

Great! Reviewing ASAP.

mollfpr · 2025-11-18T02:58:25Z

@ShridharGoel Could you resolve the conflict? Thank you!

ShridharGoel · 2025-11-18T04:11:54Z

Updated.

brunovjk · 2025-11-18T11:56:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

75279_android_nattivv.mov

Android: mWeb Chrome

75279_android_web.mov

iOS: HybridApp

75279_ios_web.mov

iOS: mWeb Safari

75279_ios_web.mov

MacOS: Chrome / Safari

75279_web_chrome.mov

brunovjk · 2025-11-18T13:06:03Z

src/hooks/useCompanyCardIcons.ts

+import {COMPANY_CARD_BANK_ICON_NAMES, COMPANY_CARD_FEED_ICON_NAMES} from '@libs/CardUtils';
+import {useMemoizedLazyIllustrations} from './useLazyAsset';
+
+function useCompanyCardFeedIcons() {


@ShridharGoel should we add explicit return types? Thanks.

brunovjk · 2025-11-18T13:06:56Z

We have some falling checks here @ShridharGoel, could you fix them for us? Thank you.

ShridharGoel · 2025-11-18T20:18:24Z

@brunovjk Updated.

brunovjk · 2025-11-19T12:09:14Z

Reviewing ASAP

JmillsExpensify

No review required from a product perspective. Unsubscribing.

mollfpr · 2025-11-20T04:54:27Z

@ShridharGoel Could you resolve the conflict? Thank you!

brunovjk · 2025-11-20T11:45:11Z

I'll review it now, @ShridharGoel, we still have some conflicts. Thank you.

ShridharGoel · 2025-11-20T13:48:56Z

@brunovjk Actually this keeps getting conflicts because it seems these files are being frequently changed. I'll update to fix them.

ShridharGoel · 2025-11-20T15:20:23Z

@brunovjk Updated.

brunovjk · 2025-11-25T11:40:13Z

Sorry for the delay @ShridharGoel, I've been busy. I'll review it here today. Could you resolve the conflicts? Thank you very much.

ShridharGoel · 2025-11-26T04:45:37Z

@brunovjk Updated

brunovjk · 2025-11-26T16:36:08Z

@ShridharGoel Do we need to provide steps to test this PR? I tested the app's overall functionality and it seems fine.

ShridharGoel · 2025-11-26T17:12:55Z

We just need to check that the various icons are being rendered properly. Is it fine to mention it as NoQA ?

brunovjk · 2025-11-26T19:42:14Z

Good question. @mollfpr can you help us confirm if we need QA here? Thank you.

mollfpr · 2025-12-02T02:09:29Z

Let's not add NoQA here since it only focuses on the company card assets, and list out the assets that migrated so the QA team will be aware of the migrated assets.

brunovjk · 2025-12-02T13:23:11Z

Great, thanks for the clarification.

@ShridharGoel please update the PR and the Test Steps accordingly. Let me know if you need anything. Thanks.

ShridharGoel · 2025-12-02T13:59:05Z

Updated

brunovjk

LGTM

brunovjk · 2025-12-02T15:33:47Z

@mollfpr do you think the "Test Steps" here are sufficient? Thank you.

cc: @ShridharGoel

mollfpr · 2025-12-06T15:05:20Z

@ShridharGoel, could you give a few example steps to verify the asset?

ShridharGoel · 2025-12-06T19:26:50Z

Added

OSBotify · 2025-12-10T22:05:14Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-10T23:58:28Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-12T19:00:21Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.2.77-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-12T22:05:35Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Use lazy loading for company cards

fa52416

ShridharGoel requested review from a team as code owners November 17, 2025 08:31

melvin-bot bot assigned ShridharGoel Nov 17, 2025

melvin-bot bot requested review from JmillsExpensify and brunovjk November 17, 2025 08:31

melvin-bot bot removed request for a team November 17, 2025 08:31

ShridharGoel added 2 commits November 17, 2025 21:19

Lint, type and prettier fixes

b19df3d

Lint, type and prettier fixes

2d94a68

Merge main

52c60b7

brunovjk reviewed Nov 18, 2025

View reviewed changes

Updates

5eae4ee

JmillsExpensify reviewed Nov 19, 2025

View reviewed changes

ShridharGoel added 2 commits November 20, 2025 11:34

Merge branch 'main' of https://github.com/Expensify/App into lazyLoad

8b7c01c

Fixes

086abce

ShridharGoel added 3 commits November 20, 2025 19:23

Merge branch 'main' into lazyLoad

a04696c

Fixes

671708c

Merge branch 'main' of https://github.com/Expensify/App into lazyLoad

418c822

ShridharGoel added 2 commits November 26, 2025 10:04

Merge main

e369211

Update

13ca94a

ShridharGoel changed the title ~~[NoQA] Use lazy loading for company cards~~ Use lazy loading for company cards Dec 2, 2025

Merge branch 'main' into lazyLoad

7f48de7

brunovjk approved these changes Dec 2, 2025

View reviewed changes

melvin-bot bot requested a review from mollfpr December 2, 2025 15:32

mollfpr approved these changes Dec 9, 2025

View reviewed changes

mollfpr merged commit 6016c0b into Expensify:main Dec 10, 2025
32 checks passed

OSBotify mentioned this pull request Dec 10, 2025

Deploy Checklist: New Expensify 2025-12-10 #77285

Closed

94 tasks

melvin-bot bot mentioned this pull request Dec 12, 2025

[Due for payment 2025-12-19] [$125] Migrate company cards illustrations to lazy loading #75247

Closed

Conversation

ShridharGoel commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 17, 2025

Uh oh!

codecov bot commented Nov 17, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

brunovjk commented Nov 17, 2025

Uh oh!

ShridharGoel commented Nov 17, 2025

Uh oh!

brunovjk commented Nov 17, 2025

Uh oh!

mollfpr commented Nov 18, 2025

Uh oh!

ShridharGoel commented Nov 18, 2025

Uh oh!

brunovjk commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

brunovjk commented Nov 18, 2025

Uh oh!

ShridharGoel commented Nov 18, 2025

Uh oh!

brunovjk commented Nov 19, 2025

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr commented Nov 20, 2025

Uh oh!

brunovjk commented Nov 20, 2025

Uh oh!

ShridharGoel commented Nov 20, 2025

Uh oh!

ShridharGoel commented Nov 20, 2025

Uh oh!

brunovjk commented Nov 25, 2025

Uh oh!

ShridharGoel commented Nov 26, 2025

Uh oh!

brunovjk commented Nov 26, 2025

Uh oh!

ShridharGoel commented Nov 26, 2025

Uh oh!

brunovjk commented Nov 26, 2025

Uh oh!

mollfpr commented Dec 2, 2025

Uh oh!

brunovjk commented Dec 2, 2025

Uh oh!

ShridharGoel commented Dec 2, 2025

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

brunovjk commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mollfpr commented Dec 6, 2025

Uh oh!

ShridharGoel commented Dec 6, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 10, 2025

ShridharGoel commented Nov 17, 2025 •

edited

Loading

codecov bot commented Nov 17, 2025 •

edited by github-actions bot

Loading

brunovjk commented Nov 18, 2025 •

edited

Loading

brunovjk commented Dec 2, 2025 •

edited

Loading