fix: Tags - App freezes on import tags page when download backup is cancelled. by Krishna2323 · Pull Request #75374 · Expensify/App

Krishna2323 · 2025-11-18T09:30:33Z

Explanation of Change

Fixed Issues

$ #74656
PROPOSAL: #74656 (comment)

Tests

Launch Hybrid app & sign in with gmail account
Create workspace >> More features >> enable tags
Navigate to Tags option
Add few tags
Tap More >> Import spreadsheet
Select either Single level of tags or Multi-level tags (upgrade to control WS)
Click "download a backup" link
Cancel the download (do not save CSV export)
Click Cancel (or Switch Tag Levels)
Try clicking either Multi-level tags, Single level tags or back button in import tags page
Verify app is working fine

Verify that no errors appear in the JS console

Offline tests

Required internet to import the tags

QA Steps

Same as tests
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…ancelled. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

codecov · 2025-11-18T09:41:34Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/workspace/tags/ImportTagsOptionsPage.tsx	`0.00% <ø> (ø)`
...c/pages/workspace/perDiem/WorkspacePerDiemPage.tsx	`0.00% <0.00%> (ø)`
src/libs/fileDownload/index.ios.ts	`3.44% <6.66%> (+0.70%)`	⬆️
... and 8 files with indirect coverage changes

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-11-18T10:08:21Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hungvu193 · 2025-11-19T07:51:33Z

src/pages/workspace/tags/ImportTagsOptionsPage.tsx

+                            downloadMultiLevelTagsCSV(
+                                policyID,
+                                () => {
+                                    setIsDownloadFailureModalVisible(true);


Oh I thought we only needed to wrap this callback with close to prevent overlap modal right 🤔 ?

I think you're right here, we should only wrap the state update callback for better UX. Thanks for catching that. Updated

hungvu193 · 2025-11-19T07:55:33Z

src/libs/fileDownload/index.ios.ts

+            if (isUserCancelled(error)) {
+                return;
+            }


Let's leave a comment here to explain. Thanks 😄

Comment added.

JmillsExpensify

No review required from a product perspective. Unsubscribing.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hungvu193 · 2025-11-21T01:50:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-19.at.22.51.12.mov

Android: mWeb Chrome

Screen.Recording.2025-11-19.at.22.53.40.mov

iOS: HybridApp

Screen.Recording.2025-11-19.at.22.38.05.mov

iOS: mWeb Safari

mSafari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-19.at.22.31.53.mov

MacOS: Desktop

Screen.Recording.2025-11-19.at.22.47.52.mov

hungvu193 · 2025-11-21T01:50:32Z

@Krishna2323 Could you merge main again? Some tests are failing

OSBotify · 2025-11-21T10:33:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-21T12:27:46Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.2.62-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-24T20:02:47Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.62-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Tags - App freezes on import tags page when download backup is c…

5ce70cc

…ancelled. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot bot assigned Krishna2323 Nov 18, 2025

Krishna2323 added 2 commits November 18, 2025 15:12

update switchSingleToMultiLevelTagPrompt.

82f0bbc

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix ESLint.

884cd98

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review November 18, 2025 10:08

Krishna2323 requested review from a team as code owners November 18, 2025 10:08

melvin-bot bot requested review from JmillsExpensify and hungvu193 and removed request for a team November 18, 2025 10:08

melvin-bot bot removed the request for review from a team November 18, 2025 10:08

github-actions bot reviewed Nov 18, 2025

View reviewed changes

src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx Show resolved Hide resolved

use the icons as individual dependencies.

dc04e0e

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hungvu193 reviewed Nov 19, 2025

View reviewed changes

JmillsExpensify reviewed Nov 19, 2025

View reviewed changes

address PR comments.

063b65b

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/74656

f14e908

hungvu193 approved these changes Nov 21, 2025

View reviewed changes

melvin-bot bot requested a review from aldo-expensify November 21, 2025 09:02

aldo-expensify approved these changes Nov 21, 2025

View reviewed changes

aldo-expensify merged commit 4092be2 into Expensify:main Nov 21, 2025
31 checks passed

OSBotify mentioned this pull request Nov 21, 2025

Deploy Checklist: New Expensify 2025-11-21 #75728

Closed

hungvu193 mentioned this pull request Dec 4, 2025

Warning Modal About Switching Tags Shows Up When Re-uploading Multi Level Tags #69676

Merged

51 tasks

Conversation

Krishna2323 commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Nov 18, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Nov 18, 2025

Uh oh!

Uh oh!

hungvu193 Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

hungvu193 Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Nov 21, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 commented Nov 21, 2025

Uh oh!

Uh oh!

OSBotify commented Nov 21, 2025

Uh oh!

OSBotify commented Nov 21, 2025

Uh oh!

OSBotify commented Nov 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Krishna2323 commented Nov 18, 2025 •

edited

Loading

codecov bot commented Nov 18, 2025 •

edited by github-actions bot

Loading