Make ReportChangeWorkspacePage use new SelectionList#75378
Merged
grgia merged 12 commits intoExpensify:mainfrom Nov 21, 2025
Merged
Make ReportChangeWorkspacePage use new SelectionList#75378grgia merged 12 commits intoExpensify:mainfrom
ReportChangeWorkspacePage use new SelectionList#75378grgia merged 12 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
| <BaseTextInput | ||
| ref={mergedRef} | ||
| onKeyPress={onKeyPress} | ||
| onFocus={() => onFocusChange?.(true)} |
Contributor
There was a problem hiding this comment.
Maybe we could add handleFocusChange in a similar way to how we handle handleTextInputChange
Contributor
Author
There was a problem hiding this comment.
do you mean like below? it's not a big difference 🤔
onFocus={() => handleFocusChange(true)}
onBlur={() => handleFocusChange(false)}
Contributor
Author
There was a problem hiding this comment.
or?
const handleFocus = useCallback(() => {
onFocusChange(true);
}, [onFocusChange]);
const handleBlur = useCallback(() => {
onFocusChange(false);
}, [onFocusChange]);
return (
<View style={[styles.ph5, styles.pb3]}>
<BaseTextInput
ref={mergedRef}
onKeyPress={onKeyPress}
onFocus={handleFocus}
onBlur={handleBlur}
Contributor
There was a problem hiding this comment.
Yeah, I meant second option 😅
melvin-bot
bot
requested review from
JmillsExpensify and
dukenv0307
and removed request for
a team
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
grgia
changed the title
ReportChangeWorkspacePage use new SelectionListReportChangeWorkspacePage use new SelectionList
Contributor
JmillsExpensify
left a comment
JmillsExpensify
left a comment
There was a problem hiding this comment.
No review required from a product perspective. Unsubscribing.
grgia
changed the title
ReportChangeWorkspacePage use new SelectionListReportChangeWorkspacePage use new SelectionList
dukenv0307
reviewed
Nov 20, 2025
dukenv0307
reviewed
Nov 20, 2025
| textInputOptions={textInputOptions} | ||
| initiallyFocusedItemKey={report.policyID} | ||
| showLoadingPlaceholder={fetchStatus.status === 'loading' || !didScreenTransitionEnd} | ||
| disableMaintainingScrollPosition |
Contributor
Author
There was a problem hiding this comment.
There is an enabled by default option in FlashList that the scroll position stays the same. Here we expect that after clearing input the scroll goes to the beginning of the list.
So I add a possibility to disable this option. In all others usages of FlashList it's also disabled 😉
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-20.at.22.20.05.movAndroid: mWeb ChromeScreen.Recording.2025-11-20.at.22.15.46.moviOS: HybridAppScreen.Recording.2025-11-20.at.22.19.46.moviOS: mWeb SafariScreen.Recording.2025-11-20.at.22.17.46.movMacOS: Chrome / SafariScreen.Recording.2025-11-20.at.22.13.24.movMacOS: DesktopScreen.Recording.2025-11-20.at.22.19.19.mov |
dukenv0307
approved these changes
Nov 20, 2025
grgia
approved these changes
Nov 21, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
98 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.2.63-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.63-8 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #72970
PROPOSAL:
Tests
MoreChange workspaceOffline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
iOS: Native
Screen.Recording.2025-11-18.at.11.55.40.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov
MacOS: Desktop