Make AssigneeStep use new SelectionList#75441
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
AssigneeStep use new SelectionListAssigneeStep use new SelectionList
JmillsExpensify
left a comment
There was a problem hiding this comment.
No review required from a product perspective. Unsubscribing.
AssigneeStep use new SelectionListAssigneeStep use new SelectionList
|
Same here, with new merge this component became one with sections so I'd say migration in this phase is not applicable here. |
|
After analysing this case, I started thinking that maybe those sections aren't really necessary, as they don't have any titles, they are just a way of organising the data I implemented an alternative way with just one section. What do you think, @dukenv0307, can we continue the migration here? Or will the behaviour be different? When I tested it, it seemed okay Situation is similar in this PR |
|
Checks are failing because of main |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-24.at.21.40.25.movAndroid: mWeb ChromeScreen.Recording.2025-11-24.at.21.39.07.moviOS: HybridAppScreen.Recording.2025-11-24.at.21.38.27.moviOS: mWeb SafariScreen.Recording.2025-11-24.at.21.39.59.movMacOS: Chrome / SafariScreen.Recording.2025-11-24.at.21.31.01.movMacOS: DesktopScreen.Recording.2025-11-24.at.21.44.07.mov |
|
@zfurtak Can you please merge main? |
|
Lint error is not related to this PR |
|
@zfurtak would you merge main? |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.2.67-0 🚀
|
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.2.70-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀
|
Explanation of Change
Fixed Issues
$ #72970
PROPOSAL:
Tests
WorkspacesExpensify CardsIssue cardOffline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
iOS: Native
ios.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov
MacOS: Desktop