Removing violations when policy category is created

src/hooks/usePolicyData/index.ts

@@ -4,18 +4,16 @@ import {useAllReportsTransactionsAndViolations} from '@components/OnyxListItemPr
 import useOnyx from '@hooks/useOnyx';
 import usePolicy from '@hooks/usePolicy';
 import ONYXKEYS from '@src/ONYXKEYS';
-import type {Policy, Report} from '@src/types/onyx';
+import type {Report} from '@src/types/onyx';
 import type {ReportTransactionsAndViolationsDerivedValue} from '@src/types/onyx/DerivedValues';
-import type {OnyxValueWithOfflineFeedback} from '@src/types/onyx/OnyxCommon';
 import type PolicyData from './types';
 
 /**
  * Retrieves policy tags, categories, reports and their associated transactions and violations.
  * @param policyID The ID of the policy to retrieve data for.
  * @returns An object containing policy data
  */
-function usePolicyData(policyID?: string): PolicyData {
-    const policy = usePolicy(policyID);
+function usePolicyData(policyID: string): PolicyData {
     const allReportsTransactionsAndViolations = useAllReportsTransactionsAndViolations();
 
     // Stable selector for useOnyx to avoid defining the selector inline
@@ -37,26 +35,29 @@ function usePolicyData(policyID?: string): PolicyData {
         [policyID, allReportsTransactionsAndViolations],
     );
 
+    const policy = usePolicy(policyID);
     const [tags] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`, {canBeMissing: true}, [policyID]);
     const [categories] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`, {canBeMissing: true}, [policyID]);
     const [reports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: true, selector: reportsSelectorCallback}, [policyID, allReportsTransactionsAndViolations]);
     const transactionsAndViolations = useMemo(() => {
         if (!reports || !allReportsTransactionsAndViolations) {
             return {};
         }
-        return Object.keys(reports).reduce<ReportTransactionsAndViolationsDerivedValue>((acc, reportID) => {
-            if (allReportsTransactionsAndViolations[reportID]) {
+        return Object.entries(reports).reduce<ReportTransactionsAndViolationsDerivedValue>((acc, [reportID]) => {
+            if (Object.keys(allReportsTransactionsAndViolations[reportID].transactions).length > 0) {
                 acc[reportID] = allReportsTransactionsAndViolations[reportID];
             }
             return acc;
         }, {});
     }, [reports, allReportsTransactionsAndViolations]);
+
     return {
         transactionsAndViolations,
         tags: tags ?? {},
-        categories: categories ?? {},
-        policy: policy as OnyxValueWithOfflineFeedback<Policy>,
-        reports: Object.values(reports ?? {}) as Array<OnyxValueWithOfflineFeedback<Report>>,
+        categories,
+        policyID,
+        policy,
+        reports: Object.values(reports ?? {}),
     };
 }
 

src/hooks/usePolicyData/types.ts

@@ -1,12 +1,13 @@
+import type {OnyxEntry} from 'react-native-onyx';
 import type {Policy, PolicyCategories, PolicyTagLists, Report} from '@src/types/onyx';
 import type {ReportTransactionsAndViolationsDerivedValue} from '@src/types/onyx/DerivedValues';
-import type {OnyxValueWithOfflineFeedback} from '@src/types/onyx/OnyxCommon';
 
 type PolicyData = {
-    policy: OnyxValueWithOfflineFeedback<Policy>;
+    policyID: string;
+    policy: OnyxEntry<Policy>;
     tags: PolicyTagLists;
-    categories: PolicyCategories;
-    reports: Array<OnyxValueWithOfflineFeedback<Report>>;
+    categories: OnyxEntry<PolicyCategories>;
+    reports: Array<OnyxEntry<Report>>;
     transactionsAndViolations: ReportTransactionsAndViolationsDerivedValue;
 };
 

src/libs/ReportUtils.ts

@@ -960,7 +960,7 @@
 const parsedReportActionMessageCache: Record<string, string> = {};
 
 let conciergeReportID: OnyxEntry<string>;
 Onyx.connect({
     key: ONYXKEYS.CONCIERGE_REPORT_ID,
     callback: (value) => {
         conciergeReportID = value;
@@ -968,7 +968,7 @@
 });
 
 const defaultAvatarBuildingIconTestID = 'SvgDefaultAvatarBuilding Icon';
 Onyx.connect({
     key: ONYXKEYS.SESSION,
     callback: (value) => {
         // When signed out, val is undefined
@@ -986,7 +986,7 @@
 let allPersonalDetails: OnyxEntry<PersonalDetailsList>;
 let allPersonalDetailLogins: string[];
 let currentUserPersonalDetails: OnyxEntry<PersonalDetails>;
 Onyx.connect({
     key: ONYXKEYS.PERSONAL_DETAILS_LIST,
     callback: (value) => {
         if (currentUserAccountID) {
@@ -998,14 +998,14 @@
 });
 
 let allReportsDraft: OnyxCollection<Report>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_DRAFT,
     waitForCollectionCallback: true,
     callback: (value) => (allReportsDraft = value),
 });
 
 let allPolicies: OnyxCollection<Policy>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.POLICY,
     waitForCollectionCallback: true,
     callback: (value) => (allPolicies = value),
@@ -1020,7 +1020,7 @@
 
 let allReports: OnyxCollection<Report>;
 let reportsByPolicyID: ReportByPolicyMap;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT,
     waitForCollectionCallback: true,
     callback: (value) => {
@@ -1058,14 +1058,14 @@
 });
 
 let allBetas: OnyxEntry<Beta[]>;
 Onyx.connect({
     key: ONYXKEYS.BETAS,
     callback: (value) => (allBetas = value),
 });
 
 let allTransactions: OnyxCollection<Transaction> = {};
 let reportsTransactions: Record<string, Transaction[]> = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.TRANSACTION,
     waitForCollectionCallback: true,
     callback: (value) => {
@@ -1091,7 +1091,7 @@
 });
 
 let allReportActions: OnyxCollection<ReportActions>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
     waitForCollectionCallback: true,
     callback: (actions) => {
@@ -1104,7 +1104,7 @@
 
 let allReportMetadata: OnyxCollection<ReportMetadata>;
 const allReportMetadataKeyValue: Record<string, ReportMetadata> = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_METADATA,
     waitForCollectionCallback: true,
     callback: (value) => {
@@ -1987,9 +1987,13 @@
     categoriesUpdate: Record<string, Partial<PolicyCategory>> = {},
     tagListsUpdate: Record<string, Partial<PolicyTagList>> = {},
 ) {
+    const {policy, tags: tagLists, categories} = policyData;
+    if (policy === undefined) {
+        return;
+    }
     const nonInvoiceReportTransactionsAndViolations = policyData.reports.reduce<ReportTransactionsAndViolations[]>((acc, report) => {
         // Skipping invoice reports since they should not have any category or tag violations
-        if (isInvoiceReport(report)) {
+        if (report === undefined || isInvoiceReport(report)) {
             return acc;
         }
         const reportTransactionsAndViolations = policyData.transactionsAndViolations[report.reportID];
@@ -2015,53 +2019,72 @@
     }
 
     // Merge the existing policy with the optimistic updates
-    const optimisticPolicy = isPolicyUpdateEmpty ? policyData.policy : {...policyData.policy, ...policyUpdate};
+    const optimisticPolicy = isPolicyUpdateEmpty ? policy : {...policy, ...policyUpdate};
 
     // Merge the existing categories with the optimistic updates
     const optimisticCategories = isCategoriesUpdateEmpty
-        ? policyData.categories
+        ? (categories ?? {})
         : {
-              ...Object.fromEntries(Object.entries(policyData.categories).filter(([categoryName]) => !(categoryName in categoriesUpdate) || !!categoriesUpdate[categoryName])),
+              ...Object.fromEntries(Object.entries(categories ?? {}).filter(([categoryName]) => !(categoryName in categoriesUpdate) || !!categoriesUpdate[categoryName])),
               ...Object.entries(categoriesUpdate).reduce<PolicyCategories>((acc, [categoryName, categoryUpdate]) => {
                   if (!categoryUpdate) {
                       return acc;
                   }
+                  const category = categories?.[categoryName];
+                  if (category === undefined) {
+                      acc[categoryName] = categoryUpdate as PolicyCategory;
+                      return acc;
+                  }
+
                   acc[categoryName] = {
-                      ...(policyData.categories?.[categoryName] ?? {}),
+                      ...category,
                       ...categoryUpdate,
-                  };
+                  } as PolicyCategory;
                   return acc;
               }, {}),
           };
 
     // Merge the existing tag lists with the optimistic updates
     const optimisticTagLists = isTagListsUpdateEmpty
-        ? policyData.tags
+        ? (tagLists ?? {})
         : {
-              ...Object.fromEntries(Object.entries(policyData.tags ?? {}).filter(([tagListName]) => !(tagListName in tagListsUpdate) || !!tagListsUpdate[tagListName])),
+              ...Object.fromEntries(Object.entries(tagLists ?? {}).filter(([tagListName]) => !(tagListName in tagListsUpdate) || !!tagListsUpdate[tagListName])),
               ...Object.entries(tagListsUpdate).reduce<PolicyTagLists>((acc, [tagListName, tagListUpdate]) => {
-                  if (!tagListUpdate) {
+                  if (!tagListName || !tagListUpdate) {
                       return acc;
                   }
 
-                  const tagList = policyData.tags?.[tagListName];
-                  const tags = tagList.tags ?? {};
+                  const tagList = tagLists?.[tagListName];
+                  if (!tagList) {
+                      acc[tagListName] = tagListUpdate as PolicyTagList;
+                      return acc;
+                  }
+                  const tags = tagList?.tags;
+                  if (!tags) {
+                      acc[tagListName] = {...tagList, ...tagListUpdate} as PolicyTagList;
+                      return acc;
+                  }
                   const tagsUpdate = tagListUpdate?.tags ?? {};
-
                   acc[tagListName] = {
                       ...tagList,
                       ...tagListUpdate,
                       tags: {
                           ...((): PolicyTags => {
-                              const optimisticTags: PolicyTags = Object.fromEntries(Object.entries(tags).filter(([tagName]) => !(tagName in tagsUpdate) || !!tagsUpdate[tagName]));
+                              const optimisticTags: PolicyTags = Object.fromEntries(
+                                  Object.entries(tags ?? {}).filter(([tagName, tag]) => !tag || !(tagName in tagsUpdate) || !!tagsUpdate[tagName]),
+                              );
                               for (const [tagName, tagUpdate] of Object.entries(tagsUpdate)) {
                                   if (!tagUpdate) {
                                       continue;
                                   }
-                                  optimisticTags[tagName] = {
-                                      ...(tags[tagName] ?? {}),
-                                      ...tagUpdate,
-                                  };
+                                  const tag = tags?.[tagName];
+                                  optimisticTags[tagName] =
+                                      tag !== undefined
+                                          ? {
+                                                ...tag,
+                                                ...tagUpdate,
+                                            }
+                                          : tagUpdate;
                               }
                               return optimisticTags;
                           })(),

src/libs/actions/Policy/Category.ts

@@ -323,8 +323,12 @@ function setWorkspaceCategoryEnabled(
     setupCategoryTaskParentReport: OnyxEntry<Report>,
     currentUserAccountID: number,
 ) {
-    const policyID = policyData.policy?.id;
-    const policyCategoriesOptimisticData = {
+    const {policyID, categories} = policyData;
+    if (!categories) {
+        Log.warn('setWorkspaceCategoryEnabled invalid params', {categories});
+        return;
+    }
+    const categoriesOptimisticData = {
         ...Object.keys(categoriesToUpdate).reduce<PolicyCategories>((acc, key) => {
             acc[key] = {
                 ...categoriesToUpdate[key],
@@ -344,7 +348,7 @@ function setWorkspaceCategoryEnabled(
             {
                 onyxMethod: Onyx.METHOD.MERGE,
                 key: `${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`,
-                value: policyCategoriesOptimisticData,
+                value: categoriesOptimisticData,
             },
         ],
         successData: [
@@ -373,7 +377,7 @@ function setWorkspaceCategoryEnabled(
                 value: {
                     ...Object.keys(categoriesToUpdate).reduce<PolicyCategories>((acc, key) => {
                         acc[key] = {
-                            ...policyData.categories[key],
+                            ...categories[key],
                             errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('workspace.categories.updateFailureMessage'),
                             pendingFields: {
                                 enabled: null,
@@ -388,7 +392,7 @@ function setWorkspaceCategoryEnabled(
         ],
     };
 
-    pushTransactionViolationsOnyxData(onyxData, policyData, {}, policyCategoriesOptimisticData);
+    pushTransactionViolationsOnyxData(onyxData, policyData, {}, categoriesOptimisticData);
     appendSetupCategoriesOnboardingData(onyxData, setupCategoryTaskReport, setupCategoryTaskParentReport, isSetupCategoriesTaskParentReportArchived, currentUserAccountID);
 
     const parameters = {
@@ -469,9 +473,9 @@ function setPolicyCategoryDescriptionRequired(policyID: string, categoryName: st
 }
 
 function setPolicyCategoryReceiptsRequired(policyData: PolicyData, categoryName: string, maxAmountNoReceipt: number) {
-    const policyID = policyData.policy?.id;
-    const originalMaxAmountNoReceipt = policyData.categories[categoryName]?.maxAmountNoReceipt;
-    const policyCategoriesOptimisticData = {
+    const {policyID, categories} = policyData;
+    const originalMaxAmountNoReceipt = categories?.[categoryName]?.maxAmountNoReceipt;
+    const categoriesOptimisticData = {
         [categoryName]: {
             pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
             pendingFields: {
@@ -486,7 +490,7 @@ function setPolicyCategoryReceiptsRequired(policyData: PolicyData, categoryName:
             {
                 onyxMethod: Onyx.METHOD.MERGE,
                 key: `${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`,
-                value: policyCategoriesOptimisticData,
+                value: categoriesOptimisticData,
             },
         ],
         successData: [
@@ -522,7 +526,7 @@ function setPolicyCategoryReceiptsRequired(policyData: PolicyData, categoryName:
         ],
     };
 
-    pushTransactionViolationsOnyxData(onyxData, policyData, {}, policyCategoriesOptimisticData);
+    pushTransactionViolationsOnyxData(onyxData, policyData, {}, categoriesOptimisticData);
 
     const parameters: SetPolicyCategoryReceiptsRequiredParams = {
         policyID,
@@ -534,9 +538,9 @@ function setPolicyCategoryReceiptsRequired(policyData: PolicyData, categoryName:
 }
 
 function removePolicyCategoryReceiptsRequired(policyData: PolicyData, categoryName: string) {
-    const policyID = policyData.policy?.id;
-    const originalMaxAmountNoReceipt = policyData.categories[categoryName]?.maxAmountNoReceipt;
-    const policyCategoriesOptimisticData = {
+    const {policyID, categories} = policyData;
+    const originalMaxAmountNoReceipt = categories?.[categoryName]?.maxAmountNoReceipt;
+    const categoriesOptimisticData = {
         [categoryName]: {
             pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
             pendingFields: {
@@ -551,7 +555,7 @@ function removePolicyCategoryReceiptsRequired(policyData: PolicyData, categoryNa
             {
                 onyxMethod: Onyx.METHOD.MERGE,
                 key: `${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`,
-                value: policyCategoriesOptimisticData,
+                value: categoriesOptimisticData,
             },
         ],
         successData: [
@@ -587,7 +591,7 @@ function removePolicyCategoryReceiptsRequired(policyData: PolicyData, categoryNa
         ],
     };
 
-    pushTransactionViolationsOnyxData(onyxData, policyData, {}, policyCategoriesOptimisticData);
+    pushTransactionViolationsOnyxData(onyxData, policyData, {}, categoriesOptimisticData);
 
     const parameters: RemovePolicyCategoryReceiptsRequiredParams = {
         policyID,
@@ -598,17 +602,18 @@ function removePolicyCategoryReceiptsRequired(policyData: PolicyData, categoryNa
 }
 
 function createPolicyCategory(
-    policyID: string,
+    policyData: PolicyData,
     categoryName: string,
     isSetupCategoriesTaskParentReportArchived: boolean,
     setupCategoryTaskReport: OnyxEntry<Report>,
     setupCategoryTaskParentReport: OnyxEntry<Report>,
     currentUserAccountID: number,
 ) {
-    const onyxData = buildOptimisticPolicyCategories(policyID, [categoryName]);
+    const onyxData = buildOptimisticPolicyCategories(policyData.policyID, [categoryName]);
     appendSetupCategoriesOnboardingData(onyxData, setupCategoryTaskReport, setupCategoryTaskParentReport, isSetupCategoriesTaskParentReportArchived, currentUserAccountID);
+
     const parameters = {
-        policyID,
+        policyID: policyData.policyID,
         categories: JSON.stringify([{name: categoryName}]),
     };
 
@@ -636,9 +641,8 @@ function importPolicyCategories(policyID: string, categories: PolicyCategory[])
 }
 
 function renamePolicyCategory(policyData: PolicyData, policyCategory: {oldName: string; newName: string}) {
-    const policy = policyData.policy;
-    const policyID = policy.id;
-    const policyCategoryToUpdate = policyData.categories?.[policyCategory.oldName];
+    const {policyID, policy, categories} = policyData;
+    const policyCategoryToUpdate = categories?.[policyCategory.oldName];
 
     const policyCategoryApproverRule = CategoryUtils.getCategoryApproverRule(policy?.rules?.approvalRules ?? [], policyCategory.oldName);
     const policyCategoryExpenseRule = CategoryUtils.getCategoryExpenseRule(policy?.rules?.expenseRules ?? [], policyCategory.oldName);
@@ -683,7 +687,7 @@ function renamePolicyCategory(policyData: PolicyData, policyCategory: {oldName:
         mccGroup: updatedMccGroup,
     };
 
-    const policyCategoriesOptimisticData = {
+    const categoriesOptimisticData = {
         [policyCategory.newName]: {
             ...policyCategoryToUpdate,
             errors: null,
@@ -704,7 +708,7 @@ function renamePolicyCategory(policyData: PolicyData, policyCategory: {oldName:
                 key: `${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`,
                 value: {
                     [policyCategory.oldName]: null,
-                    ...policyCategoriesOptimisticData,
+                    ...categoriesOptimisticData,
                 },
             },
             {
@@ -767,7 +771,7 @@ function renamePolicyCategory(policyData: PolicyData, policyCategory: {oldName:
         return acc;
     }, {});
 
-    pushTransactionViolationsOnyxData(onyxData, {...policyData, categories: policyCategories}, policyOptimisticData, policyCategoriesOptimisticData);
+    pushTransactionViolationsOnyxData(onyxData, {...policyData, categories: policyCategories}, policyOptimisticData, categoriesOptimisticData);
 
     const parameters = {
         policyID,
@@ -914,7 +918,7 @@ function setPolicyCategoryGLCode(policyID: string, categoryName: string, glCode:
 }
 
 function setWorkspaceRequiresCategory(policyData: PolicyData, requiresCategory: boolean) {
-    const policyID = policyData.policy?.id;
+    const {policyID} = policyData;
     const policyOptimisticData: Partial<Policy> = {
         requiresCategory,
         errors: {
@@ -1001,14 +1005,14 @@ function deleteWorkspaceCategories(
     setupCategoryTaskParentReport: OnyxEntry<Report>,
     currentUserAccountID: number,
 ) {
-    const policyID = policyData.policy?.id;
+    const {policyID, categories} = policyData;
     const optimisticPolicyCategoriesData = categoryNamesToDelete.reduce<Record<string, Partial<PolicyCategory>>>((acc, categoryName) => {
         acc[categoryName] = {pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE, enabled: false};
         return acc;
     }, {});
 
     const shouldDisableRequiresCategory = !hasEnabledOptions(
-        Object.values(policyData.categories).filter((category) => !categoryNamesToDelete.includes(category.name) && category.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE),
+        Object.values(categories ?? {}).filter((category) => !categoryNamesToDelete.includes(category.name) && category.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE),
     );
     const optimisticPolicyData: Partial<Policy> = shouldDisableRequiresCategory
         ? {
@@ -1062,7 +1066,7 @@ function deleteWorkspaceCategories(
 }
 
 function enablePolicyCategories(policyData: PolicyData, enabled: boolean, shouldGoBack = true) {
-    const policyID = policyData.policy?.id;
+    const {policyID, categories} = policyData;
     const policyUpdate: Partial<Policy> = {
         areCategoriesEnabled: enabled,
         pendingFields: {
@@ -1106,7 +1110,7 @@ function enablePolicyCategories(policyData: PolicyData, enabled: boolean, should
 
     if (!enabled) {
         policyCategoriesUpdate = Object.fromEntries(
-            Object.entries(policyData.categories).map(([categoryName]) => [
+            Object.entries(categories ?? {}).map(([categoryName]) => [
                 categoryName,
                 {
                     enabled: false,

src/pages/iou/request/step/IOURequestStepCategory.tsx

@@ -71,7 +71,7 @@ function IOURequestStepCategory({
 
     const report = reportReal ?? reportDraft;
     const policyCategories = policyCategoriesReal ?? policyCategoriesDraft;
-    const policyData = usePolicyData(policy?.id);
+    const policyData = usePolicyData(policyID ?? CONST.DEFAULT_NUMBER_ID.toString());
     const {currentSearchHash} = useSearchContext();
     const isEditing = action === CONST.IOU.ACTION.EDIT;
     const isEditingSplit = (iouType === CONST.IOU.TYPE.SPLIT || iouType === CONST.IOU.TYPE.SPLIT_EXPENSE) && isEditing;