[No QA] Add automated tests for showing GBR when a copilot logs into an admin account with reports awaiting approval#75505
Merged
NikkiWines merged 3 commits intoExpensify:mainfrom Nov 19, 2025
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Collaborator
|
@NikkiWines I am assuming this doesn't need a review from me. |
Contributor
|
yeah you're all good @mananjadhav |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Contributor
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.62-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.62-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR adds the complementary FE tests for Auth PR https://github.com/Expensify/Auth/pull/18182 to ensure that a GBR is shown when a user copilots into an account with a report pending approval. Backend sends
hasOutstandingChildRequestastruefor such reports. So, the added tests check for that.Fixed Issues
$ #69901
$ #69902
PROPOSAL: NA
Tests
npm run testa few times (to ensure the random generated reports do not fail sometimes) and ensure all tests pass.Offline tests
NA
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
NA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop