Skip to content

[No QA] Fix typecheck #75539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipaval merged 2 commits into from
Nov 19, 2025
Merged

[No QA] Fix typecheck #75539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0468d54
Fix typecheck
cristipaval Nov 19, 2025
edd9e0c
Fix prettier
cristipaval Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions tests/unit/ReportSecondaryActionUtilsTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,15 @@ describe('getSecondaryAction', () => {
date: '2025-01-01',
} as unknown as Transaction;

const result = getSecondaryReportActions({currentUserEmail: EMPLOYEE_EMAIL, report, chatReport, reportTransactions: [transaction1, transaction2], violations: {}, policy});
const result = getSecondaryReportActions({
currentUserEmail: EMPLOYEE_EMAIL,
report,
chatReport,
reportTransactions: [transaction1, transaction2],
originalTransaction: {} as Transaction,
violations: {},
policy,
});
expect(result.includes(CONST.REPORT.SECONDARY_ACTIONS.SUBMIT)).toBe(true);
});

Expand All @@ -207,7 +215,15 @@ describe('getSecondaryAction', () => {
} as unknown as Policy;
await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${REPORT_ID}`, report);

const result = getSecondaryReportActions({currentUserEmail: EMPLOYEE_EMAIL, report, chatReport, reportTransactions: [], violations: {}, policy});
const result = getSecondaryReportActions({
currentUserEmail: EMPLOYEE_EMAIL,
report,
chatReport,
reportTransactions: [],
originalTransaction: {} as Transaction,
violations: {},
policy,
});
expect(result.includes(CONST.REPORT.SECONDARY_ACTIONS.SUBMIT)).toBe(false);
});

Expand Down
Loading