Skip to content

Revert "Prevent making redundant API call when report is not loaded" #75585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iwiznia wants to merge 1 commit into from
Closed

Revert "Prevent making redundant API call when report is not loaded" #75585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/pages/home/report/ReportActionsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ function ReportActionsList({
const isTryNewDotNVPDismissed = !!tryNewDot?.classicRedirect?.dismissed;
const [isScrollToBottomEnabled, setIsScrollToBottomEnabled] = useState(false);
const [actionIdToHighlight, setActionIdToHighlight] = useState('');
const [reportMetadata] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${report.reportID}`, {canBeMissing: true});

const backTo = route?.params?.backTo as string;
// Display the new message indicator when comment linking and not close to the newest message.
Expand Down Expand Up @@ -406,11 +405,6 @@ function ReportActionsList({
return;
}

// Do not try to mark the report as read if the report has not been loaded and shared with the user
if (!reportMetadata?.hasOnceLoadedReportActions) {
return;
}

if (isUnread(report, transactionThreadReport, isReportArchived) || (lastAction && isCurrentActionUnread(report, lastAction, sortedVisibleReportActions))) {
// On desktop, when the notification center is displayed, isVisible will return false.
// Currently, there's no programmatic way to dismiss the notification center panel.
Expand All @@ -427,7 +421,7 @@ function ReportActionsList({
readActionSkipped.current = true;
}
// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
}, [report.lastVisibleActionCreated, transactionThreadReport?.lastVisibleActionCreated, report.reportID, isVisible, reportMetadata?.hasOnceLoadedReportActions]);
}, [report.lastVisibleActionCreated, transactionThreadReport?.lastVisibleActionCreated, report.reportID, isVisible]);

const handleAppVisibilityMarkAsRead = useCallback(() => {
if (report.reportID !== prevReportID) {
Expand Down
Loading