[Standardize payment button] Enable GR currencies for wallet payment#75719
[Standardize payment button] Enable GR currencies for wallet payment#75719grgia merged 19 commits intoExpensify:mainfrom
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
grgia
left a comment
There was a problem hiding this comment.
Would prefer to define a new type so we'd only need to update it in one place if we needed to change it later
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Little bump @getusha 🙏 I'll be OOO next few days so could you please take a look? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-rec-2.webmAndroid: mWeb Chromeandroid-rec-1.webmiOS: HybridAppSimulator.Screen.Recording.-.iPhone.15.Pro.-.2025-11-26.at.14.39.15.moviOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.-.2025-11-26.at.14.01.26.movMacOS: Chrome / SafariScreen.Recording.2025-11-26.at.1.51.48.in.the.afternoon.mov |
|
@joekaufmanexpensify im assigning incase you want to take a look, if not can you merge? |
|
I think Joe is OOO |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Nice! We did create the GBP workspace while offline now. The behavior was funky (see video), but I am thinking that's because the backend changes aren't done. Is that right? 2025-12-03_12-04-39.mp4 |
I don't think it's related to BE changes (Cause we were creating the workspace offline). I believe it's related to optimistic data of |
|
Got it. I'll do one final test when Georgia's backend PR is deployed 👍 |
|
Web PR was Deployed to staging. I passed the param |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
I will test today 👍 |
|
Changes work well for me on adhoc! |
|
Awesome! We can go ahead and merge it! |
|
I think this PR is making some tests fail on main, see https://github.com/Expensify/App/actions/runs/20050243643/job/57510571925?pr=76504. @hungvu193 can you please fix those errors? |
Sure. Let me take a look |
|
I don't think this PR causes the failing lint 🤔. It was merged yesterday and other PRs were created after that didn't have this kind of linting. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.2.74-0 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
Explanation of Change
We currently only support
USDcurrency for wallet payment. This PR will allow users with GR currencies to pay with wallet.Fixed Issues
$ #55868
PROPOSAL: N/A
Tests
Same as QA steps.
Offline tests
N/A
QA Steps
Prerequisite:
Pay with workspaceoptions.Pay with personal account option.Pay.Pay with workspaceoptions.Pay with personal account option.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-11-21.at.13.56.46.mov
MacOS: Desktop