Add delegate access restriction checks to search page actions by mukhrr · Pull Request #75821 · Expensify/App

mukhrr · 2025-11-22T18:09:15Z

Explanation of Change

Fixed Issues

$ #75171
PROPOSAL: #75171 (comment)

Tests

Precondition:
User A has added User B as copilot with Limited access level.

[User A] Go to workspace chat.
[User A] Create an expense and click Submit button.
[User A] Create another expense, click Submit and Approve button.
[User B] Go to Account.
[User B] Open account switcher and switch to User A account.
[User B] Go to Inbox and open User A's workspace chat.
[User B] Perform approval, payment, reject and hold actions on the expenses while on Inbox.
→ Verify Copilot is presented with "Not so fast" modal because copilot with Limited access level cannot perform approval, payment, reject and hold action on the expenses.
[User B] Go to Reports > Reports.
[User B] Click Approve and Pay button on the reports row.
→ Verify Copilot is presented with "Not so fast" modal
[User B] Select the report that is pending approval via checkbox > click dropdown button > Hold.
→ Verify Copilot is presented with "Not so fast" modal
[User B] Try to approve, hold multiple (bulk) expenses
→ Verify Copilot is presented with "Not so fast" modal

Verify that no errors appear in the JS console

Offline tests

QA Steps

The same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

codecov · 2025-11-22T18:17:28Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...nListWithSections/Search/ExpenseReportListItem.tsx	`3.22% <ø> (ø)`
...onListWithSections/Search/ReportListItemHeader.tsx	`94.73% <ø> (ø)`
src/components/MoneyRequestHeader.tsx	`0.82% <0.00%> (-0.01%)`	⬇️
...nents/Search/SearchPageHeader/SearchFiltersBar.tsx	`71.09% <50.00%> (+0.09%)`	⬆️
...ts/SelectionListWithSections/Search/ActionCell.tsx	`54.90% <0.00%> (-1.10%)`	⬇️
...ionListWithSections/Search/TransactionListItem.tsx	`1.58% <0.00%> (-0.03%)`	⬇️
src/pages/Search/SearchSelectedNarrow.tsx	`6.66% <0.00%> (ø)`
src/components/MoneyReportHeader.tsx	`0.16% <0.00%> (-0.01%)`	⬇️
src/pages/Search/SearchPage.tsx	`25.59% <10.00%> (-0.39%)`	⬇️
src/libs/actions/Search.ts	`21.46% <9.09%> (-0.31%)`	⬇️
... and 4 files with indirect coverage changes

melvin-bot · 2025-11-25T17:57:58Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mukhrr · 2025-11-25T18:36:13Z

@DylanDylann ~~do you think failing perf-tests are related to this PR?~~
Never mind it passed after I merge latest main)

trjExpensify

Did we get @jamesdeanexpensify eyes on this copy?

As it's specific to the limited access type, I feel like that should be explained.

Suggestion:

Not so fast...
As a copilot with limited access, you can't take this action. Sorry!

jamesdeanexpensify · 2025-11-26T19:25:19Z

That sounds good to me!

DylanDylann · 2025-11-28T09:59:55Z

@trjExpensify The copy in the modal isn't the new copy, It was added here. Should we update it again in this PR?

trjExpensify · 2025-11-28T17:19:22Z

Oh right hm, so this same modal shows for a restricted action for a full access Copilot as well?

DylanDylann · 2025-11-28T17:20:21Z

Yeah, we use the same modal

mukhrr · 2025-11-30T17:59:05Z

resolved conflicts with main branch here. fyi cc @DylanDylann @trjExpensify

DylanDylann · 2025-12-01T07:45:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-08.at.16.11.14.mov

Android: mWeb Chrome

Screen.Recording.2025-12-08.at.16.05.51.mov

iOS: HybridApp

Screen.Recording.2025-12-08.at.16.07.26.mov

iOS: mWeb Safari

Screen.Recording.2025-12-08.at.16.05.14.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-08.at.16.03.28.mov

DylanDylann · 2025-12-01T08:07:18Z

@mukhrr The code change looks fine. But there is one place that doesn't work for me. Could you please check?

Screen.Recording.2025-12-01.at.15.00.05.mov

DylanDylann · 2025-12-01T08:12:53Z

The similar case (with another action)

Screen.Recording.2025-12-01.at.15.11.14.mov

…nt or elsewhere

…ructuring

mukhrr · 2025-12-02T19:23:01Z

@DylanDylann this is ready

Gonals · 2025-12-09T14:26:43Z

We have some conflicts

mukhrr · 2025-12-09T14:36:50Z

@Gonals done

OSBotify · 2025-12-11T13:49:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-12T22:27:23Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.2.78-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

nlemma · 2025-12-13T14:17:47Z

@mukhrr this PR is failing with #77609

This reverts commit 306e38f, reversing changes made to e18b8bb.

[CP Staging] Revert "Merge pull request #75821 from mukhrr/fix/75171"

[CP Staging] Revert "Merge pull request #75821 from mukhrr/fix/75171" (cherry picked from commit 0bc7edc) (cherry-picked to staging by AndrewGable)

OSBotify · 2025-12-16T22:24:18Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-16T22:46:31Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.2.79-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-17T12:24:13Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.2.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mukhrr · 2025-12-17T12:41:36Z

@nlemma @yuwenmemon I am a bit confused here. Now should I create a regression PR that fixes failing issue #77609?!

yuwenmemon · 2025-12-17T19:12:25Z

Addressed your question here: https://expensify.slack.com/archives/C01GTK53T8Q/p1765983210912239?thread_ts=1765635425.854359&cid=C01GTK53T8Q

You can open a new PR that re-introduces your PR with the additional bug fixes on top of it. Thanks again!

OSBotify · 2025-12-18T18:45:42Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T21:09:06Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Add delegate access restriction checks to search page actions

56855aa

melvin-bot bot assigned mukhrr Nov 22, 2025

mukhrr marked this pull request as ready for review November 25, 2025 17:57

mukhrr requested review from a team as code owners November 25, 2025 17:57

melvin-bot bot requested review from DylanDylann and removed request for a team November 25, 2025 17:57

melvin-bot bot requested review from trjExpensify and removed request for a team November 25, 2025 17:57

Merge remote-tracking branch 'origin' into fix/75171

331aeca

mukhrr mentioned this pull request Nov 25, 2025

[Due for payment 2026-01-29] [$500] Copilot with limited access level can perform prohibited actions without warning on Reports #75171

Closed

8 tasks

Merge remote-tracking branch 'origin' into fix/75171

3637b9b

trjExpensify reviewed Nov 26, 2025

View reviewed changes

Merge remote-tracking branch 'origin' into fix/75171

d5faada

mukhrr added 4 commits December 2, 2025 22:07

Merge remote-tracking branch 'origin' into fix/75171

fd29d0d

fix: Prevent delegate users from bulk paying with business bank accou…

8c8c7d7

…nt or elsewhere

fix: Add type guard for value property in bulk pay item check

a23048c

refactor: Convert handleBulkPayItemSelected parameters to object dest…

a005ee6

…ructuring

fix: Reorder imports to follow alphabetical convention

b241932

mukhrr requested a review from DylanDylann December 4, 2025 16:34

DylanDylann approved these changes Dec 8, 2025

View reviewed changes

melvin-bot bot requested a review from Gonals December 8, 2025 09:18

Gonals previously approved these changes Dec 9, 2025

View reviewed changes

mukhrr added 2 commits December 9, 2025 19:32

Merge remote-tracking branch 'origin' into fix/75171

01f11a0

Merge remote-tracking branch 'origin' into fix/75171

94022d4

mukhrr dismissed Gonals’s stale review via 94022d4 December 9, 2025 14:36

Gonals approved these changes Dec 11, 2025

View reviewed changes

Gonals merged commit 306e38f into Expensify:main Dec 11, 2025
31 checks passed

OSBotify mentioned this pull request Dec 12, 2025

Deploy Checklist: New Expensify 2025-12-12 #77578

Closed

nlemma mentioned this pull request Dec 13, 2025

Copilot with limited access can reject expense via the dropdown from Reports>Expenses #77609

Closed

7 tasks

yuwenmemon added a commit that referenced this pull request Dec 15, 2025

Revert "Merge pull request #75821 from mukhrr/fix/75171"

1a52562

This reverts commit 306e38f, reversing changes made to e18b8bb.

yuwenmemon added a commit that referenced this pull request Dec 15, 2025

Revert "Merge pull request #75821 from mukhrr/fix/75171"

59410f7

This reverts commit 306e38f, reversing changes made to e18b8bb.

yuwenmemon mentioned this pull request Dec 15, 2025

[CP Staging] Revert "Merge pull request #75821 from mukhrr/fix/75171" #77690

Merged

51 tasks

yuwenmemon added a commit that referenced this pull request Dec 15, 2025

Merge pull request #77690 from Expensify/revert-pr-75821

0bc7edc

[CP Staging] Revert "Merge pull request #75821 from mukhrr/fix/75171"

OSBotify pushed a commit that referenced this pull request Dec 15, 2025

Merge pull request #77690 from Expensify/revert-pr-75821

56c6d35

[CP Staging] Revert "Merge pull request #75821 from mukhrr/fix/75171" (cherry picked from commit 0bc7edc) (cherry-picked to staging by AndrewGable)

mukhrr mentioned this pull request Dec 24, 2025

Add delegate access restriction checks to approval, payment, reject and hold #78300

Merged

54 tasks

Conversation

mukhrr commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Nov 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Nov 25, 2025

Uh oh!

mukhrr commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

jamesdeanexpensify commented Nov 26, 2025

Uh oh!

DylanDylann commented Nov 28, 2025

Uh oh!

trjExpensify commented Nov 28, 2025

Uh oh!

DylanDylann commented Nov 28, 2025

Uh oh!

mukhrr commented Nov 30, 2025

Uh oh!

DylanDylann commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Dec 1, 2025

Uh oh!

DylanDylann commented Dec 1, 2025

Uh oh!

mukhrr commented Dec 2, 2025

Uh oh!

Gonals commented Dec 9, 2025

Uh oh!

mukhrr commented Dec 9, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 11, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

nlemma commented Dec 13, 2025

Uh oh!

OSBotify commented Dec 16, 2025

Uh oh!

OSBotify commented Dec 16, 2025

Uh oh!

OSBotify commented Dec 17, 2025

Uh oh!

mukhrr commented Dec 17, 2025

Uh oh!

yuwenmemon commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mukhrr commented Nov 22, 2025 •

edited

Loading

codecov bot commented Nov 22, 2025 •

edited by github-actions bot

Loading

mukhrr commented Nov 25, 2025 •

edited

Loading

DylanDylann commented Dec 1, 2025 •

edited

Loading