Skip to content

fix: RHP back button on Success page after deactivating card opens not here page#75847

Closed
daledah wants to merge 4 commits intoExpensify:mainfrom
daledah:fix/75178
Closed

fix: RHP back button on Success page after deactivating card opens not here page#75847
daledah wants to merge 4 commits intoExpensify:mainfrom
daledah:fix/75178

Conversation

@daledah
Copy link
Contributor

@daledah daledah commented Nov 24, 2025

Explanation of Change

fix: RHP back button on Success page after deactivating card opens not here page

Fixed Issues

$ #75178
PROPOSAL: #75178 (comment)

Tests

Precondition:

  • Log in with Expensifail account.
  • User has assigned themselves a physical card.
  • Private details are filled in on Account > Profile.
  • Date of birth must be older than 18 years old in Private details.
  1. Go to workspace chat.
  2. Click Add shipping details.
  3. Click Confirm.
  4. Enter magic code.
  5. After Verify button changes from spinner back to Verify, close the RHP.
  6. Go to Account > Wallet.
  7. Click "Expensify Card" card (this is available by default for all Expensifail accounts).
  8. Click Report card loss or damaged.
  9. Select any reason > Next.
  10. Click Deactivate card.
  11. Enter magic code.
  12. After Success page opens, click RHP back button.
  13. Verify that: RHP back button on Success page will open card details page.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/settings/Wallet/ReportCardLostPage.tsx 0.00% <0.00%> (ø)
... and 6 files with indirect coverage changes

@daledah daledah marked this pull request as ready for review November 24, 2025 16:52
@daledah daledah requested review from a team as code owners November 24, 2025 16:52
@melvin-bot melvin-bot bot requested review from JmillsExpensify and truph01 and removed request for a team and JmillsExpensify November 24, 2025 16:53
@melvin-bot
Copy link

melvin-bot bot commented Nov 24, 2025

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team November 24, 2025 16:53
@daledah
Copy link
Contributor Author

daledah commented Nov 24, 2025

@truph01 we have the PR here, but i have not added the videos yet. Do you know how to have Report card loss or damaged option in the card?

@truph01
Copy link
Contributor

truph01 commented Nov 25, 2025

@truph01 we have the PR here, but i have not added the videos yet. Do you know how to have Report card loss or damaged option in the card?

@daledah I am also unable to get the Report card loss or damaged option.

@lakchote do you know how I can test it?

@truph01
Copy link
Contributor

truph01 commented Nov 25, 2025

After completing the "Get physical card" flow, I sent the magic code but nothing returned by BE from my end:

output.mp4

@lakchote
Copy link
Contributor

@truph01 we have the PR here, but i have not added the videos yet. Do you know how to have Report card loss or damaged option in the card?

@daledah I am also unable to get the Report card loss or damaged option.

@lakchote do you know how I can test it?

The steps should be:

  1. Create an Expensify card in a workspace
  2. Assign a physical card
  3. Go to the Wallet page
  4. Click on the card
  5. Click on the assigned card
  6. Click on the ‘Report physical card loss/damage’

After completing the "Get physical card" flow, I sent the magic code but nothing returned by BE from my end:

In SetPersonalDetailsAndShipExpensifyCards, if you have no cards with state = NOT_ISSUED and bank = EXPENSIFYCARD, the command returns true immediately without setting any response data.
Either no card exists in the correct state, or the card has already been shipped/issued previously.

@truph01
Copy link
Contributor

truph01 commented Nov 28, 2025

Thanks @lakchote.
@daledah Could you try this suggestion?

@daledah
Copy link
Contributor Author

daledah commented Nov 28, 2025

@truph01 I tried these steps but still do not see ‘Report physical card loss/damage’ button

Screenshot 2025-11-28 at 16 05 14

@lakchote
Copy link
Contributor

@truph01 I tried these steps but still do not see ‘Report physical card loss/damage’ button

@daledah do you have a physical Expensify card in a not activated or open state?

@daledah
Copy link
Contributor Author

daledah commented Dec 1, 2025

@daledah do you have a physical Expensify card in a not activated or open state?

@lakchote I don't have any Expensify card in that state. How can I get a card like that?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

@lakchote
Copy link
Contributor

lakchote commented Dec 1, 2025

@daledah @truph01 after checking internally, you cannot test physical cards for testing.

I'm triggering an adhoc build. @joekaufmanexpensify could you please test the steps outlined in the PR and see if it works correctly? 🙏

@github-actions

This comment has been minimized.

@lakchote
Copy link
Contributor

lakchote commented Dec 2, 2025

@daledah @truph01 after checking internally, you cannot test physical cards for testing.

I'm triggering an adhoc build. @joekaufmanexpensify could you please test the steps outlined in the PR and see if it works correctly? 🙏

^ friendly bump @joekaufmanexpensify

@joekaufmanexpensify
Copy link
Contributor

I will test today 👍

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #75847.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
N/A https://75847.pr-testing.expensify.com
N/A Web

👀 View the workflow run that generated this build 👀

@joekaufmanexpensify
Copy link
Contributor

@daledah @truph01 @lakchote I can't get passed this page when I try to sign in on the adhoc build. It happened on the one from a few days ago and the new one I just ran. Are there any updates we need to make to the PR before this can be tested on an adhoc build?

image

@daledah
Copy link
Contributor Author

daledah commented Dec 5, 2025

@joekaufmanexpensify could you please build again?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #75847.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://75847.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@joekaufmanexpensify
Copy link
Contributor

@daledah when i issue a physical card to an account and then go to the workspace chat on the adhoc, I don't see the option to order the card there. I tried testing it with two different cards.

image image

@joekaufmanexpensify
Copy link
Contributor

Some other notes:

  • Is the loading of the success page a bit odd/stilted?
  • The < button the success page did not work the first time, I had to two it twice. (I tested replacing a card twice and this happened both times).
2025-12-05_16-43-38.mp4

@lakchote
Copy link
Contributor

lakchote commented Dec 9, 2025

cc @daledah can you please check @joekaufmanexpensify's comment above? Thanks!

@joekaufmanexpensify
Copy link
Contributor

Bump @daledah

@daledah
Copy link
Contributor Author

daledah commented Dec 13, 2025

Sorry for the delay. I'll give an update soon

@daledah
Copy link
Contributor Author

daledah commented Dec 13, 2025

@daledah when i issue a physical card to an account and then go to the workspace chat on the adhoc, I don't see the option to order the card there. I tried testing it with two different cards.

It looks like out of scope of this PR cc @truph01

@joekaufmanexpensify
Copy link
Contributor

It looks like out of scope of this PR cc @truph01

Are you able to reproduce? When I tested on staging it's working there.

@joekaufmanexpensify
Copy link
Contributor

LMK your thoughts on the other points too 👍

@daledah
Copy link
Contributor Author

daledah commented Dec 22, 2025

We don't have back button on Success page, so i'll close this PR and create a new one to show the back button as this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants