fix: RHP back button on Success page after deactivating card opens not here page#75847
fix: RHP back button on Success page after deactivating card opens not here page#75847daledah wants to merge 4 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@truph01 we have the PR here, but i have not added the videos yet. Do you know how to have |
|
After completing the "Get physical card" flow, I sent the magic code but nothing returned by BE from my end: output.mp4 |
The steps should be:
In |
|
Thanks @lakchote. |
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
@daledah @truph01 after checking internally, you cannot test physical cards for testing. I'm triggering an adhoc build. @joekaufmanexpensify could you please test the steps outlined in the PR and see if it works correctly? 🙏 |
This comment has been minimized.
This comment has been minimized.
^ friendly bump @joekaufmanexpensify |
|
I will test today 👍 |
|
🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@joekaufmanexpensify could you please build again? |
|
🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@daledah when i issue a physical card to an account and then go to the workspace chat on the adhoc, I don't see the option to order the card there. I tried testing it with two different cards.
|
|
Some other notes:
2025-12-05_16-43-38.mp4 |
|
cc @daledah can you please check @joekaufmanexpensify's comment above? Thanks! |
|
Bump @daledah |
|
Sorry for the delay. I'll give an update soon |
Are you able to reproduce? When I tested on staging it's working there. |
|
LMK your thoughts on the other points too 👍 |
|
We don't have back button on Success page, so i'll close this PR and create a new one to show the back button as this comment |




Explanation of Change
fix: RHP back button on Success page after deactivating card opens not here page
Fixed Issues
$ #75178
PROPOSAL: #75178 (comment)
Tests
Precondition:
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop