Bring overLimitForwardsTo configuration into New Expensify

[abzokhattab]

Explanation of Change

Fixed Issues

$ #75775
PROPOSAL:

Tests

Test 1: Setting Approval Limit on an Approver (Create Flow)

Precondition: Workspace with "Add approvals" enabled

1. Go to Workspace > Workflows
2. Click to create a new approval workflow
3. Add members to "Expenses from"
4. Select an approver
5. Verify the approval limit page shows with Skip and Next buttons
6. Click Skip
7. Verify you return to the workflow editor without a limit set
8. Click on the approver again
9. Enter a report amount (e.g., $500)
10. Leave the additional approver empty
11. Click Next
12. Verify you return to the workflow editor without a limit config set
13. Clear the report amount
14. Select an additional approver from the list
15. Click Next
16. Verify error "Please enter a valid amount" is shown
17. Enter a report amount (e.g., $500)
18. Click Next
19. Verify the workflow shows the limit description (e.g., "Reports above $500 forward to [Name]")
20. Save the workflow
21. Verify workflow is created successfully

Test 2: Editing Approval Limit on an Approver (Edit Flow)

Precondition: Workspace with "Add approvals" enabled, with an existing approval workflow that has an approval limit set

1. Go to Workspace > Workflows
2. Click on an existing approval workflow with an approval limit
3. Click on the approver with the limit
4. Verify the amount field shows the existing limit
5. Verify the additional approver is pre-selected
6. Clear the report amount
7. Click Save
8. Verify error "Please enter a valid amount" is shown
9. Enter a new report amount (e.g., $1000)
10. Select a different additional approver
11. Click Save
12. Verify the new limit description shows correctly
13. Click on the same approver again
14. Click Remove limit
15. Verify you return to the workflow editor
16. Verify the limit description is no longer shown
17. Save the workflow
18. Verify workflow updates successfully without the approval limit

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-05.at.19.22.42.mov

Screen.Recording.2025-12-05.at.19.28.12.mov

Android: mWeb Chrome

Screen.Recording.2025-12-05.at.19.27.19.mov

iOS: Native

Screen.Recording.2025-12-05.at.19.08.59.mov

Screen.Recording.2025-12-05.at.19.09.37.mov

iOS: mWeb Safari

Screen.Recording.2025-12-05.at.19.12.31.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-05.at.19.05.15.mov

Screen.Recording.2025-12-05.at.19.06.00.mov

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[melvin-bot]

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/SCREENS.ts	100.00% <ø> (ø)
...rc/components/Icon/chunks/expensify-icons.chunk.ts	0.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	75.00% <ø> (ø)
src/libs/WorkflowUtils.ts	85.41% <100.00%> (+1.67%)	⬆️
src/pages/workspace/withPolicy.tsx	100.00% <ø> (ø)
...ges/workspace/workflows/WorkspaceWorkflowsPage.tsx	0.00% <ø> (ø)
src/styles/index.ts	47.48% <ø> (ø)
src/components/AmountForm.tsx	0.00% <0.00%> (ø)
...ls/WorkspaceWorkflowsApprovalsExpensesFromPage.tsx	0.00% <0.00%> (ø)
... and 11 more
... and 81 files with indirect coverage changes

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[dubielzyk-expensify]

There's new pattern of amount input being disabled

That looks right to me and how we style disabled input fields from what I'm aware. Or am I missing something? @dannymcclain

[aimane-chnaif]

Looks good except this blocker

[abzokhattab]

Auto-focus on Report amount

i am fine with enabling it but should we enabled it in both cases create and edit ? .. fyi the amount is displayed as the second field in the edit not the first so idk if we should focus in this case ... wdyt @aimane-chnaif

[abzokhattab]

also i fixed this issue please let me know if u still have this problem #76032 (review)

[JmillsExpensify]

Let's try to get this over the line today or Monday! It feels really close.

[aimane-chnaif]

Auto-focus on Report amount

i am fine with enabling it but should we enabled it in both cases create and edit ? .. fyi the amount is displayed as the second field in the edit not the first so idk if we should focus in this case ... wdyt @aimane-chnaif

Let's skip this for now as minor. If QA reports this, we can fix as follow-up.

[aimane-chnaif]

Any way to optimize this?

[abzokhattab]

Mmmm will check but let me know if y have other suggestions

[abzokhattab]

Overall i think it's doesnt cause a performance degradation so for me i believe its fine to proceed with that

[aimane-chnaif]

This effect still has issues. #78353 #78330

Extra 0 is added when change currency to VND

Screen.Recording.2025-12-23.at.12.14.37.pm.mov

Double negative

Screen.Recording.2025-12-23.at.12.22.17.pm.mov

[JS00001]

Lets do it, great work @abzokhattab @aimane-chnaif

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.2.86-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

[aimane-chnaif]

@abzokhattab please check linked blockers above

[abzokhattab]

Looking

[OSBotify]

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅