Skip to content

Add Rotate button to receipt modal#76037

Merged
NikkiWines merged 22 commits intoExpensify:mainfrom
nkdengineer:fix/75435
Dec 16, 2025
Merged

Add Rotate button to receipt modal#76037
NikkiWines merged 22 commits intoExpensify:mainfrom
nkdengineer:fix/75435

Conversation

@nkdengineer
Copy link
Contributor

@nkdengineer nkdengineer commented Nov 25, 2025 •
edited
Loading

Explanation of Change

Add Rotate button to receipt modal

Fixed Issues

$ #75435
PROPOSAL: #75435 (comment)

Tests

  • Create expense flow
  1. Go FAB > Scan
  2. Take a picture or upload a picture
  3. Click on the receipt thumbnail
  4. Click on the rotate icon
  5. Verify that the image is rotated 90 degrees, and it's saved automatically
  • Edit receipt flow
  1. Create an expense with a receipt
  2. Open expense detail and click on the receipt thumbnail
  3. Click on the rotate icon
  4. Verify that the image is rotated 90 degrees, and it's saved automatically
  • Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Same as test

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2025-11-25.at.22.37.56.mov
Screen.Recording.2025-12-02.at.22.57.08.mov
Android: mWeb Chrome
Screen.Recording.2025-12-02.at.23.03.00.mov
iOS: Native
Screen.Recording.2025-11-25.at.22.40.27.mov
Screen.Recording.2025-12-02.at.22.58.23.mov
iOS: mWeb Safari
Screen.Recording.2025-11-25.at.22.39.43.mov
MacOS: Chrome / Safari
Screen.Recording.2025-11-25.at.22.34.43.mov
Screen.Recording.2025-12-02.at.22.56.25.mov

@codecov
Copy link

codecov bot commented Nov 25, 2025 •
edited by github-actions bot
Loading

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...ntModalScreen/AttachmentModalBaseContent/index.tsx 88.37% <100.00%> (+0.27%) ⬆️
src/components/HeaderWithBackButton/index.tsx 89.15% <71.42%> (-1.76%) ⬇️
src/libs/fetchImage/index.ts 0.00% <0.00%> (ø)
src/libs/fetchImage/index.native.ts 0.00% <0.00%> (ø)
...alScreen/routes/TransactionReceiptModalContent.tsx 0.73% <0.00%> (-0.38%) ⬇️
... and 10 files with indirect coverage changes

@nkdengineer
Copy link
Contributor Author

nkdengineer commented Nov 25, 2025

@aimane-chnaif I'm finding the way to rotate when editing the receipt since the image from this case is from the server.

@nkdengineer nkdengineer marked this pull request as ready for review December 2, 2025 16:17
@nkdengineer nkdengineer requested review from a team as code owners December 2, 2025 16:18
@melvin-bot melvin-bot bot requested review from a team, aimane-chnaif and joekaufmanexpensify and removed request for a team December 2, 2025 16:18
@melvin-bot
Copy link

melvin-bot bot commented Dec 2, 2025

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from NikkiWines and removed request for a team December 2, 2025 16:18
@melvin-bot
Copy link

melvin-bot bot commented Dec 2, 2025

@NikkiWines Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team December 2, 2025 16:18
aimane-chnaif
aimane-chnaif reviewed Dec 2, 2025
View reviewed changes
src/libs/fetchImage/index.native.ts Outdated
export default function fetchImage(source: string, authToken: string) {
// Create a unique filename based on timestamp
const timestamp = Date.now();
const extension = source.split('.').pop()?.split('?')?.at(0) ?? 'jpg';
Copy link
Contributor

@aimane-chnaif aimane-chnaif Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe extracting extension from file name is somewhere in this repo or expensify-common.

Copy link
Contributor Author

@nkdengineer nkdengineer Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aimane-chnaif I updated.

@aimane-chnaif
Copy link
Contributor

aimane-chnaif commented Dec 2, 2025

I tested on approved expense.
Unapprove and upload receipt.
Rotate button disappears after getting response from backend:

Screen.Recording.2025-12-02.at.5.50.59.pm.mov

joekaufmanexpensify
joekaufmanexpensify previously approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@joekaufmanexpensify joekaufmanexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited for this!

@nkdengineer
Copy link
Contributor Author

nkdengineer commented Dec 3, 2025 •
edited
Loading

Rotate button disappears after getting response from backend:

@aimane-chnaif After calling replaceReceipt, the backend returns the receipt.state as SCANREADY, which causes both replace and rotate buttons disappear.

@aimane-chnaif
Copy link
Contributor

aimane-chnaif commented Dec 16, 2025

@nkdengineer conflicts

aimane-chnaif
aimane-chnaif reviewed Dec 16, 2025
View reviewed changes
NikkiWines
NikkiWines approved these changes Dec 16, 2025
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@NikkiWines NikkiWines merged commit c2fd55d into Expensify:main Dec 16, 2025
32 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Dec 16, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Dec 16, 2025
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Dec 16, 2025

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.79-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

This was referenced Dec 17, 2025
Closed
Closed
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Dec 17, 2025

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.81-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

NikkiWines added a commit that referenced this pull request Dec 17, 2025
@NikkiWines
Revert "Merge pull request #76037 from nkdengineer/fix/75435"
0ca6a4d 
This reverts commit c2fd55d, reversing
changes made to 2ecde62.
yuwenmemon added a commit that referenced this pull request Dec 17, 2025
@yuwenmemon
Merge pull request #77941 from Expensify/nikkiwines-revert-76037
8c74251 
Revert "Merge pull request #76037 from nkdengineer/fix/75435"
@NikkiWines NikkiWines mentioned this pull request Dec 17, 2025
Merged
53 tasks
OSBotify pushed a commit that referenced this pull request Dec 17, 2025
@yuwenmemon @OSBotify
Merge pull request #77941 from Expensify/nikkiwines-revert-76037
abee4a1 
Revert "Merge pull request #76037 from nkdengineer/fix/75435"

(cherry picked from commit 8c74251)

(cherry-picked to staging by yuwenmemon)
nkdengineer added a commit to nkdengineer/App that referenced this pull request Dec 18, 2025
@nkdengineer
Revert "Revert "Merge pull request Expensify#76037 from nkdengineer/f…
d8dba14 
…ix/75435""
@OSBotify
Copy link
Contributor

OSBotify commented Dec 18, 2025

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 18, 2025

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.82-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 18, 2025

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.82-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 18, 2025

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 18, 2025

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.82-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 19, 2025

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.84-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 19, 2025

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@melvin-bot melvin-bot bot mentioned this pull request Dec 19, 2025
Closed
8 tasks
@OSBotify OSBotify mentioned this pull request Dec 23, 2025
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Dec 23, 2025

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.86-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 24, 2025

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@NikkiWines NikkiWines NikkiWines approved these changes

@joekaufmanexpensify joekaufmanexpensify joekaufmanexpensify left review comments

+1 more reviewer

@aimane-chnaif aimane-chnaif aimane-chnaif approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nkdengineer nkdengineer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@nkdengineer @aimane-chnaif @dubielzyk-expensify @trjExpensify @dannymcclain @JmillsExpensify @OSBotify @NikkiWines @joekaufmanexpensify