Dismiss keyboard when transitioning to ResendValidationForm page#7604
Merged
luacmartins merged 1 commit intomainfrom Feb 7, 2022
Merged
Dismiss keyboard when transitioning to ResendValidationForm page#7604luacmartins merged 1 commit intomainfrom
luacmartins merged 1 commit intomainfrom
Conversation
AndrewGable
approved these changes
Feb 7, 2022
Contributor
Author
|
Self-merging with approval! |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
49 tasks
Contributor
|
🚀 Deployed to staging by @luacmartins in version: 1.1.38-0 🚀
|
Contributor
|
🚀 Deployed to production by @Julesssss in version: 1.1.38-3 🚀
|
Member
|
Hi, just dropping a note that this PR introduced a bug - #13044 (comment) The keyboard should close only when transitioning to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Dismisses the keyboard when transitioning to
ResendValidationFormpage.Note: mobile Safari seems to behave differently as inputs are not focused on render and because of that, I did not include testing for mWeb.
Fixed Issues
$ #7199
Tests
Continue.Go backResendValidationFormpage.QA Steps
Steps above.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
ios.mov
Android
android.mov