-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat: Allow linking to oldest unread report action page in usePaginatedReportActions hook
#76101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow linking to oldest unread report action page in usePaginatedReportActions hook
#76101
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@chrispader @ishpaul777 should I review this PR? |
i think @ishpaul777 will review, as he already has context on the issue |
|
yes i'll review this. @dukenv0307 please ignore this one |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-12-03.at.4.46.37.AM.movAndroid: mWeb ChromeScreen.Recording.2025-12-03.at.4.13.06.AM.moviOS: HybridAppiOS: mWeb SafariScreen.Recording.2025-12-03.at.4.11.41.AM.movMacOS: Chrome / SafariScreen.Recording.2025-11-28.at.4.41.02.AM.movScreen.Recording.2025-11-28.at.4.35.14.AM.mov |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes approved by product
rlinoz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.71-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.71-5 🚀
|
@rlinoz @ishpaul777
Explanation of Change
This PR adds an optional
shouldLinkToOldestUnreadReportActionflag, which enables finding the page from store which includes the oldest unread report action, if no otherreportActionIDis provided.Unless used from within #51366, this PR does not change should not change any current behavior.
Fixed Issues
$ #35011
PROPOSAL:
Tests
Test same report pagination functionality as before
reportActions_andreportActionsPages_Onyx keys for a given reportGetNewerActions/GetOlderActionsAPI callsThe functionality of this PR has to be tested as part of #51366. Merge this PR into #51366 and test for unread message comment linking.
Offline tests
None needed.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as in Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari