fix: Report- "Uncategorized" chip not highlighted in search field. by Rkdev09 · Pull Request #76127 · Expensify/App

Rkdev09 · 2025-11-26T13:07:05Z

Explanation of Change

Fixed Issues

$ #75311
PROPOSAL: #75311 (comment)

Tests

Pre-condition: There are some expenses in the workspace created without any category.

Steps:

Go to https://staging.new.expensify.com/home and log in
Open Reports - Expenses
In the search field, type category:Uncategorized
Select "category:Uncategorized" from the suggestions and press Enter
Verify "Uncategorized" chip is highlighted.
Repeat the same steps with "none" category

Verify that no errors appear in the JS console

Offline tests

Pre-condition: There are some expenses in the workspace created without any category.

Steps:

Go to https://staging.new.expensify.com/home and log in
Open Reports - Expenses
In the search field, type category:Uncategorized
Select "category:Uncategorized" from the suggestions and press Enter
Verify "Uncategorized" chip is highlighted.
Repeat the same steps with "none" category

QA Steps

Same as tests
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-app.mov

Android: mWeb Chrome

android-browser.mov

iOS: Native

ios-app-og.mp4

iOS: mWeb Safari

ios-app.mp4

MacOS: Chrome / Safari

REC-20251126184624.mp4

Signed-off-by: Rkmishra09 <ritikamishra5822@gmail.com>

melvin-bot · 2025-11-26T13:45:17Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2025-11-28T07:45:33Z

src/libs/SearchQueryUtils.ts

+            // Consider the empty category selected if ANY of its synonyms are present (e.g., "none" OR "Uncategorized")
+            const filterValuesLower = new Set(filterValues.map((v) => v.toLowerCase()));
+            const hasEmptyCategoriesInFilter = emptyCategories.some((category) => filterValuesLower.has(category.toLowerCase()));
+            // If an empty category synonym is found, append CATEGORY_EMPTY_VALUE to filtersForm so the chip appears selected.


Revert this comment change.

@Krishna2323 updated the comment.

Signed-off-by: Rkmishra09 <ritikamishra5822@gmail.com>

Krishna2323 · 2025-11-28T11:45:16Z

src/libs/SearchAutocompleteUtils.ts

            return actionList.includes(range.value);
        case CONST.SEARCH.SYNTAX_FILTER_KEYS.CATEGORY:
-            return categoryList.get().includes(range.value);
+            // Highlight if value is a known category OR one of the empty-category synonyms (e.g., "none", "Uncategorized")


Update this to Treat the empty category as selected if any of its synonyms (e.g., "none", "uncategorized") appear in filterValues.

Krishna2323 · 2025-11-28T11:51:14Z

src/libs/SearchQueryUtils.ts

            const emptyCategories = CONST.SEARCH.CATEGORY_EMPTY_VALUE.split(',');
-            const hasEmptyCategoriesInFilter = emptyCategories.every((category) => filterValues.includes(category));
-            // We split CATEGORY_EMPTY_VALUE into individual values to detect both are present in filterValues.
+            // Consider the empty category selected if ANY of its synonyms are present (e.g., "none" OR "Uncategorized")


Update to Return true if the value is a known category or one of the empty-category synonyms (e.g., 'none', 'uncategorized').

Krishna2323 · 2025-11-28T12:17:16Z

@chiragsalian we have one more bug: when the suggestions list contains "category:Uncategorized" and we start typing "category:Un", the "category:Uncategorized" option gets filtered out. This doesn’t happen with other options. This isn’t in the scope of this issue and definitely has a different RCA. Should we fix it in this PR since it’s strongly related to the flow we’re fixing here?

@Rkdev09 can look into the RCA, post it here, and we can apply the fix.

Monosnap.screencast.2025-11-28.17-40-34.mp4

Rkdev09 · 2025-11-30T14:15:59Z

Yes @Krishna2323 I also noticed that and I can look into it if asked to.

Krishna2323 · 2025-12-01T14:16:03Z

@chiragsalian friendly bump to check this comment.

JmillsExpensify

I'm good with the changes in this PR, though I'm going to create a separate internal convo about how we best handle the "no category" search operator versus a search operator for someone looking to search for '"Uncategorized"`

chiragsalian · 2025-12-01T19:12:48Z

This isn’t in the scope of this issue and definitely has a different RCA. Should we fix it in this PR since it’s strongly related to the flow we’re fixing here?

Yeah since its not in the scope of this issue and is a bug that exists on main, I would prefer we tackle it in a separate issue.

codecov · 2025-12-01T19:22:30Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/SearchQueryUtils.ts	`70.57% <100.00%> (+0.04%)`	⬆️
src/libs/SearchAutocompleteUtils.ts	`51.07% <0.00%> (ø)`
... and 10 files with indirect coverage changes

Krishna2323 · 2025-12-02T14:57:34Z

@Rkdev09 could you please merge main? Thanks!

Krishna2323 · 2025-12-03T14:47:31Z

The failing ESLint check is on main.

Krishna2323 · 2025-12-03T14:48:22Z

@Rkdev09 I think you forgot to address these comment.

Krishna2323 · 2025-12-03T21:55:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: HybridApp

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

Krishna2323 · 2025-12-03T21:56:41Z

@Rkdev09 also include 5th testing step: Verify "uncategorized" chip is highlighted. Let me know once you update this and handle all the comments.

github-actions · 2025-12-05T13:54:47Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Rkdev09 · 2025-12-05T13:56:33Z

I have read the CLA Document and I hereby sign the CLA

Rkdev09 · 2025-12-05T13:56:47Z

recheck

Signed-off-by: Ritika mishra <ritikamishra5822@gmail.com>

Rkdev09 · 2025-12-05T14:12:51Z

@Krishna2323 I have updated the branch, tests and comments. Thanks!

Krishna2323

LGTM! 🚀

chiragsalian

LGTM, can you address the new merge conflicts.

Rkdev09 · 2025-12-10T12:26:33Z

@chiragsalian the issue is fixed in #76840, I think we can close the PR.

fix: Report- "Uncategorized" chip not highlighted in search field.

7f6995e

Signed-off-by: Rkmishra09 <ritikamishra5822@gmail.com>

melvin-bot bot assigned Rkdev09 Nov 26, 2025

Rkdev09 marked this pull request as ready for review November 26, 2025 13:45

Rkdev09 requested review from a team as code owners November 26, 2025 13:45

melvin-bot bot requested review from Krishna2323 and removed request for a team November 26, 2025 13:45

melvin-bot bot requested review from JmillsExpensify and removed request for a team November 26, 2025 13:45

Rkdev09 mentioned this pull request Nov 26, 2025

[$250] Report- "Uncategorized" chip not highlighted in search field #75311

Closed

8 tasks

Krishna2323 suggested changes Nov 28, 2025

View reviewed changes

comment update.

bf13dcb

Signed-off-by: Rkmishra09 <ritikamishra5822@gmail.com>

Krishna2323 suggested changes Nov 28, 2025

View reviewed changes

JmillsExpensify reviewed Dec 1, 2025

View reviewed changes

Rkdev09 added 2 commits December 2, 2025 20:44

Merge branch 'Expensify:main' into fix-uncategorized-chip

ad10fcd

Merge branch 'Expensify:main' into fix-uncategorized-chip

6e80854

Rkdev09 force-pushed the fix-uncategorized-chip branch from 4e787ef to 6e80854 Compare December 5, 2025 14:03

Rkdev09 added 2 commits December 5, 2025 19:37

update comments.

20e56c7

Signed-off-by: Ritika mishra <ritikamishra5822@gmail.com>

Merge branch 'Expensify:main' into fix-uncategorized-chip

3f71346

Merge branch 'Expensify:main' into fix-uncategorized-chip

e6ebb8f

Krishna2323 approved these changes Dec 7, 2025

View reviewed changes

melvin-bot bot requested a review from chiragsalian December 7, 2025 13:20

chiragsalian approved these changes Dec 9, 2025

View reviewed changes

chiragsalian closed this Dec 10, 2025

Conversation

Rkdev09 commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 26, 2025

Uh oh!

Krishna2323 Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Rkdev09 Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Nov 28, 2025

Uh oh!

Rkdev09 commented Nov 30, 2025

Uh oh!

Krishna2323 commented Dec 1, 2025

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

chiragsalian commented Dec 1, 2025

Uh oh!

codecov bot commented Dec 1, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Krishna2323 commented Dec 2, 2025

Uh oh!

Krishna2323 commented Dec 3, 2025

Uh oh!

Krishna2323 commented Dec 3, 2025

Uh oh!

Krishna2323 commented Dec 3, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rkdev09 commented Dec 5, 2025

Uh oh!

Rkdev09 commented Dec 5, 2025

Uh oh!

Rkdev09 commented Dec 5, 2025

Uh oh!

Krishna2323 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chiragsalian left a comment

Choose a reason for hiding this comment

Uh oh!

Rkdev09 commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Rkdev09 commented Nov 26, 2025 •

edited

Loading

codecov bot commented Dec 1, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading

Krishna2323 left a comment •

edited

Loading