Remove `deprecatedCurrentUserAccountID` in `src/libs/TransactionUtils/index.ts` by rayane-d · Pull Request #76171 · Expensify/App

rayane-d · 2025-11-26T19:43:00Z

Explanation of Change

This is a follow-up to this PR: #74738
See this discussion: #74738 (comment)

Fixed Issues

$ #73098
Part of #73098 See this discussion in this PR: #74738 (comment)
Part of #66467

PROPOSAL:

Tests

Same as tests in this PR: #74738

Download and import this onyx state:
https://github.com/user-attachments/files/23855166/onyx-state.11.txt
Run this in the browser console to add missing comment data to the transaction and to correct the violation name:

Onyx.merge('transactions_8142574694853799211', {
  "comment": {
    "attendees": [
      {
        "avatarUrl": "https://d1wpcgnaa73g0y.cloudfront.net/b99046a36bab1955c1669e891375a845d544a4fb_128.jpeg",
        "displayName": "Jasper Huang",
        "email": "jasper@expensify.com"
      }
    ],
    "comment": "***",
    "dismissedViolations": {
      "rter": {
        "jasper@expensify.com": 1760643377364493
      }
    }
  }
});
  
  
Onyx.set(`transactionViolations_8142574694853799211`, [{
      "data": {
          "rterType": "brokenCardConnection",
          "tooltip": "Personal Cards: Fix your card from Account Settings. Corporate Cards: ask your Expensify admin to fix your company's card connection."
      },
      "name": "rter",
      "showInReview": true,
      "type": "warning"
}]);

Open the policy expense chat (report #96832091)
Verify that the report preview action shows an "Approve" button
Open the expense report (#1814181775632892)
Verify that the primary action button is "Approve"
Verify that there is no empty report next step message

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…dex.ts

codecov · 2025-11-26T19:52:02Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...ReportPreview/MoneyRequestReportPreviewContent.tsx	`61.72% <100.00%> (ø)`
...m/TransactionPreview/TransactionPreviewContent.tsx	`76.59% <ø> (ø)`
...thSections/Search/TransactionGroupListExpanded.tsx	`57.47% <100.00%> (ø)`
src/hooks/useSearchTypeMenuSections.ts	`87.09% <100.00%> (+0.88%)`	⬆️
src/hooks/useTransactionViolations.ts	`100.00% <100.00%> (ø)`
src/libs/NextStepUtils.ts	`64.01% <100.00%> (-0.83%)`	⬇️
src/libs/ReportPrimaryActionUtils.ts	`89.16% <100.00%> (ø)`
src/libs/ReportSecondaryActionUtils.ts	`90.73% <100.00%> (ø)`
src/libs/ReportUtils.ts	`75.19% <100.00%> (+0.01%)`	⬆️
src/libs/SearchUIUtils.ts	`73.03% <100.00%> (+0.14%)`	⬆️
... and 24 more
... and 7 files with indirect coverage changes

…dex.ts

melvin-bot · 2025-11-26T21:41:53Z

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-d · 2025-11-26T21:43:35Z

@DylanDylann @Krishna2323 @shubham1206agra Could one of you please complete the checklist?

src/components/SelectionListWithSections/Search/TransactionListItem.tsx

Krishna2323 · 2025-11-26T21:47:01Z

@rayane-d I will review and complete the checklist tomorrow. If it's urgent then anyone else can work on this.

rayane-d · 2025-12-01T11:34:35Z

Updated

mountiny · 2025-12-01T12:53:28Z

Can you merge main

mountiny · 2025-12-01T13:33:24Z

Can you please complete the review now @Krishna2323 thanks

Krishna2323 · 2025-12-01T14:07:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Monosnap.screencast.2025-12-01.19-35-23.mp4

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Krishna2323 · 2025-12-01T14:08:37Z

onyx-state (11).txt

@rayane-d could you please add the onyx state in the QA test section? Thanks!

rayane-d · 2025-12-01T14:12:00Z

onyx-state (11).txt

@rayane-d could you please add the onyx state in the QA test section? Thanks!

Done!

Krishna2323

Looks good to me! 🚀

melvin-bot · 2025-12-01T14:12:42Z

🎯 @Krishna2323, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #76401.

mountiny

Only one NAB raised

mountiny · 2025-12-01T17:02:59Z

src/libs/ReportUtils.ts

-            (hasViolations(potentialReport.reportID, transactionViolations, true, transactions, currentUserEmail, potentialReport, policy) ||
-                hasWarningTypeViolations(potentialReport.reportID, transactionViolations, true, transactions, currentUserEmail, potentialReport, policy) ||
-                hasNoticeTypeViolations(potentialReport.reportID, transactionViolations, true, transactions, currentUserEmail, potentialReport, policy))
+            ViolationsUtils.hasVisibleViolationsForUser(


It would be more readable to create variables before the return so its not all glued together in this long return

OSBotify · 2025-12-01T17:30:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-01T23:45:05Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.67-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2025-12-02T11:28:19Z

@rayane-d QA team failed this PR with an original issue

1764665920160.onyx.mp4

rayane-d · 2025-12-02T15:28:44Z

Hmm, that's strange. The PR was testing fine before we merged it - could this be due to another PR from the checklist? looking

rayane-d · 2025-12-02T16:14:11Z

@IuliiaHerets - it looks like you need to make sure the Onyx state was fully imported. Before testing, confirm that the account ID is set to 1:

If the Onyx state wasn't fully imported, you'll need to import it again.

Screen.Recording.2025-12-02.at.5.10.33.PM.mov

kavimuru · 2025-12-02T20:28:35Z

@rayane-d failing with original bug id #73098

https://platform.applause.com/services/links/v1/external/b07e3a9cf76bd89331e2ba8129abdfe9c028122d7f622c4778d8bcb115cd8293

rayane-d · 2025-12-02T20:32:19Z

@kavimuru - did you try importing the Onyx state two times to ensure that it is fully imported? What's the accountID on the settings page?

OSBotify · 2025-12-03T13:57:46Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-03T14:53:11Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

remove deprecatedCurrentUserAccountID in src/libs/TransactionUtils/in…

c89da4e

…dex.ts

melvin-bot bot assigned rayane-d Nov 26, 2025

rayane-d mentioned this pull request Nov 26, 2025

Fix approve button not shown because of invisible broken card connection violation #74738

Merged

54 tasks

rayane-d added 5 commits November 26, 2025 22:17

Remove deprecatedCurrentUserAccountID in src/libs/TransactionUtils/in…

d18cfcb

…dex.ts

Merge branch 'Expensify:main' into deprecatedCurrentUserAccountID

a070edf

prettier

15a1749

Remove deprecatedCurrentUserAccountID in src/libs/TransactionUtils/in…

41ebe4d

…dex.ts

fix lint

72a32ec

rayane-d changed the title ~~Remove deprecatedCurrentUserAccountID in src/libs/TransactionUtils/index.ts~~ [No QA] Remove deprecatedCurrentUserAccountID in src/libs/TransactionUtils/index.ts Nov 26, 2025

rayane-d changed the title ~~[No QA] Remove deprecatedCurrentUserAccountID in src/libs/TransactionUtils/index.ts~~ [No QA] Remove deprecatedCurrentUserAccountID in src/libs/TransactionUtils/index.ts Nov 26, 2025

rayane-d changed the title ~~[No QA] Remove deprecatedCurrentUserAccountID in src/libs/TransactionUtils/index.ts~~ [No QA] Remove deprecatedCurrentUserAccountID in src/libs/TransactionUtils/index.ts Nov 26, 2025

rayane-d requested review from DylanDylann, Krishna2323, mountiny and shubham1206agra November 26, 2025 21:35

rayane-d marked this pull request as ready for review November 26, 2025 21:41

rayane-d requested review from a team as code owners November 26, 2025 21:41

melvin-bot bot requested review from trjExpensify and youssef-lr and removed request for a team November 26, 2025 21:41

rayane-d removed the request for review from youssef-lr November 26, 2025 21:42

github-actions bot reviewed Nov 26, 2025

View reviewed changes

src/components/SelectionListWithSections/Search/TransactionListItem.tsx Outdated Show resolved Hide resolved

fix lint errors

a8662f6

fix lint warnings

43fa7ce

rayane-d added 2 commits December 1, 2025 12:29

Address review comments

dd8616c

Merge branch 'Expensify:main' into deprecatedCurrentUserAccountID

0675069

rayane-d marked this pull request as draft December 1, 2025 11:37

rayane-d marked this pull request as ready for review December 1, 2025 11:37

rayane-d added 2 commits December 1, 2025 13:11

fix lint

e8f8ddc

Merge branch 'Expensify:main' into deprecatedCurrentUserAccountID

63ca173

Merge branch 'Expensify:main' into deprecatedCurrentUserAccountID

8ecc2ab

Krishna2323 approved these changes Dec 1, 2025

View reviewed changes

melvin-bot bot mentioned this pull request Dec 1, 2025

Payment issue for E/App PR#76171 #76401

Closed

mountiny approved these changes Dec 1, 2025

View reviewed changes

mountiny merged commit 61b01d5 into Expensify:main Dec 1, 2025
34 checks passed

rayane-d deleted the deprecatedCurrentUserAccountID branch December 1, 2025 17:05

OSBotify mentioned this pull request Dec 1, 2025

Deploy Checklist: New Expensify 2025-12-01 #76460

Closed

nabi-ebrahimi mentioned this pull request Dec 2, 2025

Fix: Approver Field Disappearing and “Expense From” Expanding When Approver Is Removed #75646

Merged

54 tasks

Conversation

rayane-d commented Nov 26, 2025 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Nov 26, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Nov 26, 2025

Uh oh!

rayane-d commented Nov 26, 2025

Uh oh!

Uh oh!

Krishna2323 commented Nov 26, 2025

Uh oh!

rayane-d commented Dec 1, 2025

Uh oh!

mountiny commented Dec 1, 2025

Uh oh!

mountiny commented Dec 1, 2025

Uh oh!

Krishna2323 commented Dec 1, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Dec 1, 2025

Uh oh!

rayane-d commented Dec 1, 2025

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Dec 1, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 1, 2025

Uh oh!

OSBotify commented Dec 1, 2025

Uh oh!

IuliiaHerets commented Dec 2, 2025

Uh oh!

rayane-d commented Dec 2, 2025

Uh oh!

rayane-d commented Dec 2, 2025

Uh oh!

kavimuru commented Dec 2, 2025

Uh oh!

rayane-d commented Dec 2, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

rayane-d commented Nov 26, 2025 •

edited by mountiny

Loading

codecov bot commented Nov 26, 2025 •

edited by github-actions bot

Loading