fix: thread header is not showing the exact message sent v3 by nkdengineer · Pull Request #76209 · Expensify/App

nkdengineer · 2025-11-27T07:19:38Z

Explanation of Change

Fixed Issues

$ #71434
#73092
#75942
PROPOSAL: #71434 (comment)

Tests

Open a chat
Send a message <div>test<div>
Long press and open reply thread
Note thread header
Verify that: Thread header must show the exact message sent.

[$250] LHN - "personal space" link is displayed with HTML tags in LHN #75942

Go to workspace chat.
Create an expense.
Open the transaction thread.
Click Report.
Click Remove from report.
Go to self DM.
Open the unreported expense.
Right click on "moved this expense to your personal space" system message.
Click Reply in thread.
Verify that the report name in LHN doesn't display the HTML tag.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…ent""

codecov · 2025-11-27T07:27:41Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/DisplayNames/index.native.tsx	`100.00% <100.00%> (+11.11%)`	⬆️
src/components/LHNOptionsList/OptionRowLHN.tsx	`95.65% <ø> (ø)`
src/components/MenuItem.tsx	`86.66% <ø> (ø)`
src/pages/home/HeaderView.tsx	`81.69% <100.00%> (+0.12%)`	⬆️
src/components/DisplayNames/index.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

melvin-bot · 2025-11-27T15:14:17Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-12-01T17:08:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

ZhenjaHorbach · 2025-12-02T11:20:47Z

Does this fix really work?

nkdengineer · 2025-12-02T11:51:34Z

@ZhenjaHorbach Sorry, I forgot to push the last local commit. I updated.

src/components/LHNOptionsList/OptionRowLHN.tsx

ZhenjaHorbach · 2025-12-02T14:57:08Z

src/components/LHNOptionsList/OptionRowLHN.tsx

    const subscriptAvatarBorderColor = isOptionFocused ? focusedBackgroundColor : theme.sidebar;
    const firstIcon = optionItem.icons?.at(0);

+    // This is used to ensure that we display the text exactly as the user entered it when displaying thread header text, instead of parsing their text to HTML.


I suppose it's wrong text
Since here we have an issue with option row and not with thread header

ZhenjaHorbach · 2025-12-04T09:06:30Z

LGTM!

puneetlath

Looks like there is a lint failure @nkdengineer

ZhenjaHorbach · 2025-12-04T18:23:18Z

Looks like there is a lint failure @nkdengineer

This issue is not related to our changes
So I'm not sure if we need to fix it here

puneetlath · 2025-12-04T20:16:31Z

Will it cause an issue on main if we don't suppress it?

nkdengineer · 2025-12-05T07:59:37Z

@puneetlath I disabled the lint in this line since we don't want to change this here.

puneetlath

Ok great thanks. Looks like we have some conflicts now.

OSBotify · 2025-12-09T16:07:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-10T22:05:35Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-10T23:58:49Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-12T19:00:42Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.2.77-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-12T22:05:56Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jjcoffee · 2026-01-02T10:14:34Z

src/components/LHNOptionsList/OptionRowLHN.tsx

    const firstIcon = optionItem.icons?.at(0);

+    // This is used to ensure that we display the text exactly as the user entered it when displaying LHN title, instead of parsing their text to HTML.
+    const shouldParseFullTitle = optionItem?.parentReportAction?.actionName !== CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT;


Coming from #77518. Group titles can end up as an empty string if they are parsed (e.g. if the title is < >) which causes them to render with the fallback text Hidden.

Revert "Revert "fix: thread header is not showing the exact message s…

2a4b7d1

…ent""

melvin-bot bot assigned nkdengineer Nov 27, 2025

nkdengineer changed the title ~~Revert "Revert "fix: thread header is not showing the exact message sent""~~ fix: thread header is not showing the exact message sent v3 Nov 27, 2025

nkdengineer marked this pull request as ready for review November 27, 2025 15:14

nkdengineer requested review from a team as code owners November 27, 2025 15:14

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team November 27, 2025 15:14

melvin-bot bot requested review from heyjennahay and removed request for a team November 27, 2025 15:14

nkdengineer mentioned this pull request Nov 27, 2025

[Due for payment 2025-12-19] [$250] chat-Thread header is not showing the exact message sent #71434

Closed

8 tasks

nkdengineer added 2 commits December 2, 2025 18:47

Merge branch 'main' into revert-76059-revert-73242-follow-up-71434

bb1fb01

fix LHN issue

ee80257

ZhenjaHorbach reviewed Dec 2, 2025

View reviewed changes

src/components/LHNOptionsList/OptionRowLHN.tsx Outdated Show resolved Hide resolved

create const

65c35ec

ZhenjaHorbach reviewed Dec 2, 2025

View reviewed changes

update comment

027d77d

ZhenjaHorbach approved these changes Dec 4, 2025

View reviewed changes

melvin-bot bot requested a review from puneetlath December 4, 2025 09:06

puneetlath previously approved these changes Dec 4, 2025

View reviewed changes

nkdengineer added 2 commits December 5, 2025 14:24

Merge branch 'main' into revert-76059-revert-73242-follow-up-71434

c1dc6b0

disable eslint

ed62e68

nkdengineer dismissed puneetlath’s stale review via ed62e68 December 5, 2025 07:31

puneetlath previously approved these changes Dec 8, 2025

View reviewed changes

resolve conflict

fde628b

nkdengineer dismissed puneetlath’s stale review via fde628b December 9, 2025 15:13

puneetlath approved these changes Dec 9, 2025

View reviewed changes

puneetlath merged commit 13eff6c into Expensify:main Dec 9, 2025
31 checks passed

OSBotify mentioned this pull request Dec 10, 2025

Deploy Checklist: New Expensify 2025-12-10 #77285

Closed

94 tasks

IuliiaHerets mentioned this pull request Dec 11, 2025

Wrong system message after remove expense from report #77339

Open

8 tasks

jponikarchuk mentioned this pull request Dec 11, 2025

[$250] Thread - Hidden in LHN and loading header when thread reply on system message #77346

Closed

8 tasks

jjcoffee reviewed Jan 2, 2026

View reviewed changes

Conversation

nkdengineer commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Nov 27, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Nov 27, 2025

Uh oh!

ZhenjaHorbach commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Dec 2, 2025

Uh oh!

nkdengineer commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ZhenjaHorbach Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Dec 4, 2025

Uh oh!

puneetlath left a comment

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Dec 4, 2025

Uh oh!

puneetlath commented Dec 4, 2025

Uh oh!

nkdengineer commented Dec 5, 2025

Uh oh!

puneetlath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 9, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

jjcoffee Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nkdengineer commented Nov 27, 2025 •

edited

Loading

codecov bot commented Nov 27, 2025 •

edited by github-actions bot

Loading

ZhenjaHorbach commented Dec 1, 2025 •

edited

Loading

nkdengineer commented Dec 2, 2025 •

edited

Loading