Skip to content

[CP Staging] Revert "Make TimezoneSelectPage use new SelectionList"#76237

Merged
cristipaval merged 2 commits intomainfrom
revert-75878-@OlGierd03/migrate-TimezoneSelectPage
Nov 28, 2025
Merged

[CP Staging] Revert "Make TimezoneSelectPage use new SelectionList"#76237
cristipaval merged 2 commits intomainfrom
revert-75878-@OlGierd03/migrate-TimezoneSelectPage

Conversation

@cristipaval
Copy link
Copy Markdown
Contributor

@cristipaval cristipaval commented Nov 27, 2025

Reverts #75878
Reverts #75543

Reverts 2 PRs that added 2 deploy blockers. We have a hotfix, but it is quite risky to CP because it introduces changes to a base component, and we would rather let those changes go through a full regression test.

$ #76212
$ #76198

@github-actions
Copy link
Copy Markdown
Contributor

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2025

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...s/Profile/PersonalDetails/CountrySelectionPage.tsx 0.00% <0.00%> (ø)
src/pages/settings/Profile/TimezoneSelectPage.tsx 0.00% <0.00%> (ø)
... and 81 files with indirect coverage changes

@github-actions

This comment has been minimized.

@cristipaval cristipaval changed the title Revert "Make TimezoneSelectPage use new SelectionList" [CP Staging] Revert "Make TimezoneSelectPage use new SelectionList" Nov 27, 2025
@github-actions
Copy link
Copy Markdown
Contributor

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment was marked as outdated.

…03/migrate-CountrySelectionPage"

This reverts commit b6d8776, reversing
changes made to 580ef5b.
@cristipaval cristipaval force-pushed the revert-75878-@OlGierd03/migrate-TimezoneSelectPage branch from 390d956 to 5f1ee4d Compare November 28, 2025 12:48
@github-actions
Copy link
Copy Markdown
Contributor

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #76237.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/76237/index.html
The build for Android was skipped iOS
Web 🕸️
⏩ SKIPPED ⏩
The build for Web was skipped

👀 View the workflow run that generated this build 👀

@cristipaval cristipaval marked this pull request as ready for review November 28, 2025 14:25
@cristipaval cristipaval requested review from a team as code owners November 28, 2025 14:25
@melvin-bot melvin-bot bot requested review from JmillsExpensify and MonilBhavsar and removed request for a team November 28, 2025 14:25
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Nov 28, 2025

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team November 28, 2025 14:25
Copy link
Copy Markdown
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert of two PRs

@cristipaval cristipaval merged commit ce4255b into main Nov 28, 2025
33 of 36 checks passed
@cristipaval cristipaval deleted the revert-75878-@OlGierd03/migrate-TimezoneSelectPage branch November 28, 2025 14:38
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Nov 28, 2025

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Nov 28, 2025
OSBotify pushed a commit that referenced this pull request Nov 28, 2025
…ate-TimezoneSelectPage

[CP Staging] Revert "Make TimezoneSelectPage use new SelectionList"

(cherry picked from commit ce4255b)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 28, 2025
@OSBotify
Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.65-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.65-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.66-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Dec 1, 2025

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.66-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants