[Internal QA]: Unshare bank account

[narefyev91]

Explanation of Change

Implement release 2: Unshare bank account from the bank account sharing in NewDot design doc: https://docs.google.com/document/d/1l8ODiSIiEIE-a9zjj69ACqCHGHeLPwf4c-H5SJn3uHg/edit?tab=t.0#bookmark=id.ypt7upd0fqea

Fixed Issues

$ #73251
PROPOSAL:

Tests

Precondition has shared bank account with some admins

1. Click on 3 dots near shared bank account
2. Verify that Unshare option is available in the list
3. Click on Ushare - verify that new right panel is shown with list of admins.
4. Click unshare for any of them - verify that warning modal is shown, click unshare - verify that no errors is shown and after success response admin is removed from the list
5. If any error is shown verify that it's shown in the bottom with ability to dismiss

• Verify that no errors appear in the JS console

Offline tests

Precondition has shared bank account with some admins

1. Click on 3 dots near shared bank account
2. Verify that Unshare option is available in the list
3. Click on Ushare - verify that new right panel is shown with list of admins.
4. Click unshare for any of them - verify that warning modal is shown, click unshare - verify that no errors is shown and after success response admin is removed from the list
5. If any error is shown verify that it's shown in the bottom with ability to dismiss

QA Steps

Precondition has shared bank account with some admins

1. Click on 3 dots near shared bank account
2. Verify that Unshare option is available in the list
3. Click on Ushare - verify that new right panel is shown with list of admins.
4. Click unshare for any of them - verify that warning modal is shown, click unshare - verify that loader indicator is shown inside unshare button.
5. Go back and return to unshare flow - verify that we still waiting for success response from API (loading indicator is shown)

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	100.00% <ø> (ø)
src/SCREENS.ts	100.00% <ø> (ø)
...rc/components/Icon/chunks/expensify-icons.chunk.ts	0.00% <ø> (ø)
src/libs/API/types.ts	100.00% <ø> (ø)
...igation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	75.00% <ø> (ø)
src/ROUTES.ts	12.42% <0.00%> (-0.12%)	⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx	8.17% <0.00%> (-0.02%)	⬇️
src/libs/actions/BankAccounts.ts	2.30% <0.00%> (-0.08%)	⬇️
src/pages/settings/InitialSettingsPage.tsx	0.00% <0.00%> (ø)
... and 2 more
... and 9 files with indirect coverage changes

[narefyev91]

@Expensify/design could i get design reviews for this screen:



(Hover on menu item)

[dubielzyk-expensify]

All looking great!

[narefyev91]

We still waiting BE logic for unshare and PR for share (to test end-2-end). But code could be ready for initial review

[melvin-bot]

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[NikkiWines]

Sorry for the delay, was OOO for the holidays. @narefyev91 could you merge main here please? Then we should be good to move this forward 🙇

[NikkiWines]

👍

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.97-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[joekaufmanexpensify]

BUG: Unshare message shown in concierge chat from user side, but not support

Steps

1. As admin A, login to an account and unshare a business bank account from admin B.
2. Login to admin B's account and go to their concierge chat.
3. Verify you see the unshare confirmation message.
4. As a support agent, load admin B's concierge chat.

Expected behavior

You see the unshare message. This is important so agents can effectively support customers.

Actual behavior

The unshare message isn't shown on the support agent version of the chat. This doesn't happen when a bank account is shared. Only unshared.

2026-01-12_10-29-31.mp4

cc @NikkiWines as I suspect this is a backend issue.

[joekaufmanexpensify]

I don't think either of these are blockers. Testing one more case before checking this off.

[joekaufmanexpensify]

The second of the two issues above is actually all set, per this. I marked it as resolved. 👍

[joekaufmanexpensify]

BUG: Missing frontend error when unsharing Expensify Card settlement account

Steps:

Precondition: Admin A and B have copies of a business bank acocunt. Admin B provisioned the Expensify Card with their bank account copy.

1. Login to admin A account.
2. Go to Account > Wallet.
3. Tap the bank account row.
4. Tap Unshare.
5. Try to unshare the bank account from Admin B.

Expected behavior:

We show a bottom drawer (mobile) / center state (web) modal explaining the bank account can't be unshared bcause it's being used as an Expensify Card settlement account.

Actual behavior:

We show a generic error. Logs show we are correctly throwing on the backend.

[joekaufmanexpensify]

Given we are throwing on the backend and this is a rare action, IDT we need to block on that either. Marking the PR as all set for QA purposes!

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[narefyev91]

BUG: Missing frontend error when unsharing Expensify Card settlement account

Steps:

Precondition: Admin A and B have copies of a business bank acocunt. Admin B provisioned the Expensify Card with their bank account copy.

1. Login to admin A account.
2. Go to Account > Wallet.
3. Tap the bank account row.
4. Tap Unshare.
5. Try to unshare the bank account from Admin B.

Expected behavior:

We show a bottom drawer (mobile) / center state (web) modal explaining the bank account can't be unshared bcause it's being used as an Expensify Card settlement account.

#### Actual behavior: We show a generic error. [Logs](https://expensify.slack.com/archives/C07NMDKEFMH/p1768234880957089?thread_ts=1768232876.251719&cid=C07NMDKEFMH) show we are correctly throwing on the backend.

@joekaufmanexpensify could you please send onyx data with such error - i would make a follow up PR to reflect these changes

[joekaufmanexpensify]

@joekaufmanexpensify could you please send onyx data with such error - i would make a follow up PR to reflect these changes

@narefyev91 Is there any specific onyx data you need to do this, and is it from the account trying to unshare the bank account or the account from which the bank account is being unshared and failing?

[narefyev91]

@joekaufmanexpensify could you please send onyx data with such error - i would make a follow up PR to reflect these changes

@narefyev91 Is there any specific onyx data you need to do this, and is it from the account trying to unshare the bank account or the account from which the bank account is being unshared and failing?

i think onyx data when you try to unshare and error is shown (generic one - instead of drawer)

[joekaufmanexpensify]

Got it. But just the onyx data for the failed API response, or any specific keys?

[NikkiWines]

The unshare message isn't shown on the support agent version of the chat. This doesn't happen when a bank account is shared. Only unshared.

@joekaufmanexpensify This might be a limitation of queueing the unshare message in Auth (as opposed to Web, like we do for the share message). I'll look into fixing it (or moving it, if necessary)

[joekaufmanexpensify]

TY!

[narefyev91]

Got it. But just the onyx data for the failed API response, or any specific keys?

yeah i think the whole onyx data - when result is failed. Generally needs to understand "based on what" we should show not standard red line with error - but drawer.

[joekaufmanexpensify]

Just to be 100% sure, the full onyx state for the account, via the Export onyx state button? If so, not sure we'll be able to share that for the account that tried to unshare this, it's one of our finance team's internal accounts. Maybe @NikkiWines can tell based on what we should show the bottom drawer here based on the backend error we return in the logs?

[narefyev91]

Just to be 100% sure, the full onyx state for the account, via the Export onyx state button? If so, not sure we'll be able to share that for the account that tried to unshare this, it's one of our finance team's internal accounts. Maybe @NikkiWines can tell based on what we should show the bottom drawer here based on the backend error we return in the logs?

yeah - that works as well :-)

[NikkiWines]

Looks like the onyxData would've been:

  "onyxData": [
    {
      "onyxMethod": "merge",
      "key": "bankAccountList",
      "value": {
        "<bankAccountID>": {
          "errors": {
            "1768234530396601": "This bank account can't be deleted because it is used for Expensify Card payments. If you would still like to delete this account, please reach out to Concierge."
          }
        }
      }
    }
  ],

[narefyev91]

Looks like the onyxData would've been:

  "onyxData": [
    {
      "onyxMethod": "merge",
      "key": "bankAccountList",
      "value": {
        "<bankAccountID>": {
          "errors": {
            "1768234530396601": "This bank account can't be deleted because it is used for Expensify Card payments. If you would still like to delete this account, please reach out to Concierge."
          }
        }
      }
    }
  ],

hmmm - seems like we need to check if inside error text we have "Expensify Card" words... i do not see any other options - to trigger drawer

[joekaufmanexpensify]

Got it. Is that an issue?