[NO QA] Replace FullScreenLoadingIndicator with ActivityIndicator in HelpContent component by abbasifaizan70 · Pull Request #76313 · Expensify/App

abbasifaizan70 · 2025-11-28T21:53:29Z

Explanation of Change

Replace FullScreenLoadingIndicator with ActivityIndicator in HelpContent component

Fixed Issues

$ #75537
PROPOSAL: #75537 (comment)

Tests

Open browser DevTools (F12)
Go to Console
Run: Onyx.set('nvp_sidePanel', { open: true, openNarrowScreen: true })
This will open Help Panel

Verify that no errors appear in the JS console

Offline tests

same as Tests.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-11-29.at.2.35.39.PM.mov

…ent component

melvin-bot · 2025-11-28T21:53:35Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-11-28T22:08:54Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...omponents/SidePanel/HelpComponents/HelpContent.tsx	`2.85% <ø> (ø)`
... and 26 files with indirect coverage changes

Pujan92 · 2025-11-29T06:06:10Z

@abbasifaizan70 You need to apply below step to verify and also In the test steps you need to add

Apply Onyx.set('nvp_sidePanel', { open: true, openNarrowScreen: true }) in the console to open help panel

Ref -

App/src/components/SidePanel/HelpComponents/HelpButton/HelpButtonBase.tsx

Lines 3 to 8 in f82a8db

    
           // Help panel is currently disabled. To open it manually, run: 
        
           // Onyx.set('nvp_sidePanel', { open: true }) in the console. 
        
           // eslint-disable-next-line @typescript-eslint/no-unused-vars 
        
           function HelpButton({style}: HelpButtonProps) { 
        
               return null; 
        
           }

Pujan92 · 2025-11-29T06:19:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

src/components/SidePanel/HelpComponents/HelpContent.tsx

abbasifaizan70 · 2025-11-29T08:42:50Z

@abbasifaizan70 You need to apply below step to verify and also In the test steps you need to add

Apply Onyx.set('nvp_sidePanel', { open: true, openNarrowScreen: true }) in the console to open help panel

Ref -

App/src/components/SidePanel/HelpComponents/HelpButton/HelpButtonBase.tsx

Lines 3 to 8 in f82a8db

// Help panel is currently disabled. To open it manually, run:

// Onyx.set('nvp_sidePanel', { open: true }) in the console.

// eslint-disable-next-line @typescript-eslint/no-unused-vars

function HelpButton({style}: HelpButtonProps) {

return null;

}

@Pujan92
When i run:

Onyx.set('nvp_sidePanel', { open: true, openNarrowScreen: true })

The help panel opens like below with content.

To actually see the loading indicator and verify it's working correctly, you need to temporarily modify the code in HelpContent.tsx

Current Code (Line 130):

{currentState === undefined ? (
    <View style={[styles.flex1, styles.fullScreenLoading]}>
        <ActivityIndicator size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE} />
    </View>
) : (

Change to (for testing only):

{true ? (  // Force loading to always show for testing
    <View style={[styles.flex1, styles.fullScreenLoading]}>
        <ActivityIndicator size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE} />
    </View>
) : (

Screen.Recording.2025-11-29.at.2.30.20.PM.mov

This allowed me to consistently display the loading indicator and confirm that it renders correctly.

I’ve included the local test screenshot in the PR for reference. However, because this temporary code change cannot be applied to the staging build, I wasn’t able to include the same setup in the official test steps.

Pujan92

LGTM!

Screen.Recording.2025-11-29.at.16.12.13.mov

Pujan92 · 2025-11-29T11:15:58Z

@Julesssss QA may not test these changes atm bcoz it is hidden currently. Do we need to add [No QA] tag here?

Julesssss · 2025-12-01T17:09:30Z

Thanks yep I will do that.

OSBotify · 2025-12-01T17:35:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-01T23:45:29Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.67-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-03T13:58:09Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-03T14:53:35Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Replace FullScreenLoadingIndicator with ActivityIndicator in HelpCont…

e070952

…ent component

abbasifaizan70 requested review from a team as code owners November 28, 2025 21:53

melvin-bot bot assigned abbasifaizan70 Nov 28, 2025

melvin-bot bot requested review from Pujan92 and removed request for a team November 28, 2025 21:53

melvin-bot bot requested review from JmillsExpensify and removed request for a team November 28, 2025 21:53

abbasifaizan70 mentioned this pull request Nov 28, 2025

[$250] Use correct loading indicator in HelpContent component #75537

Closed

Revert extra code

817268b

fixed prettier issue

c004c9e

Pujan92 reviewed Nov 29, 2025

View reviewed changes

src/components/SidePanel/HelpComponents/HelpContent.tsx Outdated Show resolved Hide resolved

resolved feedbacks

124f7d4

Pujan92 approved these changes Nov 29, 2025

View reviewed changes

melvin-bot bot requested a review from Julesssss November 29, 2025 10:50

Julesssss approved these changes Dec 1, 2025

View reviewed changes

Julesssss merged commit e15fa9e into Expensify:main Dec 1, 2025
34 checks passed

Julesssss changed the title ~~Replace FullScreenLoadingIndicator with ActivityIndicator in HelpContent component~~ [NO QA] Replace FullScreenLoadingIndicator with ActivityIndicator in HelpContent component Dec 1, 2025

OSBotify mentioned this pull request Dec 1, 2025

Deploy Checklist: New Expensify 2025-12-01 #76460

Closed

This was referenced Mar 11, 2026

[Due for payment 2026-03-30] [$125] Use valid loading indicator in BaseLegalNamePage.tsx #84992

Open

Use ActivityIndicator in BaseLegalNamePage #85516

Merged

Conversation

abbasifaizan70 commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 28, 2025

Uh oh!

codecov bot commented Nov 28, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pujan92 commented Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pujan92 commented Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

abbasifaizan70 commented Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Code (Line 130):

Change to (for testing only):

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Pujan92 commented Nov 29, 2025

Uh oh!

Julesssss commented Dec 1, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 1, 2025

Uh oh!

OSBotify commented Dec 1, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

abbasifaizan70 commented Nov 28, 2025 •

edited

Loading

codecov bot commented Nov 28, 2025 •

edited by github-actions bot

Loading

Pujan92 commented Nov 29, 2025 •

edited

Loading

Pujan92 commented Nov 29, 2025 •

edited

Loading

abbasifaizan70 commented Nov 29, 2025 •

edited

Loading