Optimize loops in formatting personal details

[tgolen]

Details

Fixed Issues

$ #7630

Tests / QA

Note: this can't really be QAed on iOS or Android since there will be no way to inspect the console

1. Load the app
2. Look in the JS console for Timing:expensify.cash.personal_details_formatted (need to have the verbose visibility setting turned on)
3. Verify the number is low (ideally under 1000ms)

• Verify that no errors appear in the JS console

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Same as web

Desktop

iOS

Android

[kidroca]

Everything seems the same but this spread here
I reckon it was the bottleneck, if that so you can just swap it like this:

finalObject[login] = { 
  login,
  avatar,
  displayName,
};

return finalObject;

[tgolen]

Yep, it was definitely the spread. I found it from looking at this and noticing the _objectSpread being called over and over.

I figured the rest of the changes, while not strictly necessary, would only help.

[github-actions]

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.37-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Cherry-picked to staging by @luacmartins in version: 1.1.37-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.