Migrate openPersonalBankAccountSetupView to use Verify Account Route without Redirects by jmusial · Pull Request #76514 · Expensify/App

jmusial · 2025-12-02T11:54:13Z

Explanation of Change

Fixed Issues

$ #75873
PROPOSAL:

Tests

Pre requisites:
Have 2 accounts A (with a workspace and added bank account) and B (fresh, not verified, no bank acc added)

From account B create an expense that account A owes account B
Submit and pay from account A
In account B go into the expense chat
You should see Add bank account button
Click it -> Enter magic code
Proceed to add bank account

Offline tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

0078.android.native.mov

Android: mWeb Chrome

00778.andorid.chrome.mov

iOS: Native

0078.ios.native.mov

iOS: mWeb Safari

0078.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-04.at.11.56.08.mov

codecov · 2025-12-02T12:02:54Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
src/pages/settings/Wallet/PaymentMethodList.tsx	`0.00% <ø> (ø)`
src/ROUTES.ts	`12.52% <0.00%> (+0.09%)`	⬆️
src/libs/actions/BankAccounts.ts	`1.01% <0.00%> (ø)`
...ettings/Wallet/NewBankAccountVerifyAccountPage.tsx	`0.00% <0.00%> (ø)`
... and 13 files with indirect coverage changes

…ew-to-use-separate-verify-account-page

jmusial · 2025-12-03T11:52:35Z

hey @mountiny @aimane-chnaif I having a hard time getting a test scenario for this one.

The only scenario where this occurs is in src/pages/home/report/PureReportActionItem.tsx#1138. It requires action to be of type CONST.REPORT.ACTIONS.TYPE.REIMBURSEMENT_QUEUED.

Do you have any idea how or can point me to the person that can help with getting that action?

mountiny · 2025-12-03T13:05:32Z

I think you would need to setup a workspace with VBBA and then employee who DOES NOT have their reimbursement account set up yet, then when the admin pays, it is just queued

mountiny · 2025-12-03T13:06:34Z

https://expensify.slack.com/archives/C08CZDJFJ77/p1764767180892099

jmusial · 2025-12-04T11:14:29Z

Hey, Publishing this PR but...

I don't thing there is time effective way of getting rid of backTo here :(

openPersonalBankAccountSetupView is quite deep in the component tree and as far as I traced it down it appears on Main Report Screen and Search Money Request Report Page. Especially the latter can have multitude of urls and params

Spoke quickly with @WojtekBoman, and he confirmed that currently there is no mechanism to replace backTo in that scenario.

In the light of the above I think this PR presents average added value at best. Can go forward with (for uri consistency) it but closing it and waiting for #73825 is an option as well.

@mountiny @aimane-chnaif what do you think ?

melvin-bot · 2025-12-04T11:14:43Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2025-12-04T11:47:26Z

src/libs/Url.ts


 type UrlWithParams<TBase extends string> = `${TBase}${'' | `?${string}` | `&${string}`}`;
-type UrlParams = {backTo?: string; forwardTo?: string} & Record<string, string | number | undefined>;
+type UrlParams = {backTo?: string; forwardTo?: string} & Record<string, string | number | boolean | undefined>;


where is boolean used?

leftover from previous version. removed

would wait with reviewing this one till we get input weather this PR makes sense

aimane-chnaif · 2025-12-04T12:48:59Z

Regarding the use of deprecated backTo param, I'll defer to @mountiny. I am fine with either way.

joekaufmanexpensify · 2025-12-04T16:43:33Z

Refactor, removing my review

…ew-to-use-separate-verify-account-page

mountiny · 2025-12-06T12:09:25Z

I think we can proceed @aimane-chnaif

jmusial · 2025-12-08T11:18:43Z

will add missing vids today

…ew-to-use-separate-verify-account-page

jmusial · 2025-12-08T15:43:59Z

gtg @aimane-chnaif

aimane-chnaif · 2025-12-09T15:41:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-09.at.6.28.08.pm.mov

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web.unverified.mov

web.verified.already.mov

aimane-chnaif · 2025-12-09T17:03:48Z

Submit and pay from account A

@jmusial which payment method did you select?

Edit: I selected "Pay via Workspace" and able to follow Tests Steps

aimane-chnaif · 2025-12-09T17:23:11Z

@jmusial you're missing "Verify that ..." in Tests

OSBotify · 2025-12-10T22:06:11Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-10T23:59:25Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-12T19:01:18Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.2.77-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-12T22:06:32Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Refactor

cf3710d

melvin-bot bot assigned jmusial Dec 2, 2025

jmusial changed the title ~~Refactor~~ Migrate openPersonalBankAccountSetupView to use Verify Account Route without Redirects Dec 2, 2025

jmusial mentioned this pull request Dec 2, 2025

[Due for payment now] [Tracking] [$1000] Update the ValidateCodeActionModal to be its own screen in the stack #69171

Closed

jmusial added 3 commits December 2, 2025 14:14

fix navigation error

5eaee62

fix lint

f1b036e

Merge branch 'main' into feat/refactor-openPersonalBankAccountSetupVi…

0569144

…ew-to-use-separate-verify-account-page

revert to using backTo :(

d5b62d3

jmusial marked this pull request as ready for review December 4, 2025 11:14

jmusial requested review from a team as code owners December 4, 2025 11:14

melvin-bot bot requested review from aimane-chnaif and joekaufmanexpensify and removed request for a team December 4, 2025 11:14

melvin-bot bot removed the request for review from a team December 4, 2025 11:14

aimane-chnaif reviewed Dec 4, 2025

View reviewed changes

remove leftover

b26a6bd

joekaufmanexpensify removed their request for review December 4, 2025 16:43

Merge branch 'main' into feat/refactor-openPersonalBankAccountSetupVi…

50e16a2

…ew-to-use-separate-verify-account-page

Merge branch 'main' into feat/refactor-openPersonalBankAccountSetupVi…

434374b

…ew-to-use-separate-verify-account-page

aimane-chnaif approved these changes Dec 9, 2025

View reviewed changes

melvin-bot bot requested a review from mjasikowski December 9, 2025 17:30

mjasikowski approved these changes Dec 10, 2025

View reviewed changes

mjasikowski merged commit 0e02ed0 into Expensify:main Dec 10, 2025
31 of 32 checks passed

OSBotify mentioned this pull request Dec 10, 2025

Deploy Checklist: New Expensify 2025-12-10 #77285

Closed

94 tasks

Conversation

jmusial commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 2, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jmusial commented Dec 3, 2025

Uh oh!

mountiny commented Dec 3, 2025

Uh oh!

mountiny commented Dec 3, 2025

Uh oh!

jmusial commented Dec 4, 2025

Uh oh!

melvin-bot bot commented Dec 4, 2025

Uh oh!

aimane-chnaif Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Dec 4, 2025

Uh oh!

joekaufmanexpensify commented Dec 4, 2025

Uh oh!

mountiny commented Dec 6, 2025

Uh oh!

jmusial commented Dec 8, 2025

Uh oh!

jmusial commented Dec 8, 2025

Uh oh!

aimane-chnaif commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimane-chnaif commented Dec 9, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jmusial commented Dec 2, 2025 •

edited

Loading

codecov bot commented Dec 2, 2025 •

edited by github-actions bot

Loading

aimane-chnaif commented Dec 9, 2025 •

edited

Loading

aimane-chnaif commented Dec 9, 2025 •

edited

Loading