fix: Invalid character error in SAML Identity Provider Metadata input + initial cursor position#76515
Conversation
… + initial cursor position
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
| scrollToBottom(inputRef.current as TextInputType); | ||
| moveSelectionToEnd(inputRef.current as TextInputType); |
There was a problem hiding this comment.
Could you try to remove these assertions?
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
cc: @ZhenjaHorbach |
|
eslint fails like this on main too |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2025-12-09.12.02.41.movAndroid: mWeb Chrome2025-12-09.12.03.40.moviOS: HybridApp2025-12-09.11.53.29.moviOS: mWeb Safari2025-12-09.11.54.13.movMacOS: Chrome / Safari2025-12-09.11.49.32.mov |
|
LGTM! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.75-0 🚀
|
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.75-0 🚀
|
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.77-0 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀
|
Explanation of Change
Allows html-looking value for the SAML metaIdentity text input. Makes the multiline input autoscroll to the bottom after opening the modal.
Fixed Issues
$ #76376
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Nagranie.z.ekranu.2025-12-4.o.13.58.24.mov
Android: mWeb Chrome
Nagranie.z.ekranu.2025-12-4.o.13.54.57.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-12-04.at.13.33.56.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-12-04.at.11.54.41.mp4
MacOS: Chrome / Safari
Nagranie.z.ekranu.2025-12-4.o.11.51.58.mov