fix: WS Chat auto-scrolls to latest message after mark as paid an expense by nkdengineer · Pull Request #76585 · Expensify/App

nkdengineer · 2025-12-03T07:47:18Z

Explanation of Change

fix: WS Chat auto-scrolls to latest message after mark as paid an expense

Fixed Issues

Tests

Preconditions: The member has submitted some expense reports to the Workspace chat, and the admin has approved them before

Log in to Newdot as the admin
Navigate to the member Workspace chat
Scroll up to the first report in the Approve status
Tap on the Pay button from the preview
Select the option Mark as paid
Verify that the workspace chat doesn't scroll to bottom

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-03.at.14.41.56.mov

Android: mWeb Chrome

Screen.Recording.2025-12-03.at.14.41.07.mov

iOS: Native

Screen.Recording.2025-12-03.at.14.42.44.mov

iOS: mWeb Safari

Screen.Recording.2025-12-03.at.14.43.14.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-03.at.14.39.17.mov

…ense

codecov · 2025-12-03T07:55:23Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU.ts	`64.01% <100.00%> (+52.65%)`	⬆️
... and 145 files with indirect coverage changes

nkdengineer · 2025-12-03T08:48:22Z

src/libs/actions/IOU.ts

    playSound(SOUNDS.SUCCESS);
    API.write(apiCommand, params, {optimisticData, successData, failureData});
-    notifyNewAction(Navigation.getTopmostReportId() ?? iouReport?.reportID, userAccountID);
+    notifyNewAction(!full ? (Navigation.getTopmostReportId() ?? iouReport?.reportID) : iouReport?.reportID, userAccountID);


@Pujan92 When paid a partial amount, we want to scroll to the bottom to see the new report preview.

@nkdengineer can you plz share the demo of that as I am unable to do partial payment from the chat report?

@Pujan92 You need to disable approval.

Screen.Recording.2025-12-09.at.21.55.49.mov

melvin-bot · 2025-12-03T09:27:52Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JmillsExpensify

Agree that we shouldn't auto-scroll to the bottom. Product changes look good.

Pujan92 · 2025-12-07T11:41:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-12-10.at.16.59.44.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-12-10.at.17.07.34.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-08.at.17.45.12.mov

Screen.Recording.2025-12-10.at.10.45.09.mov

Pujan92

LGTM!

OSBotify · 2025-12-10T12:53:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-10T22:06:20Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-10T23:59:34Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-12T19:01:27Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.77-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-12T22:06:41Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: WS Chat auto-scrolls to latest message after mark as paid an exp…

e2d81ef

…ense

melvin-bot bot assigned nkdengineer Dec 3, 2025

keep paid partial behavior

b9d5912

nkdengineer commented Dec 3, 2025

View reviewed changes

nkdengineer marked this pull request as ready for review December 3, 2025 09:27

nkdengineer requested review from a team as code owners December 3, 2025 09:27

melvin-bot bot requested review from JmillsExpensify and Pujan92 December 3, 2025 09:27

melvin-bot bot removed request for a team December 3, 2025 09:27

JmillsExpensify reviewed Dec 4, 2025

View reviewed changes

Pujan92 approved these changes Dec 10, 2025

View reviewed changes

melvin-bot bot requested a review from rlinoz December 10, 2025 11:38

rlinoz approved these changes Dec 10, 2025

View reviewed changes

rlinoz merged commit d04108e into Expensify:main Dec 10, 2025
31 of 36 checks passed

OSBotify mentioned this pull request Dec 10, 2025

Deploy Checklist: New Expensify 2025-12-10 #77285

Closed

94 tasks

Conversation

nkdengineer commented Dec 3, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 3, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nkdengineer Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Pujan92 Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

melvin-bot bot commented Dec 3, 2025

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Pujan92 commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Dec 3, 2025 •

edited by github-actions bot

Loading

Pujan92 commented Dec 7, 2025 •

edited

Loading