Duplicated "Total" amount field briefly appear before the report loads by mkzie2 · Pull Request #76711 · Expensify/App

mkzie2 · 2025-12-04T11:35:06Z

Explanation of Change

Fixed Issues

$ #75986
PROPOSAL: #75986 (comment)

Tests

Test 1:

Create new Workspace
Open the Workspace chat
Create manual expense with merchant filled and empty category
Right when the report appear in the chat tap on it
Verify that: When the expense report is loading, only one total amount fields briefly appear.

Test 2:

Login with new account
Tap to the "Reports" tab
Go offline
Click on "Create expense"
Tap on "Manual"
Add an amount and tap on "Next"
In Choose recipient page, select "Manager McTest"
Create and open the expense
Verify that: Only one marked as paid system message appear.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Test 1:

Create new Workspace
Open the Workspace chat
Create manual expense with merchant filled and empty category
Right when the report appear in the chat tap on it
Verify that: When the expense report is loading, only one total amount fields briefly appear.

Test 2:

Login with new account
Tap to the "Reports" tab
Go offline
Click on "Create expense"
Tap on "Manual"
Add an amount and tap on "Next"
In Choose recipient page, select "Manager McTest"
Create and open the expense
Verify that: Only one marked as paid system message appear.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-04.at.22.51.37.mov

Android: mWeb Chrome

Screen.Recording.2025-12-04.at.22.52.25.mov

iOS: Native

Screen.Recording.2025-12-04.at.22.53.05.mov

iOS: mWeb Safari

Screen.Recording.2025-12-04.at.22.55.03.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-04.at.22.55.30.mov

codecov · 2025-12-04T11:43:28Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/FlatList/index.ios.tsx	`91.66% <100.00%> (+1.66%)`	⬆️
src/pages/home/report/ReportActionsList.tsx	`79.58% <100.00%> (-0.07%)`	⬇️
src/components/FlatList/index.android.tsx	`0.00% <0.00%> (ø)`
src/components/FlatList/index.tsx	`0.00% <0.00%> (ø)`
... and 38 files with indirect coverage changes

melvin-bot · 2025-12-04T15:56:55Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2025-12-05T12:43:05Z

Conflicts!

mkzie2 · 2025-12-08T17:58:11Z

@aimane-chnaif Conflicts resolved.

mkzie2 · 2025-12-08T18:18:56Z

Failed test from main

aimane-chnaif · 2025-12-08T19:04:20Z

Tests fixed on main. Merge main

mkzie2 · 2025-12-09T07:20:53Z

Now the typecheck test failed 😂

aimane-chnaif · 2025-12-11T05:18:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

aimane-chnaif · 2025-12-11T06:05:41Z

@mkzie2 I think test case is wrong

Verify that: When the expense report is loading, no total amount fields appear.

Total amount still shows briefly but no duplicated.

Screen.Recording.2025-12-11.at.6.51.20.am.mov

mkzie2 · 2025-12-11T06:15:20Z

@aimane-chnaif I updated the test steps.

puneetlath · 2025-12-11T19:22:31Z

src/components/FlatList/types.ts

    CellRendererComponent?: React.ComponentType<CellRendererProps<T>> | null;
+
+    /**
+     * Whether to hide the content


What's an example of when someone would use this? Perhaps we can document this a bit more clearly.

Right now the comment isn't saying anything the variable name doesn't already.

@puneetlath What do you think about this:

Whether to hide the content when we need to (e.g. when first displaying the report actions list, we initial shows the top report actions first. We only show the full report actions list after user scrolls)

Sorry for the delay. Sounds good to me. There's a small grammar error, so I would phrase to something like:

Whether to hide the content (e.g. when first displaying the report actions list, we initially show only the top report actions. We then show the full report actions list after the user scrolls)

@puneetlath I updated 👍

OSBotify · 2025-12-22T18:10:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-23T00:51:36Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.2.86-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

jponikarchuk · 2025-12-23T14:30:31Z

This PR failing in offline mode because of a regression issue
This issue is reproducible in: All platforms

1.mp4

OSBotify · 2025-12-24T18:48:42Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: duplicate action on expense report

a081a77

melvin-bot bot assigned mkzie2 Dec 4, 2025

mkzie2 marked this pull request as ready for review December 4, 2025 15:56

mkzie2 requested review from a team as code owners December 4, 2025 15:56

melvin-bot bot requested review from aimane-chnaif and joekaufmanexpensify and removed request for a team and joekaufmanexpensify December 4, 2025 15:56

melvin-bot bot removed the request for review from a team December 4, 2025 15:56

mkzie2 mentioned this pull request Dec 4, 2025

[Due for payment 2025-12-31] [$250] Expenses - Android - Duplicated "Total" amount field briefly appear before the report loads #75986

Closed

8 tasks

Merge branch 'main' into mkzie2-issue/75986

35ab308

Merge branch 'main' into mkzie2-issue/75986

c2a3b82

Merge branch 'main' into mkzie2-issue/75986

96d7f59

dangrous mentioned this pull request Dec 9, 2025

Android - Reports - Report total appears twice briefly when opening the report #75933

Closed

16 tasks

aimane-chnaif approved these changes Dec 11, 2025

View reviewed changes

melvin-bot bot requested a review from puneetlath December 11, 2025 06:20

puneetlath reviewed Dec 11, 2025

View reviewed changes

mkzie2 added 2 commits December 15, 2025 18:58

add comments

7b1501f

Merge branch 'main' into mkzie2-issue/75986

0f03656

fix: update prop comment

337b758

puneetlath approved these changes Dec 22, 2025

View reviewed changes

puneetlath merged commit b2060d5 into Expensify:main Dec 22, 2025
31 checks passed

OSBotify mentioned this pull request Dec 23, 2025

Deploy Checklist: New Expensify 2025-12-23 #78313

Closed

jponikarchuk mentioned this pull request Dec 23, 2025

[Due for payment 2026-01-15] [$250] Marked as paid system message does not appear offline #78370

Closed

7 tasks

MelvinBot mentioned this pull request Feb 20, 2026

[$750] Selecting and copy / pasting multiple messages doesn't work as expected #37447

Open

6 tasks

Conversation

mkzie2 commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 4, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 4, 2025

Uh oh!

aimane-chnaif commented Dec 5, 2025

Uh oh!

mkzie2 commented Dec 8, 2025

Uh oh!

mkzie2 commented Dec 8, 2025

Uh oh!

aimane-chnaif commented Dec 8, 2025

Uh oh!

mkzie2 commented Dec 9, 2025

Uh oh!

aimane-chnaif commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkzie2 commented Dec 11, 2025

Uh oh!

puneetlath Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

puneetlath Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

mkzie2 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

puneetlath Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

mkzie2 Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 22, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

jponikarchuk commented Dec 23, 2025

Uh oh!

OSBotify commented Dec 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mkzie2 commented Dec 4, 2025 •

edited

Loading

codecov bot commented Dec 4, 2025 •

edited by github-actions bot

Loading

aimane-chnaif commented Dec 11, 2025 •

edited

Loading

aimane-chnaif commented Dec 11, 2025 •

edited

Loading