Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Code Review SummaryI've completed a comprehensive review of this PR. No issues found. What was reviewed:
Key findings:
The code follows React/React Native best practices and Expensify coding standards. Nice prep work for the upcoming To-do feature! 👍 |
JS00001
left a comment
There was a problem hiding this comment.
This is very nice, LGTM with one suggestion 😄
Reviewer Checklist
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.75-0 🚀
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.75-0 🚀
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.77-0 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀
|
Explanation of Change
Introduces a new
useTodoshook that will be used by theReports > To-dosection. Note: Currently this code is unused and is prep-work for the remaining issues in the release. We're doing this to keep the scope of PRs small.Fixed Issues
$ #73978
$ #73979
$ #73980
$ #73981
Tests
Automated tests
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari