Fix : Reports - Create report button does not show upgrade page when account has no workspace by M00rish · Pull Request #77040 · Expensify/App

M00rish · 2025-12-08T21:11:12Z

Explanation of Change

Fixed Issues

$ #73762
PROPOSAL:
Comment

Tests

Precondition: Account has self DM and no workspace

Go to self DM
Create an expense
Go to Reports > Expenses
Select the expense via checkbox
Click dropdown menu > Move expense
verify Upgrade page opens

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_Recording_20251217_184130_New.Expensify.mp4

Android: mWeb Chrome

AndroidWeb.webm

iOS: Native

IOS.webm

iOS: mWeb Safari

iosWeb.webm

MacOS: Chrome / Safari

web.webm

codecov · 2025-12-08T21:19:31Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...rc/pages/Search/SearchTransactionsChangeReport.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

…pgrade

melvin-bot · 2025-12-11T03:57:02Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify

Why wouldn't we put the upgrade modal on clicking "Create report" in the menu? That seems a little more clear as it's about "Reports". CC: @JmillsExpensify as you're on the parent issue.

JmillsExpensify · 2025-12-12T14:37:31Z

That's a fair call. I agree.

M00rish · 2025-12-15T09:56:35Z

sure will update this accordingly

M00rish · 2025-12-17T17:50:15Z

Screen_Recording_20251217_184130_New.Expensify.mp4

Hey @JmillsExpensify, would this be the expected result? just to double check, thanks

M00rish · 2025-12-18T15:36:20Z

@shubham1206agra can you review pls?

shubham1206agra · 2025-12-27T05:20:41Z

src/pages/Search/SearchPage.tsx

+                onSelected: () => {
+                    Navigation.navigate(ROUTES.MOVE_TRANSACTIONS_SEARCH_RHP);
+                },


@M00rish Why did you made this change?

good catch, fixed @shubham1206agra

src/pages/Search/SearchTransactionsChangeReport.tsx

shubham1206agra · 2025-12-30T13:05:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-30.at.6.30.35.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-12-30.at.2.14.06.PM.mov

iOS: HybridApp

Screen.Recording.2025-12-30.at.5.10.56.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-12-30.at.2.10.54.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-30.at.2.02.29.PM.mov

deetergp · 2025-12-30T19:08:28Z

LGTM. Thanks!

OSBotify · 2025-12-30T19:17:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-31T19:02:28Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.2.90-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-02T10:34:31Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.90-2 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix upgrade not showing

b45afe6

melvin-bot bot assigned M00rish Dec 8, 2025

M00rish changed the title ~~fix upgrade not showing~~ Fix : Reports - Create report button does not show upgrade page when account has no workspace Dec 8, 2025

M00rish added 2 commits December 10, 2025 02:54

lint

96c8901

Merge branch 'Expensify:main' into fixUpgrade

860470a

M00rish removed their assignment Dec 11, 2025

M00rish added 2 commits December 11, 2025 03:14

resolve conflicts

15bb37f

Merge branch 'fixUpgrade' of https://github.com/M00rish/App into fixU…

602d5b9

…pgrade

M00rish marked this pull request as ready for review December 11, 2025 03:56

M00rish requested review from a team as code owners December 11, 2025 03:56

melvin-bot bot requested review from shubham1206agra and trjExpensify and removed request for a team December 11, 2025 03:57

melvin-bot bot removed the request for review from a team December 11, 2025 03:57

trjExpensify reviewed Dec 12, 2025

View reviewed changes

M00rish added 3 commits December 16, 2025 05:57

move logic to SearchTransactionsChangeReport

93c804d

fix double screens

9e29efd

lint

8d5b2d5

shubham1206agra reviewed Dec 27, 2025

View reviewed changes

M00rish added 2 commits December 29, 2025 17:04

Merge branch 'Expensify:main' into fixUpgrade

80d9279

fix catch

d7a71c2

shubham1206agra reviewed Dec 30, 2025

View reviewed changes

src/pages/Search/SearchTransactionsChangeReport.tsx Show resolved Hide resolved

shubham1206agra approved these changes Dec 30, 2025

View reviewed changes

melvin-bot bot requested a review from deetergp December 30, 2025 14:03

deetergp approved these changes Dec 30, 2025

View reviewed changes

deetergp merged commit ae4cd7c into Expensify:main Dec 30, 2025
32 of 34 checks passed

OSBotify mentioned this pull request Dec 31, 2025

Deploy Checklist: New Expensify 2025-12-31 #78646

Closed

28 tasks

mountiny mentioned this pull request Jan 1, 2026

[CP Staging] Revert "Fix : Reports - Create report button does not show upgrade page when account has no workspace" #78759

Merged

melvin-bot bot mentioned this pull request Jan 2, 2026

[$250] Reports - Create report button does not show upgrade page when account has no workspace #73762

Open

16 tasks

M00rish mentioned this pull request Feb 24, 2026

Fix : Reports - Create report button does not show upgrade page when account has no workspace #78995

Open

53 tasks

Conversation

M00rish commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 8, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 11, 2025

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify commented Dec 12, 2025

Uh oh!

M00rish commented Dec 15, 2025

Uh oh!

M00rish commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

M00rish commented Dec 18, 2025

Uh oh!

shubham1206agra Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

M00rish Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shubham1206agra commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

deetergp commented Dec 30, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 30, 2025

Uh oh!

OSBotify commented Dec 31, 2025

Uh oh!

OSBotify commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

M00rish commented Dec 8, 2025 •

edited

Loading

codecov bot commented Dec 8, 2025 •

edited by github-actions bot

Loading

M00rish commented Dec 17, 2025 •

edited

Loading

shubham1206agra commented Dec 30, 2025 •

edited

Loading