Skip to content

Revert "Revert "Allow zero amount expenses - third try #75542""#77042

Merged
yuwenmemon merged 1 commit intomainfrom
revert-77036-revert-75542-manual
Dec 8, 2025
Merged

Revert "Revert "Allow zero amount expenses - third try #75542""#77042
yuwenmemon merged 1 commit intomainfrom
revert-77036-revert-75542-manual

Conversation

@yuwenmemon
Copy link
Contributor

Reverts #77036

@AndrewGable whoops. I accidentally merged a commit of the mobile Expensify submodule. This reverts the entire PR so that we can remove the mobile submodule change and then merge the revert again.

@yuwenmemon yuwenmemon self-assigned this Dec 8, 2025
@yuwenmemon yuwenmemon requested review from a team as code owners December 8, 2025 21:24
@melvin-bot melvin-bot bot requested review from srikarparsi and trjExpensify and removed request for a team December 8, 2025 21:24
@melvin-bot
Copy link

melvin-bot bot commented Dec 8, 2025

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team December 8, 2025 21:24
@yuwenmemon yuwenmemon merged commit 57be63f into main Dec 8, 2025
31 of 33 checks passed
@yuwenmemon yuwenmemon deleted the revert-77036-revert-75542-manual branch December 8, 2025 21:25
@melvin-bot
Copy link

melvin-bot bot commented Dec 8, 2025

@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Dec 8, 2025
@yuwenmemon
Copy link
Contributor Author

Not an emergency. This is a straight revert

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 85.84% <ø> (ø)
...ents/ReportActionItem/TransactionPreview/index.tsx 84.37% <100.00%> (ø)
src/components/TransactionItemRow/index.tsx 86.90% <100.00%> (ø)
src/libs/DistanceRequestUtils.ts 81.34% <100.00%> (ø)
src/libs/SearchUIUtils.ts 73.15% <100.00%> (ø)
src/libs/TransactionPreviewUtils.ts 74.71% <100.00%> (+1.52%) ⬆️
src/libs/Violations/ViolationsUtils.ts 67.38% <100.00%> (-0.62%) ⬇️
src/libs/actions/IOU.ts 64.18% <100.00%> (-0.25%) ⬇️
src/libs/actions/Policy/Member.ts 73.25% <ø> (ø)
...es/iou/request/step/IOURequestStepConfirmation.tsx 49.33% <100.00%> (ø)
... and 15 more
... and 6 files with indirect coverage changes

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@IuliiaHerets
Copy link

@yuwenmemon do we need to QA this?

@OSBotify
Copy link
Contributor

OSBotify commented Dec 9, 2025

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.2.74-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

1 similar comment
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants