Skip to content

Revert "Revert "Allow zero amount expenses - third try #75542""" - Second Try 🤣 #77043

Merged
yuwenmemon merged 1 commit intomainfrom
revert-77042-revert-77036-revert-75542-manual
Dec 8, 2025
Merged

Revert "Revert "Allow zero amount expenses - third try #75542""" - Second Try 🤣 #77043
yuwenmemon merged 1 commit intomainfrom
revert-77042-revert-77036-revert-75542-manual

Conversation

@yuwenmemon
Copy link
Contributor

@yuwenmemon yuwenmemon commented Dec 8, 2025 •
edited
Loading

This is the same as #77036, but without the Mobile-Expensify submodule accidentally committed

@yuwenmemon yuwenmemon self-assigned this Dec 8, 2025
@yuwenmemon yuwenmemon requested review from a team as code owners December 8, 2025 21:32
@melvin-bot melvin-bot bot requested review from heyjennahay and nkuoch and removed request for a team December 8, 2025 21:32
@melvin-bot
Copy link

melvin-bot bot commented Dec 8, 2025

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

AndrewGable
AndrewGable approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@AndrewGable AndrewGable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked, no Mobile-Expensify changes 👍

@yuwenmemon yuwenmemon merged commit 54fe69b into main Dec 8, 2025
30 of 34 checks passed
@yuwenmemon yuwenmemon deleted the revert-77042-revert-77036-revert-75542-manual branch December 8, 2025 21:35
@melvin-bot
Copy link

melvin-bot bot commented Dec 8, 2025

@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Dec 8, 2025
OSBotify pushed a commit that referenced this pull request Dec 8, 2025
@yuwenmemon @OSBotify
Merge pull request #77043 from Expensify/revert-77042-revert-77036-re…
28fba4b 
…vert-75542-manual

Revert "Revert "Allow zero amount expenses - third try #75542""" - Second Try 🤣

(cherry picked from commit 54fe69b)

(cherry-picked to staging by yuwenmemon)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025 •
edited by github-actions bot
Loading

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 85.84% <ø> (ø)
...ents/ReportActionItem/TransactionPreview/index.tsx 84.37% <100.00%> (ø)
src/components/TransactionItemRow/index.tsx 86.90% <100.00%> (ø)
src/libs/DistanceRequestUtils.ts 81.34% <100.00%> (ø)
src/libs/SearchUIUtils.ts 73.15% <100.00%> (ø)
src/libs/TransactionUtils/index.ts 71.28% <100.00%> (-0.37%) ⬇️
src/libs/Violations/ViolationsUtils.ts 68.00% <100.00%> (ø)
src/libs/actions/IOU.ts 64.43% <100.00%> (-0.03%) ⬇️
src/libs/actions/Policy/Member.ts 73.25% <ø> (ø)
...rc/pages/iou/request/step/IOURequestStepAmount.tsx 5.55% <ø> (+0.06%) ⬆️
... and 15 more
... and 11 files with indirect coverage changes

@OSBotify OSBotify mentioned this pull request Dec 8, 2025
Closed
73 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2025

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.2.73-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 9, 2025

🚀 Deployed to production by https://github.com/thienlnam in version: 9.2.73-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 9, 2025

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.2.74-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@OSBotify
Copy link
Contributor

OSBotify commented Dec 10, 2025

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

1 similar comment
@OSBotify
Copy link
Contributor

OSBotify commented Dec 10, 2025

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Dec 10, 2025

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

@heyjennahay heyjennahay Awaiting requested review from heyjennahay

@nkuoch nkuoch Awaiting requested review from nkuoch

Assignees

@yuwenmemon yuwenmemon

Labels

CP Staging marks PRs that have been CP'd to staging Emergency

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuwenmemon @OSBotify @AndrewGable