[No QA] fix(ci/prettier): Export 'hasAction' is not defined by gelocraft · Pull Request #77194 · Expensify/App

gelocraft · 2025-12-10T00:59:24Z

Explanation of Change

fix(ci/prettier): Export 'hasAction' is not defined

Fixed Issues

$ #77189
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2025-12-10T01:17:39Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

gelocraft · 2025-12-10T01:17:46Z

Closes #77189

.github/workflows/prettier.yml

src/types/expo-store-review.d.ts

marcaaron · 2025-12-10T02:05:10Z

.github/workflows/prettier.yml

-            # shellcheck disable=SC2016
-            echo 'Error: Prettier diff detected! Please run `npm run prettier` and commit the changes.'
-            exit 1
-          fi


hmm I don't think we want to remove all of this. We should still be logging when there is a diff and ideally also log the diff.

ok I'll restore it to its previous state

Maybe better to do npm run prettier -- --log-level error here but make sure that it echo's the same message if there is output.

marcaaron · 2025-12-10T02:12:50Z

src/types/expo-store-review.d.ts

    function isAvailableAsync(): Promise<boolean>;
    function requestReview(): Promise<void>;

-    export {hasAction, isAvailableAsync, requestReview};


I don't understand why this would cause an error one way but not the other way.

Seems like a prettier bug maybe?

because in declare block you're not actually defining the code, you only describe it shape that's why we get this error Export 'hasAction' is not defined

marcaaron · 2025-12-10T02:13:32Z

.github/workflows/prettier.yml

-            # shellcheck disable=SC2016
-            echo 'Error: Prettier diff detected! Please run `npm run prettier` and commit the changes.'
-            exit 1
-          fi


Maybe better to do npm run prettier -- --log-level error here but make sure that it echo's the same message if there is output.

marcaaron

LGTM. Thanks! Weird bug. Prettier parser should not be throwing this error I think. But the change looks good.

codecov · 2025-12-10T02:23:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 21 files with indirect coverage changes

marcaaron · 2025-12-10T02:24:18Z

We can skip the checklist on this one since this isn't changing any code. Thanks @gelocraft 🙇

gelocraft · 2025-12-10T02:25:38Z

looks like typecheck failed but the error is unrelated

marcaaron · 2025-12-10T02:31:09Z

I feel like maybe we should do:

    "prettier": "prettier --write . --log-level error",

in package.json, but NAB. If you see the error then run prettier some people will be confused 😄

gelocraft · 2025-12-10T02:33:23Z

I feel like maybe we should do:
    "prettier": "prettier --write . --log-level error",
in package.json, but NAB. If you see the error then run prettier some people will be confused 😄

let's just leave the logging thing to CI

marcaaron · 2025-12-10T02:34:22Z

let's just leave the logging thing to CI

it's fair. some probably want to get hypnotized by the thousand files scrolling past them 👍

gelocraft · 2025-12-10T02:34:28Z

ESLint check is almost done

melvin-bot · 2025-12-10T02:42:30Z

@marcaaron looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

marcaaron · 2025-12-10T02:42:35Z

Not emergency. typescript errors are unrelated.

OSBotify · 2025-12-10T22:08:02Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-11T00:01:26Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-12T19:03:34Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.2.77-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-12T22:08:08Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned gelocraft Dec 10, 2025

gelocraft force-pushed the fix-prettier-workflow-failure branch 2 times, most recently from e309e3f to 5a3466e Compare December 10, 2025 01:11

fix(ci/prettier): Export 'hasAction' is not defined

5625a10

gelocraft force-pushed the fix-prettier-workflow-failure branch from 5a3466e to 5625a10 Compare December 10, 2025 01:17

gelocraft marked this pull request as ready for review December 10, 2025 01:17

gelocraft requested review from a team as code owners December 10, 2025 01:17

melvin-bot bot requested review from heyjennahay and jayeshmangwani and removed request for a team and heyjennahay December 10, 2025 01:17

melvin-bot bot removed the request for review from a team December 10, 2025 01:17

github-actions bot reviewed Dec 10, 2025

View reviewed changes

.github/workflows/prettier.yml Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 10, 2025

View reviewed changes

src/types/expo-store-review.d.ts Show resolved Hide resolved

github-actions bot reviewed Dec 10, 2025

View reviewed changes

src/types/expo-store-review.d.ts Show resolved Hide resolved

gelocraft force-pushed the fix-prettier-workflow-failure branch 4 times, most recently from 8810950 to 5625a10 Compare December 10, 2025 01:39

gelocraft mentioned this pull request Dec 10, 2025

[$125] [Due for payment 2025-12-19] Investigate workflow job failing on main: prettier / Prettier check #77189

Closed

marcaaron reviewed Dec 10, 2025

View reviewed changes

marcaaron requested changes Dec 10, 2025

View reviewed changes

restore: restore to previous state

d6dc9e3

gelocraft requested a review from marcaaron December 10, 2025 02:19

marcaaron approved these changes Dec 10, 2025

View reviewed changes

marcaaron removed the request for review from jayeshmangwani December 10, 2025 02:24

marcaaron merged commit 3eca92a into Expensify:main Dec 10, 2025
28 of 32 checks passed

melvin-bot bot added the Emergency label Dec 10, 2025

marcaaron removed the Emergency label Dec 10, 2025

marcaaron mentioned this pull request Dec 10, 2025

[$250] Enable no-array-for-each lint rule #67422

Closed

gelocraft changed the title ~~fix(ci/prettier): Export 'hasAction' is not defined~~ [No QA] fix(ci/prettier): Export 'hasAction' is not defined Dec 10, 2025

OSBotify mentioned this pull request Dec 10, 2025

Deploy Checklist: New Expensify 2025-12-10 #77285

Closed

94 tasks

Conversation

gelocraft commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 10, 2025

Uh oh!

gelocraft commented Dec 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcaaron Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

gelocraft Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

marcaaron Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

marcaaron Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

marcaaron Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

gelocraft Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

marcaaron Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

marcaaron left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 10, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

marcaaron commented Dec 10, 2025

Uh oh!

gelocraft commented Dec 10, 2025

Uh oh!

marcaaron commented Dec 10, 2025

Uh oh!

gelocraft commented Dec 10, 2025

Uh oh!

marcaaron commented Dec 10, 2025

Uh oh!

gelocraft commented Dec 10, 2025

Uh oh!

Uh oh!

melvin-bot bot commented Dec 10, 2025

Uh oh!

marcaaron commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 11, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gelocraft commented Dec 10, 2025 •

edited

Loading

codecov bot commented Dec 10, 2025 •

edited by github-actions bot

Loading