Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/ReportAddApproverPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ function ReportAddApproverPage({report, isLoadingReportData, policy}: ReportAddA
reportNextStep,
);
Navigation.dismissModal();
}, [allApprovers, selectedApproverEmail, report, currentUserDetails.accountID, currentUserDetails.email, policy, hasViolations, isASAPSubmitBetaEnabled]);
}, [allApprovers, selectedApproverEmail, report, currentUserDetails.accountID, currentUserDetails.email, policy, hasViolations, isASAPSubmitBetaEnabled, reportNextStep]);

const button = useMemo(() => {
return (
Expand Down
2 changes: 1 addition & 1 deletion src/pages/ReportChangeApproverPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ function ReportChangeApproverPage({report, policy, isLoadingReportData}: ReportC
}
assignReportToMe(report, currentUserDetails.accountID, currentUserDetails.email ?? '', policy, hasViolations, isASAPSubmitBetaEnabled, reportNextStep);
Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(reportID));
}, [selectedApproverType, report, currentUserDetails.accountID, currentUserDetails.email, policy, hasViolations, isASAPSubmitBetaEnabled, reportID]);
}, [selectedApproverType, report, currentUserDetails.accountID, currentUserDetails.email, policy, hasViolations, isASAPSubmitBetaEnabled, reportNextStep, reportID]);

const approverTypes = useMemo(() => {
const data: Array<ListItem<ApproverType>> = [
Expand Down
1 change: 0 additions & 1 deletion src/pages/Search/SearchPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,6 @@ function SearchPage({route}: SearchPageProps) {
dismissedHoldUseExplanation,
dismissedRejectUseExplanation,
areAllTransactionsFromSubmitter,
currentUserPersonalDetails?.login,
]);

const handleDeleteExpenses = () => {
Expand Down
1 change: 1 addition & 0 deletions tests/unit/Search/SearchContextTest.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const mockSelectedTransaction: SelectedTransactionInfo = {
const mockTransaction: TransactionListItemType = {
accountID: 1,
amount: 0,
canDelete: true,
category: '',
groupAmount: 1284,
groupCurrency: 'USD',
Expand Down
Loading