[Policy Change Logs] Implement policy change log for: Overview - Setting Company address

[rayane-d]

Explanation of Change

This PR adds policy change log report actions (system messages in the workspace #admins room's system messages thread) for when the company address is set or updated in workspace settings.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/568306
PROPOSAL:

Tests

Prerequisites

• A workspace
• Admin access to the workspace
• Go to workspace settings
• Make any change that generates a changelog (e.g., rename the workspace) twice to ensure system messages thread exists
• Go to the workspace #admins room
• Verify that a system messages thread is created

---

Test Cases

Test 1: Set Company Address for the First Time

Steps:

1. Navigate to Settings > Workspaces > [Your Workspace] > Overview
2. Click on the Company address field (should be empty)
3. Enter a complete US address:
   • Street 1: 123 William Street
   • Street 2: Suite 500
   • City: New York
   • State: NY
   • Zip Code: 10038
   • Country: United States
4. Save the address
5. Navigate to the #admins room
6. Open the system messages thread

Expected Results:

• A changelog entry appears in the system messages thread in the #admins room
• Message format: set the company address to "123 William Street, Suite 500, New York, NY 10038"
• The format matches: street1, street2, city, state zipCode (note: state and zipCode are space-separated)
• The LHN sidebar preview shows the correct changelog message text
• Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
• Change app language, and verify that the changelog message is translated as expected
• Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

Note on address style:

• Street 1 and Street 2 are comma-separated
• City is comma-separated from street
• State/Province is comma-separated from City
• State/Province and Zip/Postal Code are space-separated (not comma-separated)
• Country is not included in the formatted display

Screen.Recording.2025-12-11.at.12.33.36.AM.mov

---

Test 2: Update Company Address

Precondition: A company address has already been set (from Test 1).

Steps:

1. Navigate to Settings > Workspaces > [Your Workspace] > Overview
2. Click on the existing Company address field
3. Update the address to a Canadian address:
   • Street 1: 123 Great Gulf Drive
   • Street 2: Suite 500
   • City: Vaughan
   • State/Province: ON
   • Postal Code: L4K 5V1
   • Country: Canada
4. Save the address
5. Navigate to the #admins room
6. Open the system messages thread

Expected Results:

• A changelog entry appears in the system messages thread in the #admins room
• Message format: changed the company address to "123 Great Gulf Drive, Suite 500, Vaughan, ON L4K 5V1" (previously "123 William Street, Suite 500, New York, NY 10038")
• The address is formatted exactly the same as the Company address field (menu item) in the workspace settings overview page
• Both new and previous addresses are shown in the correct format
• The LHN sidebar preview shows the correct changelog message text
• Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
• Change app language, and verify that the changelog message is translated as expected
• Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

Screen.Recording.2025-12-11.at.12.34.15.AM.mov

---

Test 3: Set Address Without Secondary Street Line

Steps:

1. Navigate to Settings > Workspaces > [Your Workspace] > Overview
2. Click on the Company address field
3. Enter an address without a secondary street line:
   • Street 1: 456 Main Avenue
   • Street 2: (leave empty)
   • City: San Francisco
   • State: CA
   • Zip Code: 94102
   • Country: United States
4. Save the address
5. Navigate to the #admins room
6. Open the system messages thread

Expected Results:

• A changelog entry appears in the system messages thread
• Message format without street 2: set the company address to "456 Main Avenue, San Francisco, CA 94102" or changed the company address to "456 Main Avenue, San Francisco, CA 94102" (previously "...")
• The address is formatted exactly the same as the Company address field (menu item) in the workspace settings overview page
• No extra comma appears where street 2 would be
• The LHN sidebar preview shows the correct changelog message text
• Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
• Change app language, and verify that the changelog message is translated as expected
• Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

Screen.Recording.2025-12-11.at.12.35.05.AM.mov

---

Test 4: Update Address - Change Only One Field

Precondition: A company address has already been set.

Steps:

1. Navigate to Settings > Workspaces > [Your Workspace] > Overview
2. Click on the existing Company address field
3. Change only the city (e.g., from San Francisco to Oakland)
4. Keep all other fields the same
5. Save the address
6. Navigate to the #admins room
7. Open the system messages thread

Expected Results:

• A changelog entry appears showing the full address change
• Message shows both complete addresses (new and previous)
• The address is formatted exactly the same as the Company address field (menu item) in the workspace settings overview page
• The LHN sidebar preview shows the correct changelog message text
• Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly

Screen.Recording.2025-12-11.at.12.36.16.AM.mov

---

Test 5: No Changelog When Address Unchanged

Precondition: A company address has already been set.

Steps:

1. Navigate to Settings > Workspaces > [Your Workspace] > Overview
2. Click on the existing Company address field
3. Make NO changes
4. Save the address
5. Navigate to the #admins room
6. Open the system messages thread

Expected Results:

• No new changelog entry should be created if the address hasn't changed

Screen.Recording.2025-12-11.at.12.36.49.AM.mov

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	83.47% <ø> (ø)
src/libs/ReportUtils.ts	73.05% <50.00%> (-0.06%)	⬇️
src/libs/SidebarUtils.ts	80.70% <50.00%> (-0.13%)	⬇️
src/pages/home/report/PureReportActionItem.tsx	52.66% <50.00%> (-0.01%)	⬇️
...ges/home/report/ContextMenu/ContextMenuActions.tsx	0.77% <0.00%> (-0.01%)	⬇️
src/libs/ReportActionsUtils.ts	53.30% <90.32%> (+0.72%)	⬆️
... and 13 files with indirect coverage changes

[melvin-bot]

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[rayane-d]

Hmm… I'm not sure why Melvin assigned two C+ reviewers

[rayane-d]

Resolved merge conflicts

[jasperhuangg]

@brunovjk yes please review! sorry that wasn't clear

[brunovjk]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

77287_android_native.mov

Android: mWeb Chrome

iOS: HybridApp

77287_ios_native.mov

iOS: mWeb Safari

77287_ios_web.mov

MacOS: Chrome / Safari

77287_web_chrome.mov

[brunovjk]

@rayane-d we still have some conflicts here. We also have some warnings related to "ESLint check" and "typecheck" in the tests you created. Can you resolve them? So far everything seems ok to me. I need to leave now, I'll be back to review it first thing tomorrow. Thank you.

[brunovjk]

Friendly bump @rayane-d, thank you.

[rayane-d]

@brunovjk - I've resolved the conflicts and fixed the failing checks

[jasperhuangg]

@rayane-d more conflicts 😢

[rayane-d]

resolved the conflicts

[brunovjk]

Great job @rayane-d. LGTM

[melvin-bot]

🎯 @brunovjk, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #79103.

[jasperhuangg]

lgtm, is the failing jest unit test related?

also @heyjennahay all yours for the product review!

[rayane-d]

is the failing jest unit test related?

It seems unrelated; the tests pass after merging the main branch

[heyjennahay]

Product change LGTM

[jasperhuangg]

Nice! Thanks for your patience with this one @rayane-d

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.3.1-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.1-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅