fix: After editing expense details, page not scrolled and focused to system message by nkdengineer · Pull Request #77318 · Expensify/App

nkdengineer · 2025-12-11T05:16:26Z

Explanation of Change

Fixed Issues

$ #75344
PROPOSAL: #75344 (comment)

Tests

Open a workspace chat
Submit an expense
Edit description/merchant/tag/category/date/amount/currency/distance rate/tax
Verify that the page is scrolled to bottom

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-11.at.12.07.44.mov

Android: mWeb Chrome

Screen.Recording.2025-12-11.at.12.06.42.mov

iOS: Native

Screen.Recording.2025-12-11.at.12.09.25.mov

iOS: mWeb Safari

Screen.Recording.2025-12-11.at.12.08.26.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-11.at.12.05.12.mov

Screen.Recording.2026-01-08.at.21.49.07.mov

…system message

codecov · 2025-12-11T05:24:14Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/Navigation/Navigation.ts	`55.77% <100.00%> (+0.40%)`	⬆️
src/libs/actions/IOU/index.ts	`72.13% <100.00%> (+1.60%)`	⬆️
...rc/libs/Navigation/getSearchTopmostReportParams.ts	`0.00% <0.00%> (ø)`
... and 15 files with indirect coverage changes

melvin-bot · 2025-12-11T05:49:53Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2025-12-16T14:08:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-26.at.3.18.12.AM.mov

situchan · 2025-12-25T05:51:25Z

@nkdengineer please fix conflict

nkdengineer · 2025-12-25T06:13:27Z

Fixed

situchan · 2025-12-26T11:53:12Z

shouldEnableAutoScroll has a limit threshold, so it doesn't work if the scroll offset is larger.

App/src/hooks/useFlatListScrollKey.ts

Line 128 in 3952b89

config.autoscrollToTopThreshold = AUTOSCROLL_TO_TOP_THRESHOLD;

I don't think this is the root cause.
The bug is still reproducible after increasing this value to large. (i.e. AUTOSCROLL_TO_TOP_THRESHOLD = 2500)

situchan · 2025-12-26T12:13:13Z

I asked for clarification here.

situchan · 2025-12-30T16:26:30Z

@nkdengineer please fix conflict

situchan · 2025-12-30T16:40:14Z

You added 6 notifyNewAction total but test case is only one.
Can you add all test cases affected by this change?

src/libs/Navigation/getSearchTopmostReportParams.ts

situchan · 2026-01-12T07:25:56Z

Please merge main again. It fixes failing test job 4

nkdengineer · 2026-01-16T07:36:51Z

Can you please check other fields like distance, rate, tax, billable, reimbursable, etc and apply fix if applicable?

Updated for rate/tax.
For distance, we don't create a modified message offline so we don't need to scroll to the bottom
For billable, reimbursable. It's a toggle, so it's better to keep the view in this field.

situchan · 2026-01-22T17:53:33Z

Please fix conflict

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ef017baf4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/Navigation/getSearchTopmostReportParams.ts

situchan

@nkdengineer there's missing case

Screen.Recording.2026-01-26.at.3.20.27.AM.mov

nkdengineer · 2026-01-27T07:45:29Z

@situchan Updated.

situchan · 2026-01-27T07:48:51Z

Prettier check / Prettier check (pull_request)
Prettier check / Prettier check (pull_request)Failing after 1m

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0616fb06a9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-27T08:02:03Z

src/libs/actions/IOU/index.ts

    }
    const {params, onyxData} = data;
    params.description = parsedComment;
+    notifyNewAction(Navigation.getSearchTopmostReportId(), currentUserAccountIDParam);


Pass modified reportAction to notifyNewAction

The new notifyNewAction calls don’t pass the modified report action created in getUpdateMoneyRequestParams. In MoneyRequestReportActionsList.scrollToBottomForCurrentUserAction, the scroll is skipped unless reportAction.actionName === ADD_COMMENT, so a MODIFIED_EXPENSE system action (the edit result) won’t trigger the scroll on money request/expense reports. This means editing expense details still won’t scroll to the system message in those views; consider passing the optimistic modified action or broadening the scroll predicate for edit actions.

Useful? React with 👍 / 👎.

Please check if this makes sense

@situchan MoneyRequestReportActionsList is displayed in the expense report with multiple transaction so it isn't a valid case here.

blimpich · 2026-01-27T19:26:22Z

@nkdengineer can we add test coverage so that we're not reducing coverage as shown here?

nkdengineer · 2026-01-29T16:00:12Z

@blimpich I updated.

blimpich · 2026-01-29T17:45:10Z

Thank you!

tests/actions/IOUTest.ts

OSBotify · 2026-02-02T17:41:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-03T02:13:50Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.11-19 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-05T20:16:47Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

fix: After editing expense details, page not scrolled and focused to …

1655a9c

…system message

melvin-bot bot assigned nkdengineer Dec 11, 2025

fix lint

afe49fa

nkdengineer marked this pull request as ready for review December 11, 2025 05:49

nkdengineer requested review from a team as code owners December 11, 2025 05:49

melvin-bot bot requested review from heyjennahay and situchan and removed request for a team December 11, 2025 05:49

melvin-bot bot removed the request for review from a team December 11, 2025 05:49

resolve conflict

257b7e4

nkdengineer added 2 commits December 16, 2025 21:23

resolve conflict

d66a729

Merge branch 'main' into fix/75344

3b367cb

nkdengineer added 2 commits December 25, 2025 12:53

merge main

a44d1e7

resolve conflict

6ef29f9

Merge branch 'main' into fix/75344

4f7fcdb

situchan reviewed Dec 30, 2025

View reviewed changes

src/libs/Navigation/getSearchTopmostReportParams.ts Show resolved Hide resolved

nkdengineer added 3 commits January 6, 2026 00:38

Merge branch 'main' into fix/75344

d412e14

resolve conflict

17bc195

Merge branch 'main' into fix/75344

d17b6ed

nkdengineer added 2 commits January 16, 2026 14:24

Merge branch 'main' into fix/75344

ce5fff4

update super wide RHP case

7462731

resolve conflict

3ef017b

situchan approved these changes Jan 25, 2026

View reviewed changes

melvin-bot bot requested a review from blimpich January 25, 2026 21:09

chatgpt-codex-connector bot reviewed Jan 25, 2026

View reviewed changes

src/libs/Navigation/getSearchTopmostReportParams.ts Outdated Show resolved Hide resolved

situchan suggested changes Jan 25, 2026

View reviewed changes

nkdengineer added 2 commits January 27, 2026 14:31

Merge branch 'main' into fix/75344

ee411e9

add search money report case

0616fb0

run prettier

18aebd7

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

situchan approved these changes Jan 27, 2026

View reviewed changes

nkdengineer added 2 commits January 29, 2026 22:29

Merge branch 'main' into fix/75344

69e6928

add unit tét

93a0852

blimpich requested changes Jan 29, 2026

View reviewed changes

tests/actions/IOUTest.ts Outdated Show resolved Hide resolved

nkdengineer added 2 commits February 2, 2026 15:36

Merge branch 'main' into fix/75344

4469447

remove comment

1bce528

blimpich approved these changes Feb 2, 2026

View reviewed changes

blimpich merged commit 30d0732 into Expensify:main Feb 2, 2026
30 checks passed

OSBotify mentioned this pull request Feb 3, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

Conversation

nkdengineer commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 11, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 11, 2025

Uh oh!

situchan commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Dec 25, 2025

Uh oh!

nkdengineer commented Dec 25, 2025

Uh oh!

situchan commented Dec 26, 2025

Uh oh!

situchan commented Dec 26, 2025

Uh oh!

situchan commented Dec 30, 2025

Uh oh!

situchan commented Dec 30, 2025

Uh oh!

Uh oh!

situchan commented Jan 12, 2026

Uh oh!

nkdengineer commented Jan 16, 2026

Uh oh!

situchan commented Jan 22, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented Jan 27, 2026

Uh oh!

situchan commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

situchan Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

nkdengineer Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

blimpich commented Jan 27, 2026

Uh oh!

nkdengineer commented Jan 29, 2026

Uh oh!

blimpich commented Jan 29, 2026

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Feb 2, 2026

Uh oh!

OSBotify commented Feb 3, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

nkdengineer commented Dec 11, 2025 •

edited

Loading

codecov bot commented Dec 11, 2025 •

edited by github-actions bot

Loading

situchan commented Dec 16, 2025 •

edited

Loading