Skip to content

[No QA] [React Compiler Compliance Check]fix: Only show warnings for regular React compiler errors in Phase 1 #77442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 2 commits into from
Dec 15, 2025
Merged

[No QA] [React Compiler Compliance Check]fix: Only show warnings for regular React compiler errors in Phase 1 #77442

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a150241
fix: only show warnings for regular React compiler errors
chrispader Dec 11, 2025
89790e0
fix: show success message if only warnings are shown
chrispader Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions scripts/react-compiler-compliance-check.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,12 @@ async function check({
}
}

printResults(results, {shouldPrintSuccesses, shouldPrintSuppressedErrors});
const isPassed = printResults(results, {shouldPrintSuccesses, shouldPrintSuppressedErrors});

if (shouldGenerateReport) {
generateReport(results, reportFileName);
}

const isPassed = results.failures.size === 0 && (results.enforcedAddedComponentFailures?.size ?? 0) === 0;
return isPassed;
}

Expand Down Expand Up @@ -622,7 +621,7 @@ function findManualMemoizationMatches(source: string): ManualMemoizationMatch[]
function printResults(
{success, failures, suppressedFailures, enforcedAddedComponentFailures}: CompilerResults,
{shouldPrintSuccesses, shouldPrintSuppressedErrors}: PrintResultsOptions,
): void {
): boolean {
if (shouldPrintSuccesses && success.size > 0) {
log();
logSuccess(`Successfully compiled ${success.size} files with React Compiler:`);
Expand Down Expand Up @@ -665,23 +664,26 @@ function printResults(

const hasEnforcedAddedComponentFailures = enforcedAddedComponentFailures && enforcedAddedComponentFailures.size > 0;

const isPassed = failures.size === 0 && !hasEnforcedAddedComponentFailures;
if (isPassed) {
logSuccess('All files pass React Compiler compliance check!');
return;
}

const distinctFileNames = new Set<string>();
for (const failure of failures.values()) {
distinctFileNames.add(failure.file);
}

if (distinctFileNames.size > 0) {
const shouldPrintWarnings = distinctFileNames.size > 0;

if (shouldPrintWarnings) {
log();
logError(`Failed to compile ${distinctFileNames.size} files with React Compiler:`);
logWarn(`Failed to compile ${distinctFileNames.size} files with React Compiler:`);
log();

printFailures(failures);

log();
logWarn('React Compiler errors were printed as warnings for transparency, but these must NOT be fixed and can be ignored.');
}

if (shouldPrintWarnings && !hasEnforcedAddedComponentFailures) {
log();
}

if (hasEnforcedAddedComponentFailures) {
Expand All @@ -704,8 +706,16 @@ function printResults(
}
}

const isPassed = !hasEnforcedAddedComponentFailures;
if (isPassed) {
logSuccess(`React Compiler compliance check passed ${shouldPrintWarnings ? 'with warnings' : ''}!`);
return true;
}

log();
logError('The files above failed the React Compiler compliance check. Please fix the issues and run the check again...');

return false;
}

function printFailures(failuresToPrint: FailureMap, level = 0) {
Expand Down
Loading