[Policy Change Logs] Implement policy change log for: Taxes - set/change default tax rates, change custom tax name by rayane-d · Pull Request #77474 · Expensify/App

rayane-d · 2025-12-12T00:54:21Z

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/568318
PROPOSAL:

Tests

Prerequisites

A workspace
Admin access to the workspace
Go to workspace settings
Make any change that generates a changelog (e.g., rename the workspace) twice to ensure the system messages thread exists
Go to the workspace #admins room
Verify that a system messages thread is created

Test Steps 1

Steps:

Navigate to Settings > Workspaces > [Your Workspace] > More features
Enable Taxes
Navigate to Settings > Workspaces > [Your Workspace] > Taxes
Add some taxes
Click on the Settings button in the top right
Click on the Custom tax name field
Change the custom name
Save it
Navigate to the #admins room
Open the system messages thread

Expected Results:

A changelog entry appears in the system messages thread in the #admins room
Message format: changed the custom tax name to "Tax 1" (previously "Tax")
The format matches: changed the custom tax name to "NewValue" (previously "OldValue")
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

Test Steps 2

Navigate to Settings > Workspaces > [Your Workspace] > Taxes
Click on the Settings button in the top right
Click on the Workspace currency default field
Change the default tax
Navigate to the #admins room
Open the system messages thread

Expected Results:

A changelog entry appears in the system messages thread in the #admins room
Message format: changed the workspace currency default tax to "Tax Rate 1" (previously "Tax exempt")
The format matches: changed the workspace currency default tax to "NewValue" (previously "OldValue")
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

Test Steps 3

Navigate to Settings > Workspaces > [Your Workspace] > Taxes
Click on the Settings button in the top right
Click on the Foreign currency default field
Change the default tax
Navigate to the #admins room
Open the system messages thread

Expected Results:

A changelog entry appears in the system messages thread in the #admins room
Message format: changed the default tax for foreign currency to "Tax Rate 1" (previously "Tax exempt")
The format matches: changed the default tax for foreign currency to "NewValue" (previously "OldValue")
The LHN sidebar preview shows the correct changelog message text
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
Change app language, and verify that the changelog message is translated as expected
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…, change custom tax name

melvin-bot · 2025-12-12T00:54:28Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2025-12-12T01:03:04Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`83.47% <ø> (ø)`
src/libs/SidebarUtils.ts	`80.70% <50.00%> (-0.39%)`	⬇️
src/pages/home/report/PureReportActionItem.tsx	`51.71% <50.00%> (-0.02%)`	⬇️
src/libs/ReportActionsUtils.ts	`49.47% <0.00%> (-0.50%)`	⬇️
... and 9 files with indirect coverage changes

melvin-bot · 2025-12-12T01:22:10Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify

Good from a product perspective

rayane-d · 2025-12-16T14:04:01Z

Updated the copy based on this discussion: https://expensify.slack.com/archives/C086VHWPPUM/p1765578894637099?thread_ts=1761860374.858489&cid=C086VHWPPUM

rayane-d · 2025-12-16T14:10:06Z

Resolved merge conflicts

rayane-d · 2025-12-16T23:20:38Z

Asked for translations confirmation: https://expensify.slack.com/archives/C01GTK53T8Q/p1765927080539349

rayane-d · 2025-12-24T19:45:35Z

Fixed the Typescript error

madmax330 · 2026-01-02T15:22:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2026-01-02T15:34:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-02T23:30:24Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.2.92-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…hangelogs" This reverts commit 21af0fb, reversing changes made to 40dbb46.

[CP Staging] Revert "Merge pull request #77474 from rayane-d/policy-tax-settings-c…

[CP Staging] Revert "Merge pull request #77474 from rayane-d/policy-tax-settings-c… (cherry picked from commit 1214a4d) (cherry-picked to staging by mountiny)

OSBotify · 2026-01-05T16:00:33Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.92-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-05T16:31:46Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.2.93-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-06T13:39:27Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.93-1 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…changelogs [Policy Change Logs] Implement policy change log for: Taxes - set/change default tax rates, change custom tax name

…ettings-changelogs" This reverts commit 21af0fb, reversing changes made to 40dbb46.

[CP Staging] Revert "Merge pull request Expensify#77474 from rayane-d/policy-tax-settings-c…

rayane-d added 2 commits December 12, 2025 01:52

Implement policy change log for: Taxes - set/change default tax rates…

adc8239

…, change custom tax name

add translations

53085ef

melvin-bot bot assigned rayane-d Dec 12, 2025

prettier

76c910e

rayane-d requested a review from madmax330 December 12, 2025 01:21

rayane-d marked this pull request as ready for review December 12, 2025 01:22

rayane-d requested review from a team as code owners December 12, 2025 01:22

melvin-bot bot requested review from akinwale and removed request for a team December 12, 2025 01:22

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team December 12, 2025 01:22

joekaufmanexpensify previously approved these changes Dec 12, 2025

View reviewed changes

rayane-d added 3 commits December 16, 2025 14:52

update copy

bab6e60

remove translations in order to update them

f91134f

update translations

debdf89

rayane-d dismissed joekaufmanexpensify’s stale review via debdf89 December 16, 2025 14:01

Merge branch 'main' into policy-tax-settings-changelogs

1ec3afc

rayane-d added 2 commits December 24, 2025 20:37

Merge branch 'Expensify:main' into policy-tax-settings-changelogs

4a57cfc

fix typescript error

01ab927

Merge branch 'main' into policy-tax-settings-changelogs

2e14dd1

rayane-d changed the title ~~[Hold Web-E#49812] [Policy Change Logs] Implement policy change log for: Taxes - set/change default tax rates, change custom tax name~~ [Policy Change Logs] Implement policy change log for: Taxes - set/change default tax rates, change custom tax name Jan 2, 2026

rayane-d added 2 commits January 2, 2026 11:16

Merge branch 'Expensify:main' into policy-tax-settings-changelogs

fed992a

fix failing check

67f45d5

madmax330 approved these changes Jan 2, 2026

View reviewed changes

madmax330 merged commit 21af0fb into Expensify:main Jan 2, 2026
31 checks passed

rayane-d deleted the policy-tax-settings-changelogs branch January 2, 2026 15:26

OSBotify mentioned this pull request Jan 2, 2026

Deploy Checklist: New Expensify 2026-01-02 #78798

Closed

17 tasks

This was referenced Jan 3, 2026

[Due for payment 2026-01-13] [Due for payment 2026-01-12] Taxes - A change log entry appears without any change #78804

Closed

[$250] Taxes - The copied change message text does not matches the translated text #78806

Closed

mountiny added a commit that referenced this pull request Jan 5, 2026

Revert "Merge pull request #77474 from rayane-d/policy-tax-settings-c…

f198cbc

…hangelogs" This reverts commit 21af0fb, reversing changes made to 40dbb46.

mountiny mentioned this pull request Jan 5, 2026

[CP Staging] Revert "Merge pull request #77474 from rayane-d/policy-tax-settings-c… #78835

Merged

53 tasks

lakchote added a commit that referenced this pull request Jan 5, 2026

Merge pull request #78835 from Expensify/vit-77474

1214a4d

[CP Staging] Revert "Merge pull request #77474 from rayane-d/policy-tax-settings-c…

mountiny pushed a commit that referenced this pull request Jan 5, 2026

Merge pull request #78835 from Expensify/vit-77474

f45cc69

[CP Staging] Revert "Merge pull request #77474 from rayane-d/policy-tax-settings-c… (cherry picked from commit 1214a4d) (cherry-picked to staging by mountiny)

abzokhattab pushed a commit to abzokhattab/App that referenced this pull request Jan 6, 2026

Revert "Merge pull request Expensify#77474 from rayane-d/policy-tax-s…

b74984c

…ettings-changelogs" This reverts commit 21af0fb, reversing changes made to 40dbb46.

abzokhattab pushed a commit to abzokhattab/App that referenced this pull request Jan 6, 2026

Merge pull request Expensify#78835 from Expensify/vit-77474

b6ba279

[CP Staging] Revert "Merge pull request Expensify#77474 from rayane-d/policy-tax-settings-c…

Conversation

rayane-d commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Prerequisites

Test Steps 1

Test Steps 2

Test Steps 3

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 12, 2025

Uh oh!

codecov bot commented Dec 12, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 12, 2025

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

rayane-d commented Dec 16, 2025

Uh oh!

rayane-d commented Dec 16, 2025

Uh oh!

rayane-d commented Dec 16, 2025

Uh oh!

rayane-d commented Dec 24, 2025

Uh oh!

madmax330 commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jan 2, 2026

Uh oh!

OSBotify commented Jan 2, 2026

Uh oh!

OSBotify commented Jan 5, 2026

Uh oh!

OSBotify commented Jan 5, 2026

Uh oh!

OSBotify commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rayane-d commented Dec 12, 2025 •

edited

Loading

codecov bot commented Dec 12, 2025 •

edited by github-actions bot

Loading

madmax330 commented Jan 2, 2026 •

edited

Loading