Fix: Different error messages on invalid distance rate and inaccessible policy by huult · Pull Request #77596 · Expensify/App

huult · 2025-12-13T03:53:05Z

Explanation of Change

Ensure the rate and distance fields are read-only when the policy is not accessible, preventing edits in invalid states.

Fixed Issues

$ #71564
PROPOSAL: #71564 (comment)

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Bug 1:

Open the Expensify app.
Go to the workspace chat.
Create a distance expense on the Map tab.
Create a distance expense on the Manual tab.
Delete the workspace.
Open the expense report.
Verify that the rate and distance are read-only and cannot be edited.

Bug 2:

Open the Expensify app.
Go to the workspace chat.
Create a distance expense on the Map tab. For example, select a rate of 0.9.
Create a distance expense on the Manual tab. For example, select a rate of 0.9.
Go to the workspace settings and delete the 0.9 rate.
Open the expense report.
Open the Manual distance expense and change the distance.
Open the Map distance expense and change the distance (from/to).
Verify that both distance expenses show the same error message and that the error message is displayed in the correct place.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-16.at.09.50.36.mp4

Android: mWeb Chrome

Screen.Recording.2025-12-16.at.09.53.51.mp4

iOS: Native

Screen.Recording.2025-12-16.at.09.56.05.mp4

iOS: mWeb Safari

Screen.Recording.2025-12-16.at.10.03.53.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-12-16.at.09.45.47.mp4

melvin-bot · 2025-12-13T03:53:11Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-13T04:01:33Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/IOU.ts	`64.95% <100.00%> (+0.03%)`	⬆️
src/libs/actions/Transaction.ts	`56.96% <ø> (-2.49%)`	⬇️
...c/components/ReportActionItem/MoneyRequestView.tsx	`0.25% <0.00%> (-0.01%)`	⬇️
... and 9 files with indirect coverage changes

…or-message-invalid-distance-rate

huult · 2025-12-15T15:38:51Z

Screen.Recording.2025-12-15.at.22.37.17.mov

@QichenZhu Do we still hide "Unexpected error editing this expense. Please try again later." in this case?

QichenZhu · 2025-12-15T18:15:34Z

@huult we need to remove it because:

Map distances don't have that error.
The error doesn't provide useful info.
We've discussed it with the team many times, and they also think it's an issue.

Also, not only the error, I think we should remove the greyed message too because it's misleading (note that the Distance field doesn't change).

…or-message-invalid-distance-rate

huult · 2025-12-16T03:12:15Z

@QichenZhu Thank you, this PR is ready.

QichenZhu · 2025-12-16T09:47:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
https://expensify.slack.com/archives/C049HHMV9SM/p1765878401901779
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-native-1.webm
android-native-2.webm

Android: mWeb Chrome

android-web-1.webm
android-web-2.webm

iOS: HybridApp

ios-native-1.mov

ios-native-2.mov

iOS: mWeb Safari

ios-web-1.mov

ios-web-2.mov

MacOS: Chrome / Safari

mac-web-1.mov

mac-web-2.mov

…or-message-invalid-distance-rate

JmillsExpensify

Error messages look good.

…or-message-invalid-distance-rate

MonilBhavsar · 2025-12-22T11:27:59Z

Updated the PR title to be more meaningful cc @huult

OSBotify · 2025-12-22T11:38:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-23T00:51:53Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.2.86-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-24T18:49:00Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

thesahindia · 2026-03-25T11:26:20Z

src/components/ReportActionItem/MoneyRequestView.tsx

+    const canEditDistanceRate =
+        isEditable &&
+        canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.DISTANCE_RATE, undefined, isChatReportArchived) &&
+        isPolicyAccessible(policy, currentUserEmailParam);


#80499 was caused by this. More info in #80499 (comment)

huult added 2 commits December 13, 2025 10:44

Make rate and distance read-only if the policy is not accessible

f1aad3e

Remove unused condition

3bceb9c

huult requested review from a team as code owners December 13, 2025 03:53

melvin-bot bot assigned huult Dec 13, 2025

melvin-bot bot requested review from JmillsExpensify and QichenZhu December 13, 2025 03:53

melvin-bot bot removed request for a team December 13, 2025 03:53

huult marked this pull request as draft December 13, 2025 03:54

Merge remote-tracking branch 'upstream/main' into 71564-different-err…

60dcfcc

…or-message-invalid-distance-rate

huult added 2 commits December 16, 2025 09:02

Merge remote-tracking branch 'upstream/main' into 71564-different-err…

a073e7f

…or-message-invalid-distance-rate

Don't push error to failureData when updating distance requests

1026a04

huult marked this pull request as ready for review December 16, 2025 03:11

QichenZhu approved these changes Dec 16, 2025

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar December 16, 2025 10:05

Merge remote-tracking branch 'upstream/main' into 71564-different-err…

b68901b

…or-message-invalid-distance-rate

JmillsExpensify approved these changes Dec 18, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into 71564-different-err…

06b5c04

…or-message-invalid-distance-rate

MonilBhavsar approved these changes Dec 22, 2025

View reviewed changes

MonilBhavsar changed the title ~~71564 different error message invalid distance rate~~ Fix: Different error messages on invalid distance rate and inaccessible policy Dec 22, 2025

MonilBhavsar merged commit 7511846 into Expensify:main Dec 22, 2025
31 checks passed

OSBotify mentioned this pull request Dec 23, 2025

Deploy Checklist: New Expensify 2025-12-23 #78313

Closed

melvin-bot bot mentioned this pull request Dec 24, 2025

[Due for payment 2025-12-31] [$375] Different error message when editing Map & Manual distance expense when rate is not valid #71564

Closed

8 tasks

nkdengineer mentioned this pull request Jan 26, 2026

[Awaiting Checklist] [$250] Expense - Unable to edit the route after creating distance expense in selfDM #80499

Open

7 tasks

thesahindia reviewed Mar 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Different error messages on invalid distance rate and inaccessible policy#77596

Fix: Different error messages on invalid distance rate and inaccessible policy#77596
MonilBhavsar merged 7 commits intoExpensify:mainfrom
huult:71564-different-error-message-invalid-distance-rate

huult commented Dec 13, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Dec 13, 2025

Uh oh!

codecov bot commented Dec 13, 2025 •

edited by github-actions bot

Loading

Uh oh!

huult commented Dec 15, 2025

Uh oh!

QichenZhu commented Dec 15, 2025

Uh oh!

huult commented Dec 16, 2025

Uh oh!

QichenZhu commented Dec 16, 2025

Uh oh!

JmillsExpensify left a comment

Uh oh!

MonilBhavsar commented Dec 22, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 22, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

OSBotify commented Dec 24, 2025

Uh oh!

thesahindia Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

huult commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 13, 2025

Uh oh!

codecov bot commented Dec 13, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

huult commented Dec 15, 2025

Uh oh!

QichenZhu commented Dec 15, 2025

Uh oh!

huult commented Dec 16, 2025

Uh oh!

QichenZhu commented Dec 16, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar commented Dec 22, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 22, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

OSBotify commented Dec 24, 2025

Uh oh!

thesahindia Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

huult commented Dec 13, 2025 •

edited

Loading

codecov bot commented Dec 13, 2025 •

edited by github-actions bot

Loading